Re: [PATCH v5 3/5] hyperv: Enable the hypercall output page for the VTL mode

2025-01-08 Thread Roman Kisel
On 1/8/2025 2:19 PM, Stanislav Kinsburskii wrote: On Wed, Jan 08, 2025 at 12:37:17PM -0800, Roman Kisel wrote: On 1/8/2025 11:17 AM, Stanislav Kinsburskii wrote: On Tue, Jan 07, 2025 at 03:11:15PM -0800, Roman Kisel wrote: [...] Avoiding using the output hypercall page leads to someth

Re: [PATCH v5 3/5] hyperv: Enable the hypercall output page for the VTL mode

2025-01-08 Thread Stanislav Kinsburskii
On Wed, Jan 08, 2025 at 12:37:17PM -0800, Roman Kisel wrote: > > > On 1/8/2025 11:17 AM, Stanislav Kinsburskii wrote: > > On Tue, Jan 07, 2025 at 03:11:15PM -0800, Roman Kisel wrote: > > [...] > > > > > > > Avoiding using the output hypercall page leads to something like[1] > > > and it looks

Re: [PATCH v5 3/5] hyperv: Enable the hypercall output page for the VTL mode

2025-01-08 Thread Roman Kisel
On 1/8/2025 1:08 PM, Nuno Das Neves wrote: On 12/30/2024 10:09 AM, Roman Kisel wrote: [...] Replying in a new thread since I don't have all the context about the different VTL code paths that may need to converge. To my perspective, the approach in this patch seems perfectly reasonable to

Re: [PATCH v5 3/5] hyperv: Enable the hypercall output page for the VTL mode

2025-01-08 Thread Nuno Das Neves
On 12/30/2024 10:09 AM, Roman Kisel wrote: > Due to the hypercall page not being allocated in the VTL mode, > the code resorts to using a part of the input page. > > Allocate the hypercall output page in the VTL mode thus enabling > it to use it for output and share code with dom0. > > Signed-off

Re: [PATCH v5 3/5] hyperv: Enable the hypercall output page for the VTL mode

2025-01-08 Thread Roman Kisel
On 1/8/2025 11:17 AM, Stanislav Kinsburskii wrote: On Tue, Jan 07, 2025 at 03:11:15PM -0800, Roman Kisel wrote: [...] Avoiding using the output hypercall page leads to something like[1] and it looks quite complicated although that's the bare bones, lots of notes. How is this related to

Re: [PATCH v5 3/5] hyperv: Enable the hypercall output page for the VTL mode

2025-01-08 Thread Stanislav Kinsburskii
On Tue, Jan 07, 2025 at 03:11:15PM -0800, Roman Kisel wrote: > > > On 1/7/2025 11:18 AM, Stanislav Kinsburskii wrote: > > On Mon, Jan 06, 2025 at 01:07:25PM -0800, Roman Kisel wrote: > > > > [...] > > > My point is that the proposed fix looks more like an Underhill-tailored > > bandage and doe

Re: [PATCH v5 3/5] hyperv: Enable the hypercall output page for the VTL mode

2025-01-08 Thread Wei Liu
On Tue, Jan 07, 2025 at 03:11:15PM -0800, Roman Kisel wrote: > > > On 1/7/2025 11:18 AM, Stanislav Kinsburskii wrote: > > On Mon, Jan 06, 2025 at 01:07:25PM -0800, Roman Kisel wrote: > > > > [...] > > > My point is that the proposed fix looks more like an Underhill-tailored > > bandage and doe

Re: [PATCH v5 3/5] hyperv: Enable the hypercall output page for the VTL mode

2025-01-07 Thread Roman Kisel
On 1/7/2025 11:18 AM, Stanislav Kinsburskii wrote: On Mon, Jan 06, 2025 at 01:07:25PM -0800, Roman Kisel wrote: [...] My point is that the proposed fix looks more like an Underhill-tailored bandage and doesn't take the needs of other stake holders into consideration. The patch takes as m

Re: [PATCH v5 3/5] hyperv: Enable the hypercall output page for the VTL mode

2025-01-07 Thread Stanislav Kinsburskii
On Mon, Jan 06, 2025 at 01:07:25PM -0800, Roman Kisel wrote: > > > On 1/6/2025 11:32 AM, Stanislav Kinsburskii wrote: > > On Mon, Jan 06, 2025 at 10:11:16AM -0800, Roman Kisel wrote: > [...]s > > > From my POV a decision between a unified approach and interim solutions > > in upstream should usu

Re: [PATCH v5 3/5] hyperv: Enable the hypercall output page for the VTL mode

2025-01-06 Thread Roman Kisel
On 1/6/2025 11:32 AM, Stanislav Kinsburskii wrote: On Mon, Jan 06, 2025 at 10:11:16AM -0800, Roman Kisel wrote: [...]s From my POV a decision between a unified approach and interim solutions in upstream should usually be resolved in favor of the former. Given there are different stake holde

Re: [PATCH v5 3/5] hyperv: Enable the hypercall output page for the VTL mode

2025-01-06 Thread Stanislav Kinsburskii
On Mon, Jan 06, 2025 at 07:49:15PM +, Michael Kelley wrote: > From: Stanislav Kinsburskii Sent: Monday, > January 6, 2025 11:19 AM > > > > On Mon, Jan 06, 2025 at 06:18:51PM +, Michael Kelley wrote: > > > From: Stanislav Kinsburskii Sent: > > > Monday, January 6, 2025 9:23 AM > > > > >

RE: [PATCH v5 3/5] hyperv: Enable the hypercall output page for the VTL mode

2025-01-06 Thread Michael Kelley
From: Stanislav Kinsburskii Sent: Monday, January 6, 2025 11:19 AM > > On Mon, Jan 06, 2025 at 06:18:51PM +, Michael Kelley wrote: > > From: Stanislav Kinsburskii Sent: > > Monday, January 6, 2025 9:23 AM > > > > > > On Fri, Jan 03, 2025 at 10:08:05PM +, Michael Kelley wrote: > > > > F

Re: [PATCH v5 3/5] hyperv: Enable the hypercall output page for the VTL mode

2025-01-06 Thread Stanislav Kinsburskii
On Mon, Jan 06, 2025 at 10:11:16AM -0800, Roman Kisel wrote: > > > On 1/6/2025 9:11 AM, Stanislav Kinsburskii wrote: > > On Fri, Jan 03, 2025 at 01:39:29PM -0800, Roman Kisel wrote: > > > > > [...] > > > > > > > > The issue is that when you boot the same kernel in both VTL0 and VTL1+, > > th

Re: [PATCH v5 3/5] hyperv: Enable the hypercall output page for the VTL mode

2025-01-06 Thread Stanislav Kinsburskii
On Mon, Jan 06, 2025 at 06:18:51PM +, Michael Kelley wrote: > From: Stanislav Kinsburskii Sent: Monday, > January 6, 2025 9:23 AM > > > > On Fri, Jan 03, 2025 at 10:08:05PM +, Michael Kelley wrote: > > > From: Stanislav Kinsburskii Sent: > > > Friday, January > > 3, 2025 11:20 AM > > >

RE: [PATCH v5 3/5] hyperv: Enable the hypercall output page for the VTL mode

2025-01-06 Thread Michael Kelley
From: Stanislav Kinsburskii Sent: Monday, January 6, 2025 9:23 AM > > On Fri, Jan 03, 2025 at 10:08:05PM +, Michael Kelley wrote: > > From: Stanislav Kinsburskii Sent: > > Friday, January > 3, 2025 11:20 AM > > > > > > On Mon, Dec 30, 2024 at 10:09:39AM -0800, Roman Kisel wrote: > > > > Du

Re: [PATCH v5 3/5] hyperv: Enable the hypercall output page for the VTL mode

2025-01-06 Thread Roman Kisel
On 1/6/2025 9:11 AM, Stanislav Kinsburskii wrote: On Fri, Jan 03, 2025 at 01:39:29PM -0800, Roman Kisel wrote: [...] The issue is that when you boot the same kernel in both VTL0 and VTL1+, the pages will be allocated in any case (root or guest, VTL0 or VTL1+). I think we share we sa

Re: [PATCH v5 3/5] hyperv: Enable the hypercall output page for the VTL mode

2025-01-06 Thread Stanislav Kinsburskii
On Fri, Jan 03, 2025 at 10:08:05PM +, Michael Kelley wrote: > From: Stanislav Kinsburskii Sent: Friday, > January 3, 2025 11:20 AM > > > > On Mon, Dec 30, 2024 at 10:09:39AM -0800, Roman Kisel wrote: > > > Due to the hypercall page not being allocated in the VTL mode, > > > the code resorts

Re: [PATCH v5 3/5] hyperv: Enable the hypercall output page for the VTL mode

2025-01-06 Thread Stanislav Kinsburskii
On Fri, Jan 03, 2025 at 01:39:29PM -0800, Roman Kisel wrote: > > > On 1/3/2025 11:20 AM, Stanislav Kinsburskii wrote: > > On Mon, Dec 30, 2024 at 10:09:39AM -0800, Roman Kisel wrote: > > > Due to the hypercall page not being allocated in the VTL mode, > > > the code resorts to using a part of the

RE: [PATCH v5 3/5] hyperv: Enable the hypercall output page for the VTL mode

2025-01-06 Thread Michael Kelley
From: Alex Ionescu Sent: Monday, January 6, 2025 6:54 AM > > For another 2c worth, I had previously requested #1 (always allocate > output page) as this would simplify some further work I was interested > in at some point to provide VSM-like functionality to a VTL 0 Linux > guest, which would, at

Re: [PATCH v5 3/5] hyperv: Enable the hypercall output page for the VTL mode

2025-01-06 Thread Alex Ionescu
For another 2c worth, I had previously requested #1 (always allocate output page) as this would simplify some further work I was interested in at some point to provide VSM-like functionality to a VTL 0 Linux guest, which would, at that point, not make it wasteful for VTL 0 any longer (since some re

RE: [PATCH v5 3/5] hyperv: Enable the hypercall output page for the VTL mode

2025-01-03 Thread Michael Kelley
From: Stanislav Kinsburskii Sent: Friday, January 3, 2025 11:20 AM > > On Mon, Dec 30, 2024 at 10:09:39AM -0800, Roman Kisel wrote: > > Due to the hypercall page not being allocated in the VTL mode, > > the code resorts to using a part of the input page. > > > > Allocate the hypercall output pag

Re: [PATCH v5 3/5] hyperv: Enable the hypercall output page for the VTL mode

2025-01-03 Thread Roman Kisel
On 1/3/2025 11:20 AM, Stanislav Kinsburskii wrote: On Mon, Dec 30, 2024 at 10:09:39AM -0800, Roman Kisel wrote: Due to the hypercall page not being allocated in the VTL mode, the code resorts to using a part of the input page. Allocate the hypercall output page in the VTL mode thus enabling

Re: [PATCH v5 3/5] hyperv: Enable the hypercall output page for the VTL mode

2025-01-03 Thread Stanislav Kinsburskii
On Mon, Dec 30, 2024 at 10:09:39AM -0800, Roman Kisel wrote: > Due to the hypercall page not being allocated in the VTL mode, > the code resorts to using a part of the input page. > > Allocate the hypercall output page in the VTL mode thus enabling > it to use it for output and share code with dom

[PATCH v5 3/5] hyperv: Enable the hypercall output page for the VTL mode

2024-12-30 Thread Roman Kisel
Due to the hypercall page not being allocated in the VTL mode, the code resorts to using a part of the input page. Allocate the hypercall output page in the VTL mode thus enabling it to use it for output and share code with dom0. Signed-off-by: Roman Kisel --- drivers/hv/hv_common.c | 6 +++---