Re: [PATCH v5 06/10] Drivers/hv: Export some functions for use by root partition module

2025-03-07 Thread Nuno Das Neves
On 3/6/2025 11:23 AM, Michael Kelley wrote: > From: Nuno Das Neves Sent: Wednesday, > February 26, 2025 3:08 PM >> > > Nit: For the patch Subject line, use prefix "Drivers: hv:" instead of with a > slash. > That's what we usually use and what you have used for other patches in this > series. >

Re: [PATCH v5 06/10] Drivers/hv: Export some functions for use by root partition module

2025-02-27 Thread Easwar Hariharan
On 2/26/2025 3:08 PM, Nuno Das Neves wrote: > get_hypervisor_version, hv_call_deposit_pages, hv_call_create_vp, > hv_call_deposit_pages, and hv_call_create_vp are all needed in module > with CONFIG_MSHV_ROOT=m. > Nit: It's generally good practice to use parentheses when mentioning functions, i.e

Re: [PATCH v5 06/10] Drivers/hv: Export some functions for use by root partition module

2025-02-27 Thread Roman Kisel
On 2/26/2025 3:08 PM, Nuno Das Neves wrote: get_hypervisor_version, hv_call_deposit_pages, hv_call_create_vp, hv_call_deposit_pages, and hv_call_create_vp are all needed in module with CONFIG_MSHV_ROOT=m. Signed-off-by: Nuno Das Neves --- arch/arm64/hyperv/mshyperv.c | 1 + arch/x86/ker

Re: [PATCH v5 06/10] Drivers/hv: Export some functions for use by root partition module

2025-02-26 Thread Stanislav Kinsburskii
On Wed, Feb 26, 2025 at 03:08:00PM -0800, Nuno Das Neves wrote: > get_hypervisor_version, hv_call_deposit_pages, hv_call_create_vp, > hv_call_deposit_pages, and hv_call_create_vp are all needed in module > with CONFIG_MSHV_ROOT=m. > Reviewed-by: Stanislav Kinsburskii

[PATCH v5 06/10] Drivers/hv: Export some functions for use by root partition module

2025-02-26 Thread Nuno Das Neves
get_hypervisor_version, hv_call_deposit_pages, hv_call_create_vp, hv_call_deposit_pages, and hv_call_create_vp are all needed in module with CONFIG_MSHV_ROOT=m. Signed-off-by: Nuno Das Neves --- arch/arm64/hyperv/mshyperv.c | 1 + arch/x86/kernel/cpu/mshyperv.c | 1 + drivers/hv/hv_common.c