Re: [PATCH v5 04/10] hyperv: Introduce hv_recommend_using_aeoi()

On Thu, Feb 27, 2025 at 7:09 AM Nuno Das Neves wrote: > > Factor out the check for enabling auto eoi, to be reused in root > partition code. > > Signed-off-by: Nuno Das Neves > --- Reviewed-by: Tianyu Lan -- Thanks Tianyu Lan

RE: [PATCH v5 04/10] hyperv: Introduce hv_recommend_using_aeoi()

From: Nuno Das Neves > > Factor out the check for enabling auto eoi, to be reused in root > partition code. Reviewed-by: Michael Kelley > > Signed-off-by: Nuno Das Neves > --- > drivers/hv/hv.c| 12 +--- > include/asm-generic/mshyperv.h | 13 + > 2 files

Re: [PATCH v5 04/10] hyperv: Introduce hv_recommend_using_aeoi()

On 2/26/2025 3:07 PM, Nuno Das Neves wrote: > Factor out the check for enabling auto eoi, to be reused in root > partition code. > > Signed-off-by: Nuno Das Neves > --- > drivers/hv/hv.c| 12 +--- > include/asm-generic/mshyperv.h | 13 + > 2 files changed, 14

Re: [PATCH v5 04/10] hyperv: Introduce hv_recommend_using_aeoi()

On 2/27/2025 4:33 PM, Nuno Das Neves wrote: > On 2/27/2025 3:03 PM, Easwar Hariharan wrote: >> On 2/26/2025 3:07 PM, Nuno Das Neves wrote: >>> Factor out the check for enabling auto eoi, to be reused in root >>> partition code. >>> >>> Signed-off-by: Nuno Das Neves >>> --- >>> drivers/hv/hv.c

Re: [PATCH v5 04/10] hyperv: Introduce hv_recommend_using_aeoi()

On 2/27/2025 3:03 PM, Easwar Hariharan wrote: > On 2/26/2025 3:07 PM, Nuno Das Neves wrote: >> Factor out the check for enabling auto eoi, to be reused in root >> partition code. >> >> Signed-off-by: Nuno Das Neves >> --- >> drivers/hv/hv.c| 12 +--- >> include/asm-generic

Re: [PATCH v5 04/10] hyperv: Introduce hv_recommend_using_aeoi()

On 2/27/2025 10:04 AM, Roman Kisel wrote: > > > On 2/26/2025 3:07 PM, Nuno Das Neves wrote: >> Factor out the check for enabling auto eoi, to be reused in root >> partition code. >> >> Signed-off-by: Nuno Das Neves >> --- > > I think adding "No functional changes" would bring some benefit: > th

Re: [PATCH v5 04/10] hyperv: Introduce hv_recommend_using_aeoi()

On 2/26/2025 3:07 PM, Nuno Das Neves wrote: Factor out the check for enabling auto eoi, to be reused in root partition code. Signed-off-by: Nuno Das Neves --- I think adding "No functional changes" would bring some benefit: that's an additional invariant to check against when reviewing. -

Re: [PATCH v5 04/10] hyperv: Introduce hv_recommend_using_aeoi()

On Wed, Feb 26, 2025 at 03:07:58PM -0800, Nuno Das Neves wrote: > Factor out the check for enabling auto eoi, to be reused in root > partition code. > Reviewed-by: Stanislav Kinsburskii

[PATCH v5 04/10] hyperv: Introduce hv_recommend_using_aeoi()

Factor out the check for enabling auto eoi, to be reused in root partition code. Signed-off-by: Nuno Das Neves --- drivers/hv/hv.c| 12 +--- include/asm-generic/mshyperv.h | 13 + 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/hv/hv.c