On 3/6/2025 10:09 AM, Michael Kelley wrote:
> From: Michael Kelley Sent: Thursday, March 6, 2025
> 9:58 AM
>
>>
>> From: Nuno Das Neves Sent: Wednesday,
>> February
>> 26, 2025 3:08 PM
>>>
>>> Introduce hv_result_to_string() for this purpose. This allows
>>> hypercall failures to be debugged m
On 3/6/2025 9:57 AM, Michael Kelley wrote:
> From: Nuno Das Neves Sent: Wednesday,
> February 26, 2025 3:08 PM
>>
>> Introduce hv_result_to_string() for this purpose. This allows
>> hypercall failures to be debugged more easily with dmesg.
>>
>> Signed-off-by: Nuno Das Neves
>> ---
>> drivers/h
From: Nuno Das Neves Sent: Thursday, March
6, 2025 10:41 AM
>
> On 3/6/2025 10:09 AM, Michael Kelley wrote:
> > From: Michael Kelley Sent: Thursday, March 6, 2025
> > 9:58 AM
> >
[snip]
> >> I've read through the other comments on this patch. I definitely vote
> >> for outputting both the he
From: Michael Kelley Sent: Thursday, March 6, 2025 9:58
AM
>
> From: Nuno Das Neves Sent: Wednesday,
> February
> 26, 2025 3:08 PM
> >
> > Introduce hv_result_to_string() for this purpose. This allows
> > hypercall failures to be debugged more easily with dmesg.
> >
> > Signed-off-by: Nuno Da
From: Nuno Das Neves Sent: Wednesday,
February 26, 2025 3:08 PM
>
> Introduce hv_result_to_string() for this purpose. This allows
> hypercall failures to be debugged more easily with dmesg.
>
> Signed-off-by: Nuno Das Neves
> ---
> drivers/hv/hv_common.c | 65 +
On 2/28/2025 9:20 AM, Roman Kisel wrote:
>
>
> On 2/27/2025 3:25 PM, Easwar Hariharan wrote:
>> On 2/27/2025 3:08 PM, Roman Kisel wrote:
>
> [...]
>
>>> Would be great to learn the details to understand how this function is
>>> going to improve the situation:
>>>
>>> 1. How come the hex error c
On 2/28/2025 12:22 PM, Easwar Hariharan wrote:
On 2/28/2025 9:20 AM, Roman Kisel wrote:
[...]
So I'd think that the hex error codes from the hypervisor give the user
exactly as much as the error symbolic names do to get the system to the
desired state: nothing.
I continue to disagree,
On 2/27/2025 3:25 PM, Easwar Hariharan wrote:
On 2/27/2025 3:08 PM, Roman Kisel wrote:
[...]
Would be great to learn the details to understand how this function is
going to improve the situation:
1. How come the hex error code was useless, what is not matching
anything in the Linux he
On 2/27/2025 4:15 PM, Nuno Das Neves wrote:
On 2/27/2025 9:02 AM, Roman Kisel wrote:
[...]
I guess you're implying it's not worth adding such a function for only a
few places in the code? That is a good point, and a bit of an oversight
on my part while editing this series. Originally all t
On 2/27/2025 9:02 AM, Roman Kisel wrote:
>
>
> On 2/26/2025 3:07 PM, Nuno Das Neves wrote:
>
> [...]
>
>> +
>> +const char *hv_result_to_string(u64 hv_status)
>> +{
>> + switch (hv_result(hv_status)) {
>
> [...]
>
>> + return "HV_STATUS_VTL_ALREADY_ENABLED";
>> + default:
>> +
On 2/27/2025 9:02 AM, Roman Kisel wrote:
>
>
> On 2/26/2025 3:07 PM, Nuno Das Neves wrote:
>
> [...]
>
>> +
>> +const char *hv_result_to_string(u64 hv_status)
>> +{
>> + switch (hv_result(hv_status)) {
>
> [...]
>
>> + return "HV_STATUS_VTL_ALREADY_ENABLED";
>> + default:
>> +
On 2/27/2025 3:08 PM, Roman Kisel wrote:
>
>
> On 2/27/2025 2:54 PM, Easwar Hariharan wrote:
> [...]
>
>>
>> Sorry, I have to disagree with this, a recent commit of mine[1] closed a WSL
>> issue that was open for over 2 years for, partly, the utter uselessness of
>> the hex return code of the hy
On 2/26/2025 8:22 PM, Easwar Hariharan wrote:
> On 2/26/2025 3:07 PM, Nuno Das Neves wrote:
>> Introduce hv_result_to_string() for this purpose. This allows
>> hypercall failures to be debugged more easily with dmesg.
>>
>
> Let the commit message stand on its own, i.e. state that hv_result_to_str
On 2/27/2025 2:54 PM, Easwar Hariharan wrote:
On 2/27/2025 9:02 AM, Roman Kisel wrote:
[...]
Sorry, I have to disagree with this, a recent commit of mine[1] closed a WSL
issue that was open for over 2 years for, partly, the utter uselessness of
the hex return code of the hypercall.
What
On 2/27/2025 2:54 PM, Easwar Hariharan wrote:
[...]
Sorry, I have to disagree with this, a recent commit of mine[1] closed a WSL
issue that was open for over 2 years for, partly, the utter uselessness of
the hex return code of the hypercall.
Thanks for your efforts, and sorry to hear you h
On 2/26/2025 3:07 PM, Nuno Das Neves wrote:
[...]
+
+const char *hv_result_to_string(u64 hv_status)
+{
+ switch (hv_result(hv_status)) {
[...]
+ return "HV_STATUS_VTL_ALREADY_ENABLED";
+ default:
+ return "Unknown";
+ };
+ return "Unkno
On 2/26/2025 3:07 PM, Nuno Das Neves wrote:
> Introduce hv_result_to_string() for this purpose. This allows
> hypercall failures to be debugged more easily with dmesg.
>
Let the commit message stand on its own, i.e. state that hv_result_to_string()
is introduced to convert hyper-v status codes to
On Wed, Feb 26, 2025 at 03:07:55PM -0800, Nuno Das Neves wrote:
> Introduce hv_result_to_string() for this purpose. This allows
> hypercall failures to be debugged more easily with dmesg.
>
> Signed-off-by: Nuno Das Neves
> ---
> drivers/hv/hv_common.c | 65 ++
Introduce hv_result_to_string() for this purpose. This allows
hypercall failures to be debugged more easily with dmesg.
Signed-off-by: Nuno Das Neves
---
drivers/hv/hv_common.c | 65 ++
drivers/hv/hv_proc.c | 13 ---
include/asm-generic/mshyp
19 matches
Mail list logo
