Re: [PATCH v1] tools/hv: terminate fcopy daemon if read from uio fails

2024-10-28 Thread Saurabh Singh Sengar
On Mon, Oct 28, 2024 at 04:01:56PM +0100, Olaf Hering wrote: > Mon, 28 Oct 2024 02:06:20 -0700 Saurabh Singh Sengar > : > > > Thanks for the patch. Changes look good to me, I will suggest to improve > > this > > log message incase the error type is EIO by suggesting that users verify if > > 'Gue

Re: [PATCH v1] tools/hv: terminate fcopy daemon if read from uio fails

2024-10-28 Thread Olaf Hering
Mon, 28 Oct 2024 02:06:20 -0700 Saurabh Singh Sengar : > Thanks for the patch. Changes look good to me, I will suggest to improve this > log message incase the error type is EIO by suggesting that users verify if > 'Guest Services' is enabled. No error happens if the state of "Guest services" re

Re: [PATCH v1] tools/hv: terminate fcopy daemon if read from uio fails

2024-10-28 Thread Saurabh Singh Sengar
On Fri, Oct 25, 2024 at 04:28:27PM +0200, Olaf Hering wrote: > Terminate endless loop in reading fails, to avoid flooding syslog. > > This happens if the "Guest services" integration service is > disabled at runtime in the VM settings. > > Also handle an interrupted system call, and continue in t

[PATCH v1] tools/hv: terminate fcopy daemon if read from uio fails

2024-10-25 Thread Olaf Hering
Terminate endless loop in reading fails, to avoid flooding syslog. This happens if the "Guest services" integration service is disabled at runtime in the VM settings. Also handle an interrupted system call, and continue in this case. Signed-off-by: Olaf Hering --- A more complete fix is to han