Re: [PATCH net 1/1] hv_netvsc: Calculate correct ring size when PAGE_SIZE is not 4 Kbytes

2024-01-24 Thread Simon Horman
On Tue, Jan 23, 2024 at 05:13:12PM +, Michael Kelley wrote: > From: Simon Horman @ 2024-01-22 20:49 UTC (permalink / raw) > > > > On Mon, Jan 22, 2024 at 08:20:28AM -0800, mhkelle...@gmail.com wrote: > > > From: Michael Kelley > > > > > > Current code in netvsc_drv_init() incorrectly assumes

Re: [PATCH net 1/1] hv_netvsc: Calculate correct ring size when PAGE_SIZE is not 4 Kbytes

2024-01-23 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Mon, 22 Jan 2024 08:20:28 -0800 you wrote: > From: Michael Kelley > > Current code in netvsc_drv_init() incorrectly assumes that PAGE_SIZE > is 4 Kbytes, which is wrong on ARM64 with 16K or 64K page size. As a > resul

RE: [PATCH net 1/1] hv_netvsc: Calculate correct ring size when PAGE_SIZE is not 4 Kbytes

2024-01-23 Thread Michael Kelley
From: Simon Horman @ 2024-01-22 20:49 UTC (permalink / raw) > > On Mon, Jan 22, 2024 at 08:20:28AM -0800, mhkelle...@gmail.com wrote: > > From: Michael Kelley > > > > Current code in netvsc_drv_init() incorrectly assumes that PAGE_SIZE > > is 4 Kbytes, which is wrong on ARM64 with 16K or 64K page

Re: [PATCH net 1/1] hv_netvsc: Calculate correct ring size when PAGE_SIZE is not 4 Kbytes

2024-01-22 Thread Simon Horman
On Mon, Jan 22, 2024 at 08:20:28AM -0800, mhkelle...@gmail.com wrote: > From: Michael Kelley > > Current code in netvsc_drv_init() incorrectly assumes that PAGE_SIZE > is 4 Kbytes, which is wrong on ARM64 with 16K or 64K page size. As a > result, the default VMBus ring buffer size on ARM64 with 6

[PATCH net 1/1] hv_netvsc: Calculate correct ring size when PAGE_SIZE is not 4 Kbytes

2024-01-22 Thread mhkelley58
From: Michael Kelley Current code in netvsc_drv_init() incorrectly assumes that PAGE_SIZE is 4 Kbytes, which is wrong on ARM64 with 16K or 64K page size. As a result, the default VMBus ring buffer size on ARM64 with 64K page size is 8 Mbytes instead of the expected 512 Kbytes. While this doesn't