Re: [PATCH net-next v2] net: mana: Implement get_ringparam/set_ringparam for mana

2024-08-04 Thread Shradha Gupta
On Sat, Aug 03, 2024 at 11:31:54AM -0700, Stephen Hemminger wrote: > On Sun, 4 Aug 2024 02:09:21 +0800 > Zhu Yanjun wrote: > > > > > > > /* The minimum size of the WQE is 32 bytes, hence > > > - * MAX_SEND_BUFFERS_PER_QUEUE represents the maximum number of WQEs > > > + * apc->tx

Re: [PATCH net-next v2] net: mana: Implement get_ringparam/set_ringparam for mana

2024-08-03 Thread Stephen Hemminger
On Sun, 4 Aug 2024 02:09:21 +0800 Zhu Yanjun wrote: > > > > /* The minimum size of the WQE is 32 bytes, hence > > -* MAX_SEND_BUFFERS_PER_QUEUE represents the maximum number of WQEs > > +* apc->tx_queue_size represents the maximum number of WQEs > > * the SQ can store. Thi

Re: [PATCH net-next v2] net: mana: Implement get_ringparam/set_ringparam for mana

2024-08-03 Thread Zhu Yanjun
在 2024/7/31 1:01, Shradha Gupta 写道: Currently the values of WQs for RX and TX queues for MANA devices are hardcoded to default sizes. Allow configuring these values for MANA devices as ringparam configuration(get/set) through ethtool_ops. Signed-off-by: Shradha Gupta Reviewed-by: Haiyang Zhang

Re: [PATCH net-next v2] net: mana: Implement get_ringparam/set_ringparam for mana

2024-08-01 Thread Shradha Gupta
On Thu, Aug 01, 2024 at 07:16:49AM -0700, Jakub Kicinski wrote: > On Wed, 31 Jul 2024 20:49:05 -0700 Shradha Gupta wrote: > > It is a pretty standard support for network drivers to allow changing > > TX/RX queue sizes. We are working on improving customizations in MANA > > driver based on VM config

Re: [PATCH net-next v2] net: mana: Implement get_ringparam/set_ringparam for mana

2024-08-01 Thread Jakub Kicinski
On Wed, 31 Jul 2024 20:49:05 -0700 Shradha Gupta wrote: > It is a pretty standard support for network drivers to allow changing > TX/RX queue sizes. We are working on improving customizations in MANA > driver based on VM configurations. This patch is a part of that series. > Hope that makes things

Re: [PATCH net-next v2] net: mana: Implement get_ringparam/set_ringparam for mana

2024-07-31 Thread Shradha Gupta
On Wed, Jul 31, 2024 at 05:15:18PM -0700, Jakub Kicinski wrote: > On Tue, 30 Jul 2024 10:01:35 -0700 Shradha Gupta wrote: > > + err1 = mana_detach(ndev, false); > > + if (err1) { > > + netdev_err(ndev, "mana_detach failed: %d\n", err1); > > + return err1; > > + } > > + > >

Re: [PATCH net-next v2] net: mana: Implement get_ringparam/set_ringparam for mana

2024-07-31 Thread Shradha Gupta
On Wed, Jul 31, 2024 at 02:19:34PM +0530, Naman Jain wrote: > > > On 7/30/2024 10:31 PM, Shradha Gupta wrote: > >Currently the values of WQs for RX and TX queues for MANA devices > >are hardcoded to default sizes. > >Allow configuring these values for MANA devices as ringparam > >configuration(ge

Re: [PATCH net-next v2] net: mana: Implement get_ringparam/set_ringparam for mana

2024-07-31 Thread Jakub Kicinski
On Tue, 30 Jul 2024 10:01:35 -0700 Shradha Gupta wrote: > + err1 = mana_detach(ndev, false); > + if (err1) { > + netdev_err(ndev, "mana_detach failed: %d\n", err1); > + return err1; > + } > + > + apc->tx_queue_size = new_tx; > + apc->rx_queue_size = new_r

Re: [PATCH net-next v2] net: mana: Implement get_ringparam/set_ringparam for mana

2024-07-31 Thread Naman Jain
On 7/30/2024 10:31 PM, Shradha Gupta wrote: Currently the values of WQs for RX and TX queues for MANA devices are hardcoded to default sizes. Allow configuring these values for MANA devices as ringparam configuration(get/set) through ethtool_ops. Signed-off-by: Shradha Gupta Reviewed-by: Hai

[PATCH net-next v2] net: mana: Implement get_ringparam/set_ringparam for mana

2024-07-30 Thread Shradha Gupta
Currently the values of WQs for RX and TX queues for MANA devices are hardcoded to default sizes. Allow configuring these values for MANA devices as ringparam configuration(get/set) through ethtool_ops. Signed-off-by: Shradha Gupta Reviewed-by: Haiyang Zhang Reviewed-by: Long Li --- Changes in