Re: [PATCH net-next 0/3] vsock: support network namespace

2025-03-11 Thread Stefano Garzarella
On Thu, 6 Mar 2025 at 01:17, Jason Wang wrote: > > On Wed, Mar 5, 2025 at 5:30 PM Stefano Garzarella wrote: > > > > On Wed, Mar 05, 2025 at 02:27:12AM -0500, Michael S. Tsirkin wrote: > > >On Tue, Mar 04, 2025 at 04:39:02PM -0800, Bobby Eshleman wrote: > > >> I think it might be a lot of complexi

Re: [PATCH net-next 0/3] vsock: support network namespace

2025-03-10 Thread Jason Wang
On Tue, Mar 11, 2025 at 8:54 AM Jason Wang wrote: > > On Mon, Mar 10, 2025 at 10:15 PM Stefano Garzarella > wrote: > > > > On Thu, 6 Mar 2025 at 01:17, Jason Wang wrote: > > > > > > On Wed, Mar 5, 2025 at 5:30 PM Stefano Garzarella > > > wrote: > > > > > > > > On Wed, Mar 05, 2025 at 02:27:12

Re: [PATCH net-next 0/3] vsock: support network namespace

2025-03-10 Thread Jason Wang
On Tue, Mar 11, 2025 at 4:14 AM Bobby Eshleman wrote: > > On Wed, Mar 05, 2025 at 01:46:54PM +0800, Jason Wang wrote: > > On Wed, Mar 5, 2025 at 8:39 AM Bobby Eshleman > > wrote: > > > > > > On Tue, Apr 28, 2020 at 06:00:52PM +0200, Stefano Garzarella wrote: > > > > On Tue, Apr 28, 2020 at 04:13

Re: [PATCH net-next 0/3] vsock: support network namespace

2025-03-10 Thread Jason Wang
On Mon, Mar 10, 2025 at 10:15 PM Stefano Garzarella wrote: > > On Thu, 6 Mar 2025 at 01:17, Jason Wang wrote: > > > > On Wed, Mar 5, 2025 at 5:30 PM Stefano Garzarella > > wrote: > > > > > > On Wed, Mar 05, 2025 at 02:27:12AM -0500, Michael S. Tsirkin wrote: > > > >On Tue, Mar 04, 2025 at 04:39

Re: [PATCH net-next 0/3] vsock: support network namespace

2025-03-10 Thread Bobby Eshleman
On Wed, Mar 05, 2025 at 01:46:54PM +0800, Jason Wang wrote: > On Wed, Mar 5, 2025 at 8:39 AM Bobby Eshleman wrote: > > > > On Tue, Apr 28, 2020 at 06:00:52PM +0200, Stefano Garzarella wrote: > > > On Tue, Apr 28, 2020 at 04:13:22PM +0800, Jason Wang wrote: > > > > WRT netdev, do we foresee big gai

Re: [PATCH net-next 0/3] vsock: support network namespace

2025-03-06 Thread Stefano Garzarella
On Thu, 6 Mar 2025 at 02:37, Lei Yang wrote: > > QE tested this series patch with virtio-net regression tests, > everything works fine. > > Tested-by: Lei Yang Sorry, but this test doesn't involve virtio-net at all, so what is the point on testing it with virtio-net? Thanks, Stefano > > On Thu

Re: [PATCH net-next 0/3] vsock: support network namespace

2025-03-05 Thread Lei Yang
QE tested this series patch with virtio-net regression tests, everything works fine. Tested-by: Lei Yang On Thu, Mar 6, 2025 at 8:17 AM Jason Wang wrote: > > On Wed, Mar 5, 2025 at 5:30 PM Stefano Garzarella wrote: > > > > On Wed, Mar 05, 2025 at 02:27:12AM -0500, Michael S. Tsirkin wrote: > >

Re: [PATCH net-next 0/3] vsock: support network namespace

2025-03-05 Thread Jason Wang
On Wed, Mar 5, 2025 at 5:30 PM Stefano Garzarella wrote: > > On Wed, Mar 05, 2025 at 02:27:12AM -0500, Michael S. Tsirkin wrote: > >On Tue, Mar 04, 2025 at 04:39:02PM -0800, Bobby Eshleman wrote: > >> I think it might be a lot of complexity to bring into the picture from > >> netdev, and I'm not s

Re: [PATCH net-next 0/3] vsock: support network namespace

2025-03-05 Thread Bobby Eshleman
On Wed, Mar 05, 2025 at 10:42:58AM +0100, Stefano Garzarella wrote: > On Tue, Mar 04, 2025 at 04:06:02PM -0800, Bobby Eshleman wrote: > > On Thu, Jan 16, 2020 at 06:24:25PM +0100, Stefano Garzarella wrote: > > > > One question: what is the behavior we expect from guest namespaces? In > > v2, you

Re: [PATCH net-next 0/3] vsock: support network namespace

2025-03-05 Thread Bobby Eshleman
On Wed, Mar 05, 2025 at 10:30:17AM +0100, Stefano Garzarella wrote: > On Wed, Mar 05, 2025 at 02:27:12AM -0500, Michael S. Tsirkin wrote: > > On Tue, Mar 04, 2025 at 04:39:02PM -0800, Bobby Eshleman wrote: > > > I think it might be a lot of complexity to bring into the picture from > > > netdev, an

Re: [PATCH net-next 0/3] vsock: support network namespace

2025-03-05 Thread Stefano Garzarella
On Tue, Mar 04, 2025 at 04:06:02PM -0800, Bobby Eshleman wrote: On Thu, Jan 16, 2020 at 06:24:25PM +0100, Stefano Garzarella wrote: RFC -> v1: * added 'netns' module param to vsock.ko to enable the network namespace support (disabled by default) * added 'vsock_net_eq()' to check the "net" a

Re: [PATCH net-next 0/3] vsock: support network namespace

2025-03-05 Thread Stefano Garzarella
On Wed, Mar 05, 2025 at 02:27:12AM -0500, Michael S. Tsirkin wrote: On Tue, Mar 04, 2025 at 04:39:02PM -0800, Bobby Eshleman wrote: I think it might be a lot of complexity to bring into the picture from netdev, and I'm not sure there is a big win since the vsock device could also have a vsock->n

Re: [PATCH net-next 0/3] vsock: support network namespace

2025-03-04 Thread Michael S. Tsirkin
On Tue, Mar 04, 2025 at 04:39:02PM -0800, Bobby Eshleman wrote: > I think it might be a lot of complexity to bring into the picture from > netdev, and I'm not sure there is a big win since the vsock device could > also have a vsock->net itself? I think the complexity will come from the > address tr

Re: [PATCH net-next 0/3] vsock: support network namespace

2025-03-04 Thread Jason Wang
On Wed, Mar 5, 2025 at 8:39 AM Bobby Eshleman wrote: > > On Tue, Apr 28, 2020 at 06:00:52PM +0200, Stefano Garzarella wrote: > > On Tue, Apr 28, 2020 at 04:13:22PM +0800, Jason Wang wrote: > > > > > > > > > As we've discussed, it should be a netdev probably in either guest or host > > > side. And

Re: [PATCH net-next 0/3] vsock: support network namespace

2025-03-04 Thread Bobby Eshleman
On Tue, Apr 28, 2020 at 06:00:52PM +0200, Stefano Garzarella wrote: > On Tue, Apr 28, 2020 at 04:13:22PM +0800, Jason Wang wrote: > > > > > > As we've discussed, it should be a netdev probably in either guest or host > > side. And it would be much simpler if we want do implement namespace then. >

Re: [PATCH net-next 0/3] vsock: support network namespace

2025-03-04 Thread Bobby Eshleman
On Thu, Jan 16, 2020 at 06:24:25PM +0100, Stefano Garzarella wrote: > RFC -> v1: > * added 'netns' module param to vsock.ko to enable the >network namespace support (disabled by default) > * added 'vsock_net_eq()' to check the "net" assigned to a socket >only when 'netns' support is enabl