Re: [PATCH 1/3] net: mana: Add speed support in mana_get_link_ksettings

2025-04-18 Thread Erni Sri Satya Vennela
On Thu, Apr 17, 2025 at 03:38:26PM +0200, Zhu Yanjun wrote: > On 17.04.25 09:57, Erni Sri Satya Vennela wrote: > >Add support for speed in mana ethtool get_link_ksettings > >operation. This feature is not supported by all hardware. > > > >Signed-off-by: Erni Sri Satya Vennela > >Reviewed-by: Shrad

Re: [PATCH 1/3] net: mana: Add speed support in mana_get_link_ksettings

2025-04-17 Thread Zhu Yanjun
On 17.04.25 09:57, Erni Sri Satya Vennela wrote: Add support for speed in mana ethtool get_link_ksettings operation. This feature is not supported by all hardware. Signed-off-by: Erni Sri Satya Vennela Reviewed-by: Shradha Gupta Reviewed-by: Haiyang Zhang --- drivers/net/ethernet/microsoft/

[PATCH 1/3] net: mana: Add speed support in mana_get_link_ksettings

2025-04-17 Thread Erni Sri Satya Vennela
Add support for speed in mana ethtool get_link_ksettings operation. This feature is not supported by all hardware. Signed-off-by: Erni Sri Satya Vennela Reviewed-by: Shradha Gupta Reviewed-by: Haiyang Zhang --- drivers/net/ethernet/microsoft/mana/mana_en.c | 42 +++ .../etherne

Re: [PATCH 1/3] net: mana: Add speed support in mana_get_link_ksettings

2025-03-25 Thread Andrew Lunn
> The QoS control is at the hardware/firmware level and applies to the > egress rate. egress relative to the VM? So what the VM sends to the hypervisor. There is no restriction the other way, hypervisor to the VM? That is not what link modes do. 10Mbps is the limit in both directions. > > Also,

Re: [PATCH 1/3] net: mana: Add speed support in mana_get_link_ksettings

2025-03-25 Thread Erni Sri Satya Vennela
On Mon, Mar 24, 2025 at 07:44:39PM +0100, Andrew Lunn wrote: > On Mon, Mar 24, 2025 at 10:43:39AM -0700, Erni Sri Satya Vennela wrote: > > On Thu, Mar 20, 2025 at 02:37:47PM +0100, Andrew Lunn wrote: > > > > +int mana_query_link_cfg(struct mana_port_context *apc) > > > > +{ > > > > + struct n

Re: [PATCH 1/3] net: mana: Add speed support in mana_get_link_ksettings

2025-03-24 Thread Andrew Lunn
On Mon, Mar 24, 2025 at 10:43:39AM -0700, Erni Sri Satya Vennela wrote: > On Thu, Mar 20, 2025 at 02:37:47PM +0100, Andrew Lunn wrote: > > > +int mana_query_link_cfg(struct mana_port_context *apc) > > > +{ > > > + struct net_device *ndev = apc->ndev; > > > + struct mana_query_link_config_req req =

Re: [PATCH 1/3] net: mana: Add speed support in mana_get_link_ksettings

2025-03-24 Thread Erni Sri Satya Vennela
On Thu, Mar 20, 2025 at 02:37:47PM +0100, Andrew Lunn wrote: > > +int mana_query_link_cfg(struct mana_port_context *apc) > > +{ > > + struct net_device *ndev = apc->ndev; > > + struct mana_query_link_config_req req = {}; > > + struct mana_query_link_config_resp resp = {}; > > + int err; > >

Re: [PATCH 1/3] net: mana: Add speed support in mana_get_link_ksettings

2025-03-20 Thread Andrew Lunn
> +int mana_query_link_cfg(struct mana_port_context *apc) > +{ > + struct net_device *ndev = apc->ndev; > + struct mana_query_link_config_req req = {}; > + struct mana_query_link_config_resp resp = {}; > + int err; > + > + mana_gd_init_req_hdr(&req.hdr, MANA_QUERY_LINK_CONFIG, >

[PATCH 1/3] net: mana: Add speed support in mana_get_link_ksettings

2025-03-20 Thread Erni Sri Satya Vennela
Add support for speed in mana ethtool get_link_ksettings operation. This feature is not supported by all hardware. Signed-off-by: Erni Sri Satya Vennela Reviewed-by: Haiyang Zhang Reviewed-by: Shradha Gupta --- drivers/net/ethernet/microsoft/mana/mana_en.c | 42 +++ .../etherne