Re: [PATCH v2] net: mana: Add debug logs in MANA network driver

Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Mon, 17 Feb 2025 17:34:15 -0800 you wrote: > Add more logs to assist in debugging and monitoring > driver behaviour, making it easier to identify potential > issues during development and testing. > > Signed-off-

Re: [PATCH v3 net-next 0/2] Enable Big TCP for MANA devices

Hello: This series was applied to netdev/net-next.git (main) by David S. Miller : On Sun, 16 Feb 2025 19:41:55 -0800 you wrote: > Allow the max gso/gro aggregated pkt size to go up to GSO_MAX_SIZE for > MANA NIC. On Azure, this not possible without allowing the same for > netvsc NIC (as the NICs

Re: [PATCH net] net: mana: Cleanup "mana" debugfs dir after cleanup of all children

Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Wed, 8 Jan 2025 21:03:11 -0800 you wrote: > In mana_driver_exit(), mana_debugfs_root gets cleanup before any of it's > children (which happens later in the pci_unregister_driver()). > Due to this, when mana driver is c

Re: [PATCH v2 0/2] MANA: Fix few memory leaks in mana_gd_setup_irqs

Hello: This series was applied to netdev/net.git (main) by Jakub Kicinski : On Mon, 9 Dec 2024 12:57:49 -0500 you wrote: > Fix 2 minor memory leaks in the mana driver, > introduced by commit > > 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores") > > Best regards, > Maxim Levi

Re: [PATCH net] net :mana :Request a V2 response version for MANA_QUERY_GF_STAT

Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni : On Tue, 3 Dec 2024 21:48:20 -0800 you wrote: > The current requested response version(V1) for MANA_QUERY_GF_STAT query > results in STATISTICS_FLAGS_TX_ERRORS_GDMA_ERROR value being set to > 0 always. > In order to get the c

Re: [PATCH v2] hv_sock: Initializing vsk->trans to NULL to prevent a dangling pointer

Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Wed, 6 Nov 2024 04:36:04 -0500 you wrote: > When hvs is released, there is a possibility that vsk->trans may not > be initialized to NULL, which could lead to a dangling pointer. > This issue is resolved by initial

Re: [PATCH] net: mana: use ethtool string helpers

Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Tue, 22 Oct 2024 13:49:08 -0700 you wrote: > The latter is the preferred way to copy ethtool strings. > > Avoids manually incrementing the data pointer. > > Signed-off-by: Rosen Penev > --- > .../ethernet/micro

Re: [PATCH net,v3] hv_netvsc: Fix VF namespace also in synthetic NIC NETDEV_REGISTER event

Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni : On Fri, 18 Oct 2024 11:25:22 -0700 you wrote: > The existing code moves VF to the same namespace as the synthetic NIC > during netvsc_register_vf(). But, if the synthetic device is moved to a > new namespace after the VF regi

Re: [PATCH net-next v2] net: mana: Enable debugfs files for MANA device

Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller : On Tue, 8 Oct 2024 00:06:15 -0700 you wrote: > Implement debugfs in MANA driver to be able to view RX,TX,EQ queue > specific attributes and dump their gdma queues. > These dumps can be used by other userspace utilit

Re: [net-next v2 0/1] hyperv: Link queues to NAPIs

Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller : On Mon, 30 Sep 2024 17:27:08 + you wrote: > Greetings: > > Welcome to v2. > > This was previously an RFC [1], see changelog below. > > I've only compile tested this series; I don't have the software for testin

Re: [PATCH 0/5] hyper-v: Don't assume cpu_possible_mask is dense

Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski : On Wed, 2 Oct 2024 20:53:28 -0700 you wrote: > From: Michael Kelley > > Code specific to Hyper-V guests currently assumes the cpu_possible_mask > is "dense" -- i.e., all bit positions 0 thru (nr_cpu_ids - 1) are s

Re: [PATCH net-next v2] net: mana: Add get_link and get_link_ksettings in ethtool

Hello: This patch was applied to netdev/net-next.git (main) by Paolo Abeni : On Sun, 29 Sep 2024 22:42:14 -0700 you wrote: > Add support for the ethtool get_link and get_link_ksettings > operations. Display standard port information using ethtool. > > Before the change: > $ethtool enP30832s1 > >

Re: [PATCH net-next RESEND] net: mana: Increase the DEF_RX_BUFFERS_PER_QUEUE to 1024

Hello: This patch was applied to netdev/net-next.git (main) by Paolo Abeni : On Sun, 29 Sep 2024 20:44:35 -0700 you wrote: > Through some experiments, we found out that increasing the default > RX buffers count from 512 to 1024, gives slightly better throughput > and significantly reduces the no_

Re: [PATCH net-next v2] net: mana: Improve mana_set_channels() in low mem conditions

Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Sun, 1 Sep 2024 20:45:34 -0700 you wrote: > The mana_set_channels() function requires detaching the mana > driver and reattaching it with changed channel values. > During this operation if the system is low on mem

Re: [PATCH V4 net] net: mana: Fix error handling in mana_create_txq/rxq's NAPI cleanup

Hello: This patch was applied to netdev/net.git (main) by David S. Miller : On Mon, 2 Sep 2024 05:43:47 -0700 you wrote: > Currently napi_disable() gets called during rxq and txq cleanup, > even before napi is enabled and hrtimer is initialized. It causes > kernel panic. > > ? page_fault_oops+0

Re: [PATCH v4] net: netvsc: Update default VMBus channels

Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Mon, 26 Aug 2024 22:16:31 -0700 you wrote: > Change VMBus channels macro (VRSS_CHANNEL_DEFAULT) in > Linux netvsc from 8 to 16 to align with Azure Windows VM > and improve networking throughput. > > For VMs having

Re: [PATCH net-next v5] net: mana: Implement get_ringparam/set_ringparam for mana

Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Mon, 26 Aug 2024 09:07:41 -0700 you wrote: > Currently the values of WQs for RX and TX queues for MANA devices > are hardcoded to default sizes. > Allow configuring these values for MANA devices as ringparam > conf

Re: [PATCH net-next v2] net: refactor ->ndo_bpf calls into dev_xdp_propagate

Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller : On Thu, 22 Aug 2024 05:51:54 + you wrote: > When net devices propagate xdp configurations to slave devices, > we will need to perform a memory provider check to ensure we're > not binding xdp to a device using un

Re: [PATCH net] net: mana: Fix race of mana_hwc_post_rx_wqe and new hwc response

Hello: This patch was applied to netdev/net.git (main) by David S. Miller : On Wed, 21 Aug 2024 13:42:29 -0700 you wrote: > The mana_hwc_rx_event_handler() / mana_hwc_handle_resp() calls > complete(&ctx->comp_event) before posting the wqe back. It's > possible that other callers, like mana_create

Re: [PATCH v3 net] net: mana: Fix doorbell out of order violation and avoid unnecessary doorbell rings

Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni : On Fri, 9 Aug 2024 08:58:58 -0700 you wrote: > From: Long Li > > After napi_complete_done() is called when NAPI is polling in the current > process context, another NAPI may be scheduled and start running in > softirq on a

Re: [PATCH net] net: mana: Fix RX buf alloc_size alignment and atomic op panic

Hello: This patch was applied to netdev/net.git (main) by David S. Miller : On Fri, 9 Aug 2024 14:01:24 -0700 you wrote: > The MANA driver's RX buffer alloc_size is passed into napi_build_skb() to > create SKB. skb_shinfo(skb) is located at the end of skb, and its alignment > is affected by the

Re: [PATCH v3] net: mana: Fix possible double free in error handling path

Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni : On Tue, 25 Jun 2024 21:03:14 +0800 you wrote: > When auxiliary_device_add() returns error and then calls > auxiliary_device_uninit(), callback function adev_release > calls kfree(madev). We shouldn't call kfree(madev) again >

Re: [PATCH v3,net-next] net: mana: Add support for page sizes other than 4KB on ARM64

Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Mon, 17 Jun 2024 13:17:26 -0700 you wrote: > As defined by the MANA Hardware spec, the queue size for DMA is 4KB > minimal, and power of 2. And, the HWC queue size has to be exactly > 4KB. > > To support page size

Re: [PATCH net-next] net: mana: Use mana_cleanup_port_context() for rxq cleanup

Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Fri, 14 Jun 2024 00:19:08 -0700 you wrote: > To cleanup rxqs in port context structures, instead of duplicating the > code, use existing function mana_cleanup_port_context() which does > the exact cleanup that's ne

Re: [PATCH V2 net] net: mana: Fix the extra HZ in mana_hwc_send_request

Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni : On Sun, 19 May 2024 23:05:04 -0700 you wrote: > Commit 62c1bff593b7 added an extra HZ along with msecs_to_jiffies. > This patch fixes that. > > Cc: sta...@vger.kernel.org > Fixes: 62c1bff593b7 ("net: mana: Configure hwc time

Re: [PATCH net-next] net: mana: Enable MANA driver on ARM64 with 4K page size

Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Mon, 13 May 2024 13:29:01 -0700 you wrote: > Change the Kconfig dependency, so this driver can be built and run on ARM64 > with 4K page size. > 16/64K page sizes are not supported yet. > > Signed-off-by: Haiyang Z

Re: [PATCH net,v2] net: mana: Fix Rx DMA datasize and skb_over_panic

Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Tue, 2 Apr 2024 12:48:36 -0700 you wrote: > mana_get_rxbuf_cfg() aligns the RX buffer's DMA datasize to be > multiple of 64. So a packet slightly bigger than mtu+14, say 1536, > can be received and cause skb_over_panic

Re: [PATCH net,v2] hv_netvsc: Register VF in netvsc_probe if NET_DEVICE_REGISTER missed

Hello: This patch was applied to netdev/net.git (main) by David S. Miller : On Thu, 1 Feb 2024 20:40:38 -0800 you wrote: > If hv_netvsc driver is unloaded and reloaded, the NET_DEVICE_REGISTER > handler cannot perform VF register successfully as the register call > is received before netvsc_prob

Re: [PATCH V2 net] hv_netvsc: Fix race condition between netvsc_probe and netvsc_remove

Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Tue, 30 Jan 2024 23:35:51 -0800 you wrote: > In commit ac5047671758 ("hv_netvsc: Disable NAPI before closing the > VMBus channel"), napi_disable was getting called for all channels, > including all subchannels without c

Re: [PATCH 0/4 V3 net-next] net: mana: Assigning IRQ affinity on HT cores

Hello: This series was applied to netdev/net-next.git (main) by Paolo Abeni : On Sun, 28 Jan 2024 22:21:03 -0800 you wrote: > This patch set introduces a new helper function irq_setup(), > to optimize IRQ distribution for MANA network devices. > The patch set makes the driver working 15% faster t

Re: [PATCH net 1/1] hv_netvsc: Calculate correct ring size when PAGE_SIZE is not 4 Kbytes

Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Mon, 22 Jan 2024 08:20:28 -0800 you wrote: > From: Michael Kelley > > Current code in netvsc_drv_init() incorrectly assumes that PAGE_SIZE > is 4 Kbytes, which is wrong on ARM64 with 16K or 64K page size. As a > resul

Re: [PATCH] net: mana: select PAGE_POOL

Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni : On Fri, 15 Dec 2023 12:33:53 -0800 you wrote: > Mana uses PAGE_POOL API. x86_64 defconfig doesn't select it: > > ld: vmlinux.o: in function `mana_create_page_pool.isra.0': > mana_en.c:(.text+0x9ae36f): undefined reference to

Re: [PATCH] hv_netvsc: remove duplicated including of slab.h

Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller : On Fri, 15 Dec 2023 18:06:59 +0800 you wrote: > rm the second include > > Signed-off-by: Wang Jinchao > --- > drivers/net/hyperv/rndis_filter.c | 1 - > 1 file changed, 1 deletion(-) Here is the summary with lin

Re: [PATCH for-next v2] net: mana: add msix index sharing between EQs

Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller : On Wed, 13 Dec 2023 02:01:47 -0800 you wrote: > From: Konstantin Taranov > > This patch allows to assign and poll more than one EQ on the same > msix index. > It is achieved by introducing a list of attached EQs in

Re: [PATCH net-next v5 0/3] ethtool: Add ethtool_puts()

Hello: This series was applied to netdev/net-next.git (main) by David S. Miller : On Wed, 06 Dec 2023 23:16:09 + you wrote: > Hi, > > This series aims to implement ethtool_puts() and send out a wave 1 of > conversions from ethtool_sprintf(). There's also a checkpatch patch > included to chec

Re: [PATCH v2] hv_netvsc: rndis_filter needs to select NLS

Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Wed, 29 Nov 2023 21:58:53 -0800 you wrote: > rndis_filter uses utf8s_to_utf16s() which is provided by setting > NLS, so select NLS to fix the build error: > > ERROR: modpost: "utf8s_to_utf16s" [drivers/net/hyperv/hv_ne

Re: [PATCH][next] net: mana: Fix spelling mistake "enforecement" -> "enforcement"

Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Tue, 28 Nov 2023 09:53:04 + you wrote: > There is a spelling mistake in struct field hc_tx_err_sqpdid_enforecement. > Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/net/ethernet/microsoft/mana/man

Re: [PATCH] net :mana :Add remaining GDMA stats for MANA to ethtool

Hello: This patch was applied to netdev/net-next.git (main) by Paolo Abeni : On Fri, 24 Nov 2023 05:02:30 -0800 you wrote: > Extend performance counter stats in 'ethtool -S ' > for MANA VF to include all GDMA stat counter. > > Tested-on: Ubuntu22 > Testcases: > 1. LISA testcase: > PERF-NETWORK-T

Re: [PATCH net,v5, 0/3] hv_netvsc: fix race of netvsc, VF register, and slave bit

Hello: This series was applied to netdev/net.git (main) by Paolo Abeni : On Sun, 19 Nov 2023 08:23:40 -0800 you wrote: > There are some races between netvsc probe, set notifier, VF register, > and slave bit setting. > This patch set fixes them. > > Haiyang Zhang (2): > hv_netvsc: fix race of n

Re: [PATCH net-next v7] hv_netvsc: fix netvsc_send_completion to avoid multiple message length checks

Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller : On Mon, 9 Oct 2023 01:00:16 -0700 you wrote: > From: Sonia Sharma > > The switch statement in netvsc_send_completion() is incorrectly validating > the length of incoming network packets by falling through to the n

Re: [PATCH net,v2, 0/3] net: mana: Fix some TX processing bugs

Hello: This series was applied to netdev/net.git (main) by Paolo Abeni : On Fri, 29 Sep 2023 13:42:24 -0700 you wrote: > Fix TX processing bugs on error handling, tso_bytes calculation, > and sge0 size. > > Haiyang Zhang (3): > net: mana: Fix TX CQE error handling > net: mana: Fix the tso_by