g Li
> Reviewed-by: Shradha Gupta
> ---
> v2: Fix alignment, extra dmesg.
>
> ---
> drivers/net/ethernet/microsoft/mana/gdma_main.c | 14 ++
> include/net/mana/gdma.h | 11 +++
> 2 files changed, 17 insertions(+), 8 deletions(-)
>
Thanks,
Reviewed-by: Michal Swiatkowski
> --
> 2.34.1
/net/ethernet/microsoft/mana/gdma_main.c
> index 2dc0c6ad54be..be95336ce089 100644
> --- a/drivers/net/ethernet/microsoft/mana/gdma_main.c
> +++ b/drivers/net/ethernet/microsoft/mana/gdma_main.c
> @@ -1656,9 +1656,9 @@ static int __init mana_driver_init(void)
>
> static void __exit mana_driver_exit(void)
> {
> - debugfs_remove(mana_debugfs_root);
> -
> pci_unregister_driver(&mana_driver);
> +
> + debugfs_remove(mana_debugfs_root);
Reviewed-by: Michal Swiatkowski
Thanks
> }
>
> module_init(mana_driver_init);
> --
> 2.34.1
>
On Mon, Dec 09, 2024 at 12:57:49PM -0500, Maxim Levitsky wrote:
> Fix 2 minor memory leaks in the mana driver,
> introduced by commit
>
> 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
>
> Best regards,
> Maxim Levitsky
>
For next time please add a changleog, like here for
On Tue, Dec 10, 2024 at 07:13:53AM +0100, Michal Swiatkowski wrote:
> On Mon, Dec 09, 2024 at 12:57:50PM -0500, Maxim Levitsky wrote:
> > Commit 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
> > added memory allocation in mana_gd_setup_irqs of 'irqs&
irq_contexts);
> - kfree(irqs);
> gc->irq_contexts = NULL;
> +free_irq_array:
> + kfree(irqs);
> free_irq_vector:
> cpus_read_unlock();
> pci_free_irq_vectors(pdev);
Reviewed-by: Michal Swiatkowski
> --
> 2.26.3
On Mon, Dec 09, 2024 at 12:57:50PM -0500, Maxim Levitsky wrote:
> Commit 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
> added memory allocation in mana_gd_setup_irqs of 'irqs' but the code
> doesn't free this temporary array in the success path.
>
> This was caught by kmemleak.
>
