Re: [PATCH v2 2/2] net: mana: Fix irq_contexts memory leak in mana_gd_setup_irqs

2024-12-10 Thread Kalesh Anakkur Purayil
On Mon, Dec 9, 2024 at 11:29 PM Maxim Levitsky wrote: > > gc->irq_contexts is not freeded if one of the later operations > fail. > > Suggested-by: Michael Kelley > Fixes: 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores") > Signed-off-by: Maxim Levitsky LGTM Reviewed-by: Kalesh AP

Re: [PATCH v2 1/2] net: mana: Fix memory leak in mana_gd_setup_irqs

2024-12-10 Thread Kalesh Anakkur Purayil
On Mon, Dec 9, 2024 at 11:28 PM Maxim Levitsky wrote: > > Commit 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores") > added memory allocation in mana_gd_setup_irqs of 'irqs' but the code > doesn't free this temporary array in the success path. > > This was caught by kmemleak. > > Fixes

Re: [PATCH net-next] net: mana: Enable debugfs files for MANA device

2024-10-04 Thread Kalesh Anakkur Purayil
On Tue, Oct 1, 2024 at 9:10 AM Shradha Gupta wrote: > > Implement debugfs in MANA driver to be able to view RX,TX,EQ queue > specific attributes and dump their gdma queues. > These dumps can be used by other userspace utilities to improve > debuggability and troubleshooting > > Following files are

Re: [EXTERNAL] Re: [Patch v7 4/5] RDMA/mana_ib: Query adapter capabilities

2023-10-18 Thread Kalesh Anakkur Purayil
On Wed, Oct 18, 2023 at 10:46 PM Ajay Sharma wrote: > > > > > *From:* Kalesh Anakkur Purayil > *Sent:* Tuesday, October 17, 2023 9:11 PM > *To:* Ajay Sharma > *Cc:* sharmaa...@linuxonhyperv.com; Long Li ; Jason > Gunthorpe ; Leon Romanovsky ; Dexuan Cui < &

Re: [EXTERNAL] Re: [Patch v7 4/5] RDMA/mana_ib: Query adapter capabilities

2023-10-17 Thread Kalesh Anakkur Purayil
On Tue, Oct 17, 2023 at 11:17 AM Ajay Sharma wrote: > > > On Oct 16, 2023, at 9:32 PM, Kalesh Anakkur Purayil < > kalesh-anakkur.pura...@broadcom.com> wrote: > >  > Hi Ajay, > > One comment in line. > > Regards, > Kalesh > > On Tue, Oct 17

Re: [Patch v7 4/5] RDMA/mana_ib: Query adapter capabilities

2023-10-16 Thread Kalesh Anakkur Purayil
Hi Ajay, One comment in line. Regards, Kalesh On Tue, Oct 17, 2023 at 3:42 AM wrote: > From: Ajay Sharma > > Query the adapter capabilities to expose to > other clients and VF. This checks against > the user supplied values and protects against > overflows. > > Signed-off-by: Ajay Sharma > -