Re: [patch V2 05/10] PCI/MSI: Switch to MSI descriptor locking to guard()

eadability issue for another day. Reviewed-by: Jonathan Cameron > --- a/drivers/pci/msi/msi.c > +++ b/drivers/pci/msi/msi.c > +static int msix_setup_interrupts(struct pci_dev *dev, struct msix_entry > *entries, > + int nvec, struct irq_affinity *affd) >

Re: [patch V2 01/10] cleanup: Provide retain_ptr()

eturn value is not really a > sensible option either. > > Provide an explicit macro retain_ptr(), which NULLs the cleanup > pointer. That makes it easy to analyze and reason about. > > Signed-off-by: Thomas Gleixner > Cc: Peter Zijlstra Seems sensible to me and the

Re: [patch V2 02/10] genirq/msi: Use lock guards for MSI descriptor locking

On Thu, 13 Mar 2025 14:03:39 +0100 (CET) Thomas Gleixner wrote: > Provide a lock guard for MSI descriptor locking and update the core code > accordingly. > > No functional change intended. > > Signed-off-by: Thomas Gleixner Reviewed-by: Jonathan Cameron

Re: [patch 02/10] genirq/msi: Use lock guards for MSI descriptor locking

On Tue, 11 Mar 2025 22:26:52 +0100 Thomas Gleixner wrote: > On Tue, Mar 11 2025 at 18:00, Jonathan Cameron wrote: > > On Sun, 9 Mar 2025 09:41:44 +0100 (CET) > > Thomas Gleixner wrote: > > >> > >> @@ -1037,25 +1032,23 @@ bool msi_create

Re: [patch 05/10] PCI/MSI: Switch to MSI descriptor locking to guard()

On Tue, 11 Mar 2025 22:45:44 +0100 Thomas Gleixner wrote: > On Tue, Mar 11 2025 at 18:10, Jonathan Cameron wrote: > > On Sun, 9 Mar 2025 09:41:49 +0100 (CET) > > Thomas Gleixner wrote: > > > > This one runs into some of the stuff that the docs say > > to not

Re: [patch 10/10] genirq/msi: Rename msi_[un]lock_descs()

r Sensible. Reviewed-by: Jonathan Cameron

Re: [patch 06/10] PCI: hv: Switch MSI descriptor locking to guard()

hyperv@vger.kernel.org > Cc: linux-...@vger.kernel.org Reviewed-by: Jonathan Cameron

Re: [patch 05/10] PCI/MSI: Switch to MSI descriptor locking to guard()

On Sun, 9 Mar 2025 09:41:49 +0100 (CET) Thomas Gleixner wrote: > Convert the code to use the new guard(msi_descs_lock). > > No functional change intended. > > Signed-off-by: Thomas Gleixner > Cc: Bjorn Helgaas > Cc: linux-...@vger.kernel.org This one runs into some of the stuff that the doc

Re: [patch 04/10] NTB/msi: Switch MSI descriptor locking to lock guard()

On Sun, 9 Mar 2025 09:41:48 +0100 (CET) Thomas Gleixner wrote: > Convert the code to use the new guard(msi_descs_lock). > > No functional change intended. > > Signed-off-by: Thomas Gleixner > Cc: Jon Mason > Cc: Dave Jiang > Cc: Allen Hubbe > Cc: n...@lists.linu

Re: [patch 03/10] soc: ti: ti_sci_inta_msi: Switch MSI descriptor locking to guard()

On Sun, 9 Mar 2025 09:41:46 +0100 (CET) Thomas Gleixner wrote: > Convert the code to use the new guard(msi_descs_lock). > > No functional change intended. > > Signed-off-by: Thomas Gleixner > Cc: Nishanth Menon > Cc: Tero Kristo > Cc: Santosh Shilimkar Reviewed-by: Jonathan Cameron

Re: [patch 02/10] genirq/msi: Use lock guards for MSI descriptor locking

cs Dan wrote after early confusion on how to use this stuff. We might want to consider updating as you've found a case that I at least didn't consider when reviewing those. +CC Dan. Anyhow, this seems fine to me. Reviewed-by: Jonathan Cameron > > --- a/kernel/irq/msi.c &g

Re: [patch 01/10] genirq/msi: Make a few functions static

On Sun, 9 Mar 2025 09:41:42 +0100 (CET) Thomas Gleixner wrote: > None of these functions are used outside of the MSI core. > > Signed-off-by: Thomas Gleixner Reviewed-by: Jonathan Cameron