Re: [PATCH v2 12/17] iommu: Make iommu_ops_from_fwnode() static

2023-11-15 Thread Jerry Snitselaar
Reviewed-by: Jerry Snitselaar

Re: [PATCH v2 00/17] Solve iommu probe races around iommu_fwspec

2023-11-15 Thread Jerry Snitselaar
Did patch 12 v2 get sent? I'm not seeing it locally, nor in lore, and b4 doesn't find it when pulling then thread. Regards, Jerry

Re: [PATCH v2 04/17] acpi: Do not return struct iommu_ops from acpi_iommu_configure_id()

2023-11-15 Thread Jerry Snitselaar
Reviewed-by: Jerry Snitselaar

Re: [PATCH v2 03/17] iommu/of: Use -ENODEV consistently in of_iommu_configure()

2023-11-15 Thread Jerry Snitselaar
Reviewed-by: Jerry Snitselaar

Re: [PATCH RFC 17/17] iommu: Mark dev_iommu_priv_set() with a lockdep

2023-11-13 Thread Jerry Snitselaar
Reviewed-by: Jerry Snitselaar

Re: [PATCH RFC 16/17] iommu: Mark dev_iommu_get() with lockdep

2023-11-13 Thread Jerry Snitselaar
Reviewed-by: Jerry Snitselaar

Re: [PATCH RFC 15/17] iommu: Add ops->of_xlate_fwspec()

2023-11-13 Thread Jerry Snitselaar
Reviewed-by: Jerry Snitselaar

Re: [PATCH RFC 14/17] iommu: Remove pointless iommu_fwspec_free()

2023-11-13 Thread Jerry Snitselaar
Reviewed-by: Jerry Snitselaar

Re: [PATCH RFC 11/17] iommu: Hold iommu_probe_device_lock while calling ops->of_xlate

2023-11-13 Thread Jerry Snitselaar
Reviewed-by: Jerry Snitselaar

Re: [PATCH RFC 10/17] acpi: Do not use dev->iommu within acpi_iommu_configure()

2023-11-13 Thread Jerry Snitselaar
Reviewed-by: Jerry Snitselaar

Re: [PATCH RFC 09/17] iommu: Add iommu_fwspec_append_ids()

2023-11-13 Thread Jerry Snitselaar
Reviewed-by: Jerry Snitselaar

Re: [PATCH RFC 08/17] of: Do not use dev->iommu within of_iommu_configure()

2023-11-13 Thread Jerry Snitselaar
Reviewed-by: Jerry Snitselaar

Re: [PATCH RFC 07/17] iommu: Add iommu_probe_device_fwspec()

2023-11-13 Thread Jerry Snitselaar
Reviewed-by: Jerry Snitselaar

Re: [PATCH RFC 06/17] iommu: Add iommu_fwspec_alloc/dealloc()

2023-11-13 Thread Jerry Snitselaar
Reviewed-by: Jerry Snitselaar

Re: [PATCH RFC 05/17] iommu: Make iommu_fwspec->ids a distinct allocation

2023-11-13 Thread Jerry Snitselaar
Reviewed-by: Jerry Snitselaar

Re: [PATCH RFC 13/17] iommu: Remove dev_iommu_fwspec_set()

2023-11-13 Thread Jerry Snitselaar
Reviewed-by: Jerry Snitselaar

Re: [PATCH RFC 12/17] iommu: Make iommu_ops_from_fwnode() static

2023-11-13 Thread Jerry Snitselaar
On Fri, Nov 03, 2023 at 01:44:57PM -0300, Jason Gunthorpe wrote: ... > @@ -1044,11 +1043,6 @@ static inline int iommu_fwspec_add_ids(struct device > *dev, u32 *ids, > } > > static inline ^ was missed in the deletion below > -const struct iommu_ops *iommu_ops_from_fwnode(struct fwnode_hand

Re: [PATCH RFC 04/17] acpi: Do not return struct iommu_ops from acpi_iommu_configure_id()

2023-11-05 Thread Jerry Snitselaar
On Sun, Nov 05, 2023 at 09:24:09AM -0400, Jason Gunthorpe wrote: > On Fri, Nov 03, 2023 at 05:48:01PM -0700, Jerry Snitselaar wrote: > > > @@ -1632,10 +1633,15 @@ int acpi_dma_configure_id(struct device *dev, > > > enum dev_dma_attr attr, > > > &

Re: [PATCH RFC 04/17] acpi: Do not return struct iommu_ops from acpi_iommu_configure_id()

2023-11-03 Thread Jerry Snitselaar
On Fri, Nov 03, 2023 at 01:44:49PM -0300, Jason Gunthorpe wrote: > Nothing needs this pointer. Return a normal error code with the usual > IOMMU semantic that ENODEV means 'there is no IOMMU driver'. > > Signed-off-by: Jason Gunthorpe > --- > drivers/acpi/scan.c | 24 +++- >

Re: [PATCH RFC 03/17] of: Use -ENODEV consistently in of_iommu_configure()

2023-11-03 Thread Jerry Snitselaar
On Fri, Nov 03, 2023 at 01:44:48PM -0300, Jason Gunthorpe wrote: > Instead of returning 1 and trying to handle positive error codes just > stick to the convention of returning -ENODEV. Remove references to ops > from of_iommu_configure(), a NULL ops will already generate an error code. > > There i

Re: [PATCH RFC 02/17] of: Do not return struct iommu_ops from of_iommu_configure()

2023-11-03 Thread Jerry Snitselaar
On Fri, Nov 03, 2023 at 02:42:01PM -0700, Jerry Snitselaar wrote: > On Fri, Nov 03, 2023 at 01:44:47PM -0300, Jason Gunthorpe wrote: > > Nothing needs this pointer. Return a normal error code with the usual > > IOMMU semantic that ENODEV means 'there is no IOMMU driver'

Re: [PATCH RFC 02/17] of: Do not return struct iommu_ops from of_iommu_configure()

2023-11-03 Thread Jerry Snitselaar
On Fri, Nov 03, 2023 at 01:44:47PM -0300, Jason Gunthorpe wrote: > Nothing needs this pointer. Return a normal error code with the usual > IOMMU semantic that ENODEV means 'there is no IOMMU driver'. > > Signed-off-by: Jason Gunthorpe > --- > drivers/iommu/of_iommu.c | 29 ++-

Re: [PATCH RFC 01/17] iommu: Remove struct iommu_ops *iommu from arch_setup_dma_ops()

2023-11-03 Thread Jerry Snitselaar
Reviewed-by: Jerry Snitselaar