On Tue, Jul 30, 2024 at 1:00 AM Stefano Garzarella wrote:
>
> On Sun, Jul 28, 2024 at 11:52:54AM GMT, Amery Hung wrote:
> >On Tue, Jul 23, 2024 at 7:40 AM Stefano Garzarella
> >wrote:
> >>
> >> On Wed, Jul 10, 2024 at 09:25:45PM GMT, Amery Hu
On Tue, Jul 23, 2024 at 7:42 AM Stefano Garzarella wrote:
>
> On Wed, Jul 10, 2024 at 09:25:50PM GMT, Amery Hung wrote:
> >From: Bobby Eshleman
> >
> >This commit adds the common datagram receive functionality for virtio
> >transports. It does not add
On Mon, Jul 29, 2024 at 1:12 PM Arseniy Krasnov
wrote:
>
> Hi,
>
> > diff --git a/net/vmw_vsock/virtio_transport_common.c
> > b/net/vmw_vsock/virtio_transport_common.c
> > index a1c76836d798..46cd1807f8e3 100644
> > --- a/net/vmw_vsock/virtio_transport_common.c
> > +++ b/net/vmw_vsock/virtio_tran
On Wed, Jul 24, 2024 at 11:41 PM Arseniy Krasnov
wrote:
>
> Hi
>
> +static const struct vsock_transport *
> +vsock_connectible_lookup_transport(unsigned int cid, __u8 flags)
> ^^^ may be just 'u8' ?
> +{
> + const struct vsock_transport *
On Tue, Jul 23, 2024 at 7:43 AM Stefano Garzarella wrote:
>
> On Wed, Jul 10, 2024 at 09:25:55PM GMT, Amery Hung wrote:
> >From: Bobby Eshleman
> >
> >From: Jiang Wang
> >
> >This commit adds tests for vsock datagram.
> >
> >Signed-off-by: Bobby E
On Sun, Jul 28, 2024 at 1:40 PM Arseniy Krasnov
wrote:
>
> Hi Amery
>
> > /* Transport features flags */
> > /* Transport provides host->guest communication */
> > -#define VSOCK_TRANSPORT_F_H2G0x0001
> > +#define VSOCK_TRANSPORT_F_H2G0x0001
> > /
On Tue, Jul 23, 2024 at 7:41 AM Stefano Garzarella wrote:
>
> On Wed, Jul 10, 2024 at 09:25:46PM GMT, Amery Hung wrote:
> >From: Bobby Eshleman
> >
> >This commit adds support for bound dgram sockets to be tracked in a
> >separate bind table from connectible soc
On Tue, Jul 23, 2024 at 7:40 AM Stefano Garzarella wrote:
>
> On Wed, Jul 10, 2024 at 09:25:45PM GMT, Amery Hung wrote:
> >From: Bobby Eshleman
> >
> >This commit makes the bind table management functions in vsock usable
> >for different bind tables. Future work
On Tue, Jul 23, 2024 at 7:42 AM Stefano Garzarella wrote:
>
> On Wed, Jul 10, 2024 at 09:25:48PM GMT, Amery Hung wrote:
> >From: Bobby Eshleman
> >
> >This commit implements the common function
> >virtio_transport_dgram_enqueue for enqueueing datagrams. It does no
agreement between the transport and the socket layer that skb->data
> > always points to the beginning of the payload (and not, for example,
> > the packet header).
> >
> Like in the other patch, please use imperative in the commit message.
> >
> > Signed-off-b
On Mon, Jul 15, 2024 at 1:25 AM Arseniy Krasnov
wrote:
>
> Hi! Sorry, i was not in cc, so I'll reply in this way :)
Ope. I will copy you in the next version.
>
> +static const struct vsock_transport *
> +vsock_dgram_lookup_transport(unsigned int cid, __u8 flags)
> +{
> + const struct vsock
On Thu, Jul 11, 2024 at 4:03 PM Luigi Leonardi
wrote:
>
> Hi Bobby, Amery
>
> Thank you for working on this!
>
> > This commit implements datagram support with a new version of
> > ->dgram_allow().
>
> Commit messages should be imperative "This commit implements X" ->
> "Implements X".
> https://
From: Bobby Eshleman
From: Jiang Wang
This commit adds tests for vsock datagram.
Signed-off-by: Bobby Eshleman
Signed-off-by: Jiang Wang
Signed-off-by: Amery Hung
---
tools/testing/vsock/util.c | 177 -
tools/testing/vsock/util.h | 10 +
tools/testing/vsock/vsock_test.c
From: Bobby Eshleman
This commit implements datagram support with a new version of
->dgram_allow().
Additionally, it drops virtio_transport_dgram_allow() as an exported
symbol because it is no longer used in other transports.
Signed-off-by: Bobby Eshleman
Signed-off-by: Amery H
From: Bobby Eshleman
This commit implements datagram support for vsock loopback.
Not much more than simply toggling on "dgram_allow" and continuing to
use the common virtio functions.
Signed-off-by: Bobby Eshleman
Signed-off-by: Amery Hung
---
net/vmw_vsock/vsock_loopback.c | 7
error queue.
Signed-off-by: Bobby Eshleman
Signed-off-by: Amery Hung
---
drivers/vhost/vsock.c| 60 ++--
net/vmw_vsock/af_vsock.c | 2 +-
2 files changed, 58 insertions(+), 4 deletions(-)
diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c
From: Bobby Eshleman
This commit adds a feature bit for virtio vsock to support datagrams.
Signed-off-by: Jiang Wang
Signed-off-by: Bobby Eshleman
---
include/uapi/linux/virtio_vsock.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/uapi/linux/virtio_vsock.h
b/include/uapi/linux/
incoming packets
- virtio_transport_recv_pkt() saves the source cid and port to the
control buffer for recvmsg() to initialize sockaddr_vm structure
when using datagram
Signed-off-by: Bobby Eshleman
Signed-off-by: Amery Hung
---
net/vmw_vsock/virtio_transport_common.c | 79
From: Bobby Eshleman
This commit implements the common function
virtio_transport_dgram_enqueue for enqueueing datagrams. It does not add
usage in either vhost or virtio yet.
Signed-off-by: Bobby Eshleman
Signed-off-by: Amery Hung
---
include/linux/virtio_vsock.h| 1 +
include
From: Bobby Eshleman
This commit adds vsock_find_bound_dgram_socket() which allows transports
to find bound dgram sockets in the global dgram bind table. It is
intended to be used for "routing" incoming packets to the correct
sockets if the transport uses the global bind table.
Signed-off-by: Bo
From: Bobby Eshleman
This commit adds the datagram packet type for inclusion in virtio vsock
packet headers. It is included here as a standalone commit because
multiple future but distinct commits depend on it.
Signed-off-by: Bobby Eshleman
---
include/uapi/linux/virtio_vsock.h | 1 +
1 file c
From: Bobby Eshleman
This commit adds support for bound dgram sockets to be tracked in a
separate bind table from connectible sockets in order to avoid address
collisions. With this commit, users can simultaneously bind a dgram
socket and connectible socket to the same CID and port.
Signed-off-b
From: Bobby Eshleman
This commit makes the bind table management functions in vsock usable
for different bind tables. Future work will introduce a new table for
datagrams to avoid address collisions, and these functions will be used
there.
Signed-off-by: Bobby Eshleman
---
net/vmw_vsock/af_vso
a transport_{h2g,g2h}. Prior to H2G/G2H
coming online, the socket layer will access the VMCI transport via
"transport_dgram_fallback".
Only transports with a special datagram fallback use-case such as VMCI
need to register VSOCK_TRANSPORT_F_DGRAM_FALLBACK.
Signed-off-by: Bobby Eshleman
Si
From: Bobby Eshleman
Introduce new reusable function vsock_connectible_lookup_transport()
that performs the transport lookup logic.
No functional change intended.
Reviewed-by: Stefano Garzarella
Signed-off-by: Bobby Eshleman
---
net/vmw_vsock/af_vsock.c | 25 ++---
1 file
queue.
That is, they must use skb_pull() before enqueuing. This is an
agreement between the transport and the socket layer that skb->data
always points to the beginning of the payload (and not, for example,
the packet header).
Signed-off-by: Bobby Eshleman
Signed-off-by: Amery Hung
-
ff-by: Amery Hung
---
Changes in v6:
- allow empty transport in datagram vsock
- add empty transport checks in various paths
- transport layer now saves source cid and port to control buffer of skb
to remove the dependency of transport in recvmsg()
- fix virtio dgram_enqueue() by looking up the tran
27 matches
Mail list logo
