Re: [Patch rdma-next] RDMA/mana_ib: handle net event for pointing to the current netdev

2025-02-28 Thread Jason Gunthorpe
On Fri, Feb 28, 2025 at 02:41:59PM -0800, lon...@linuxonhyperv.com wrote: > + struct mana_ib_dev *dev = container_of(this, struct mana_ib_dev, nb); > + struct net_device *event_dev = netdev_notifier_info_to_dev(ptr); > + struct gdma_context *gc = dev->gdma_dev->gdma_context; > + str

RE: [EXTERNAL] [Patch rdma-next] RDMA/mana_ib: handle net event for pointing to the current netdev

2025-02-28 Thread Long Li
> Subject: [Patch rdma-next] RDMA/mana_ib: handle net event for > pointing to the current netdev > > From: Long Li > > When running under Hyper-V, the master device to the RDMA device is always > bonded to this RDMA device if it's present in the kernel. This is not user- > configurable. > > The

[PATCH] mm: page_frag: Fix refill handling in __page_frag_alloc_align()

2025-02-28 Thread Haiyang Zhang
In commit 8218f62c9c9b ("mm: page_frag: use initial zero offset for page_frag_alloc_align()"), the check for fragsz is moved earlier. So when the cache is used up, and if the fragsz > PAGE_SIZE, it won't try to refill, and just return NULL. I tested it with fragsz:8192, cache-size:32768. After the

Re: [PATCH v5 10/10] Drivers: hv: Introduce mshv_root module to expose /dev/mshv to VMMs

2025-02-28 Thread Nuno Das Neves
On 2/26/2025 8:59 PM, Easwar Hariharan wrote: > On 2/26/2025 3:08 PM, Nuno Das Neves wrote: >> Provide a set of IOCTLs for creating and managing child partitions when >> running as root partition on Hyper-V. The new driver is enabled via >> CONFIG_MSHV_ROOT. >> >> A brief overview of the interface:

Re: [PATCH v5 09/10] hyperv: Add definitions for root partition driver to hv headers

2025-02-28 Thread Nuno Das Neves
On 2/26/2025 3:51 PM, Stanislav Kinsburskii wrote: > On Wed, Feb 26, 2025 at 03:08:03PM -0800, Nuno Das Neves wrote: >> A few additional definitions are required for the mshv driver code >> (to follow). Introduce those here and clean up a little bit while >> at it. >> >> Signed-off-by: Nuno Das Nev

Re: [PATCH v5 08/10] x86: hyperv: Add mshv_handler irq handler and setup function

2025-02-28 Thread Nuno Das Neves
On 2/26/2025 3:43 PM, Stanislav Kinsburskii wrote: > On Wed, Feb 26, 2025 at 03:08:02PM -0800, Nuno Das Neves wrote: >> This will handle SYNIC interrupts such as intercepts, doorbells, and >> scheduling messages intended for the mshv driver. >> >> Signed-off-by: Nuno Das Neves >> Reviewed-by: Wei

RE: [Patch v2] uio_hv_generic: Set event for all channels on the device

2025-02-28 Thread Michael Kelley
From: lon...@linuxonhyperv.com Sent: Friday, February 28, 2025 2:14 PM > > Hyper-V may offer a non latency sensitive device with subchannels without > monitor bit enabled. The decision is entirely on the Hyper-V host not > configurable within guest. > > When a device has subchannels, also signa

[Patch v2] uio_hv_generic: Set event for all channels on the device

2025-02-28 Thread longli
From: Long Li Hyper-V may offer a non latency sensitive device with subchannels without monitor bit enabled. The decision is entirely on the Hyper-V host not configurable within guest. When a device has subchannels, also signal events for the subchannel if its monitor bit is disabled. Signed-of

RE: [PATCH hyperv-next] scsi: storvsc: Don't call the packet status the hypercall status

2025-02-28 Thread Michael Kelley
From: Roman Kisel Sent: Friday, February 28, 2025 2:55 PM > > On 2/28/2025 12:55 PM, Michael Kelley wrote: > > From: Roman Kisel Sent: Thursday, February 27, > > 2025 > 3:31 PM > >> > >> The log statement reports the packet status code as the hypercall > >> status code which causes confusion w

[PATCH] hv_netvsc: set device master/slave flags on bonding

2025-02-28 Thread longli
From: Long Li Currently netvsc only sets the SLAVE flag on VF netdev when it's bonded. It should also set the MASTER flag on itself and clear all those flags when the VF is unbonded. Signed-off-by: Long Li --- drivers/net/hyperv/netvsc_drv.c | 6 ++ 1 file changed, 6 insertions(+) diff --

RE: [PATCH hyperv-next] scsi: storvsc: Don't call the packet status the hypercall status

2025-02-28 Thread Michael Kelley
From: Roman Kisel Sent: Thursday, February 27, 2025 3:31 PM > > The log statement reports the packet status code as the hypercall > status code which causes confusion when debugging. > > Fix the name of the datum being logged. > > Signed-off-by: Roman Kisel > --- > drivers/scsi/storvsc_drv.c

Re: [PATCH hyperv-next] scsi: storvsc: Don't call the packet status the hypercall status

2025-02-28 Thread Roman Kisel
On 2/28/2025 12:55 PM, Michael Kelley wrote: From: Roman Kisel Sent: Thursday, February 27, 2025 3:31 PM The log statement reports the packet status code as the hypercall status code which causes confusion when debugging. Fix the name of the datum being logged. Signed-off-by: Roman Kisel

[Patch rdma-next] RDMA/mana_ib: handle net event for pointing to the current netdev

2025-02-28 Thread longli
From: Long Li When running under Hyper-V, the master device to the RDMA device is always bonded to this RDMA device if it's present in the kernel. This is not user-configurable. The master device can be unbind/bind from the kernel. During those events, the RDMA device should set to the current n

Re: [PATCH v5 01/10] hyperv: Convert Hyper-V status codes to strings

2025-02-28 Thread Roman Kisel
On 2/28/2025 12:22 PM, Easwar Hariharan wrote: On 2/28/2025 9:20 AM, Roman Kisel wrote: [...] So I'd think that the hex error codes from the hypervisor give the user exactly as much as the error symbolic names do to get the system to the desired state: nothing. I continue to disagree,

Re: [PATCH v5 01/10] hyperv: Convert Hyper-V status codes to strings

2025-02-28 Thread Roman Kisel
On 2/27/2025 3:25 PM, Easwar Hariharan wrote: On 2/27/2025 3:08 PM, Roman Kisel wrote: [...] Would be great to learn the details to understand how this function is going to improve the situation: 1. How come the hex error code was useless, what is not matching    anything in the Linux he

Re: [PATCH hyperv-next] scsi: storvsc: Don't call the packet status the hypercall status

2025-02-28 Thread Roman Kisel
On 2/28/2025 12:21 PM, Easwar Hariharan wrote: On 2/27/2025 3:31 PM, Roman Kisel wrote: The log statement reports the packet status code as the hypercall status code which causes confusion when debugging. Fix the name of the datum being logged. Signed-off-by: Roman Kisel --- drivers/scsi

Re: [PATCH hyperv-next] scsi: storvsc: Don't call the packet status the hypercall status

2025-02-28 Thread Easwar Hariharan
On 2/27/2025 3:31 PM, Roman Kisel wrote: > The log statement reports the packet status code as the hypercall > status code which causes confusion when debugging. > > Fix the name of the datum being logged. > > Signed-off-by: Roman Kisel > --- > drivers/scsi/storvsc_drv.c | 2 +- > 1 file change

RE: [PATCH] uio_hv_generic: Set event for all channels on the device

2025-02-28 Thread Long Li
> From: lon...@linuxonhyperv.com Sent: > Wednesday, February 26, 2025 4:46 PM > > > > Hyper-V may offer a non latency sensitive device with subchannels > > without monitor bit enabled. The decision is entirely on the Hyper-V > > host not configurable within guest. > > > > When a device has subchan

Re: [PATCH v5 01/10] hyperv: Convert Hyper-V status codes to strings

2025-02-28 Thread Roman Kisel
On 2/27/2025 4:15 PM, Nuno Das Neves wrote: On 2/27/2025 9:02 AM, Roman Kisel wrote: [...] I guess you're implying it's not worth adding such a function for only a few places in the code? That is a good point, and a bit of an oversight on my part while editing this series. Originally all t

Re: [PATCH v5 02/10] x86/mshyperv: Add support for extended Hyper-V features

2025-02-28 Thread Roman Kisel
On 2/27/2025 4:17 PM, Nuno Das Neves wrote: On 2/27/2025 9:59 AM, Roman Kisel wrote: On 2/26/2025 3:07 PM, Nuno Das Neves wrote: From: Stanislav Kinsburskii [...]   -    pr_info("Hyper-V: privilege flags low 0x%x, high 0x%x, hints 0x%x, misc 0x%x\n", -    ms_hyperv.features, ms_hy

Re: [PATCH v2 00/38] x86: Try to wrangle PV clocks vs. TSC

2025-02-28 Thread David Woodhouse
On Wed, 2025-02-26 at 18:18 -0800, Sean Christopherson wrote: > This... snowballed a bit. > > The bulk of the changes are in kvmclock and TSC, but pretty much every > hypervisor's guest-side code gets touched at some point.  I am reaonsably > confident in the correctness of the KVM changes.  For a