Re: [PATCH] net: mana: Fix memory leak in mana_gd_setup_irqs

2024-11-28 Thread Yury Norov
On Thu, Nov 28, 2024 at 09:49:35PM +, Michael Kelley wrote: > From: Maxim Levitsky Sent: Thursday, November 28, 2024 > 11:43 AM > > > > Commit 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores") > > added memory allocation in mana_gd_setup_irqs of 'irqs' but the code > > doesn't f

RE: [PATCH] net: mana: Fix memory leak in mana_gd_setup_irqs

2024-11-28 Thread Michael Kelley
From: Maxim Levitsky Sent: Thursday, November 28, 2024 11:43 AM > > Commit 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores") > added memory allocation in mana_gd_setup_irqs of 'irqs' but the code > doesn't free this temporary array in the success path. > > This was caught by kmemle

[PATCH] net: mana: Fix memory leak in mana_gd_setup_irqs

2024-11-28 Thread Maxim Levitsky
Commit 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores") added memory allocation in mana_gd_setup_irqs of 'irqs' but the code doesn't free this temporary array in the success path. This was caught by kmemleak. Fixes: 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores") Sign

Re: [EXTERNAL] Re: [PATCH rdma-next 1/1] RDMA/mana_ib: Set correct device into ib

2024-11-28 Thread Leon Romanovsky
On Wed, Nov 27, 2024 at 07:46:39PM +, Long Li wrote: > > > > > I think Konstantin's suggestion makes sense, how about we do this > > > > (don't need to define netdev_is_slave(dev)): > > > > > > > > --- a/drivers/infiniband/core/roce_gid_mgmt.c > > > > +++ b/drivers/infiniband/core/roce_gid_mgm