Re: [PATCH v2 3/4] hyperv: Add new Hyper-V headers in include/hyperv

2024-11-07 Thread Naman Jain
On 11/8/2024 4:02 AM, Nuno Das Neves wrote: These headers contain definitions for regular Hyper-V guests (as in hyperv-tlfs.h), as well as interfaces for more privileged guests like Dom0. These files are derived from headers exported from Hyper-V, rather than being derived from the TLFS docum

Re: [PATCH v2 2/4] hyperv: Clean up unnecessary #includes

2024-11-07 Thread Easwar Hariharan
On 11/7/2024 2:32 PM, Nuno Das Neves wrote: > Remove includes of linux/hyperv.h, mshyperv.h, and hyperv-tlfs.h where > they are not used. > > Acked-by: Wei Liu > Signed-off-by: Nuno Das Neves > --- > arch/arm64/hyperv/hv_core.c | 1 - > arch/x86/hyperv/hv_apic.c | 1 - > arch/x86/hype

Re: [PATCH v2 1/4] hyperv: Move hv_connection_id to hyperv-tlfs.h

2024-11-07 Thread Easwar Hariharan
On 11/7/2024 2:32 PM, Nuno Das Neves wrote: > This definition is in the wrong file; it is part of the TLFS doc. > > Acked-by: Wei Liu > Signed-off-by: Nuno Das Neves > --- > include/asm-generic/hyperv-tlfs.h | 9 + > include/linux/hyperv.h| 9 - > 2 files changed, 9

[PATCH v2 3/4] hyperv: Add new Hyper-V headers in include/hyperv

2024-11-07 Thread Nuno Das Neves
These headers contain definitions for regular Hyper-V guests (as in hyperv-tlfs.h), as well as interfaces for more privileged guests like Dom0. These files are derived from headers exported from Hyper-V, rather than being derived from the TLFS document. (Although, to preserve compatibility with ex

[PATCH v2 4/4] hyperv: Switch from hyperv-tlfs.h to hyperv/hvhdk.h

2024-11-07 Thread Nuno Das Neves
Switch to using hvhdk.h everywhere in the kernel. This header includes all the new Hyper-V headers in include/hyperv, which form a superset of the definitions found in hyperv-tlfs.h. This makes it easier to add new Hyper-V interfaces without being restricted to those in the TLFS doc (reflected in

[PATCH v2 2/4] hyperv: Clean up unnecessary #includes

2024-11-07 Thread Nuno Das Neves
Remove includes of linux/hyperv.h, mshyperv.h, and hyperv-tlfs.h where they are not used. Acked-by: Wei Liu Signed-off-by: Nuno Das Neves --- arch/arm64/hyperv/hv_core.c | 1 - arch/x86/hyperv/hv_apic.c | 1 - arch/x86/hyperv/hv_init.c | 1 - arch/x86/hyperv/hv_proc.c | 1

[PATCH v2 1/4] hyperv: Move hv_connection_id to hyperv-tlfs.h

2024-11-07 Thread Nuno Das Neves
This definition is in the wrong file; it is part of the TLFS doc. Acked-by: Wei Liu Signed-off-by: Nuno Das Neves --- include/asm-generic/hyperv-tlfs.h | 9 + include/linux/hyperv.h| 9 - 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/include/asm-gene

[PATCH v2 0/4] Add new headers for Hyper-V Dom0

2024-11-07 Thread Nuno Das Neves
To support Hyper-V Dom0 (aka Linux as root partition), many new definitions are required. The plan going forward is to directly import definitions from Hyper-V code without waiting for them to land in the TLFS document. This is a quicker and more maintainable way to import definitions, and is a st

Re: [PATCH v2] hv_sock: Initializing vsk->trans to NULL to prevent a dangling pointer

2024-11-07 Thread Jakub Kicinski
On Thu, 7 Nov 2024 16:41:02 -0500 Michael S. Tsirkin wrote: > On Thu, Nov 07, 2024 at 11:29:42AM -0800, Jakub Kicinski wrote: > > On Wed, 6 Nov 2024 04:36:04 -0500 Hyunwoo Kim wrote: > > > When hvs is released, there is a possibility that vsk->trans may not > > > be initialized to NULL, which cou

Re: [PATCH v2] hv_sock: Initializing vsk->trans to NULL to prevent a dangling pointer

2024-11-07 Thread Michael S. Tsirkin
On Thu, Nov 07, 2024 at 11:29:42AM -0800, Jakub Kicinski wrote: > On Wed, 6 Nov 2024 04:36:04 -0500 Hyunwoo Kim wrote: > > When hvs is released, there is a possibility that vsk->trans may not > > be initialized to NULL, which could lead to a dangling pointer. > > This issue is resolved by initializ

Re: [PATCH v2] hv_sock: Initializing vsk->trans to NULL to prevent a dangling pointer

2024-11-07 Thread Jakub Kicinski
On Wed, 6 Nov 2024 04:36:04 -0500 Hyunwoo Kim wrote: > When hvs is released, there is a possibility that vsk->trans may not > be initialized to NULL, which could lead to a dangling pointer. > This issue is resolved by initializing vsk->trans to NULL. > > Fixes: ae0078fcf0a5 ("hv_sock: implements H

RE: [PATCH] HID: hyperv: streamline driver probe to avoid devres issues

2024-11-07 Thread Vitaly Kuznetsov
Michael Kelley writes: > From: Michael Kelley Sent: Wednesday, November 6, 2024 10:36 AM >> From: Vitaly Kuznetsov Sent: Tuesday, November 5, 2024 >> 9:45 AM >> > >> > Saurabh Singh Sengar writes: >> > >> > > On Mon, Nov 04, 2024 at 05:48:24PM +0100, Vitaly Kuznetsov wrote: >> > >> It was found

RE: [PATCH] HID: hyperv: streamline driver probe to avoid devres issues

2024-11-07 Thread Vitaly Kuznetsov
Michael Kelley writes: > From: Vitaly Kuznetsov Sent: Tuesday, November 5, 2024 > 9:45 AM >> >> Saurabh Singh Sengar writes: >> >> > On Mon, Nov 04, 2024 at 05:48:24PM +0100, Vitaly Kuznetsov wrote: >> >> It was found that unloading 'hid_hyperv' module results in a devres >> >> complaint: >>