Re: [PATCH v2 2/2] Drivers: hv: vmbus: Log on missing offers

2024-11-06 Thread Naman Jain
On 11/1/2024 12:44 AM, Michael Kelley wrote: From: Naman Jain Sent: Tuesday, October 29, 2024 1:02 AM When resuming from hibernation, log any channels that were present before hibernation but now are gone. In general, the essential virtual devices configured for a VM, remain same, before a

RE: [PATCH] HID: hyperv: streamline driver probe to avoid devres issues

2024-11-06 Thread Michael Kelley
From: Michael Kelley Sent: Wednesday, November 6, 2024 10:36 AM > From: Vitaly Kuznetsov Sent: Tuesday, November 5, 2024 > 9:45 AM > > > > Saurabh Singh Sengar writes: > > > > > On Mon, Nov 04, 2024 at 05:48:24PM +0100, Vitaly Kuznetsov wrote: > > >> It was found that unloading 'hid_hyperv' modul

RE: [PATCH v2 1/2] jiffies: Define secs_to_jiffies()

2024-11-06 Thread Thomas Gleixner
On Wed, Nov 06 2024 at 22:19, David Laight wrote: > From: Thomas Gleixner >> Still the macro should be documented. > > I was wondering if it really had any purpose at all. > It just obfuscates code, doesn't even make it smaller. What is obfuscated here? secs_to_jiffies() is clearly describing wha

RE: [PATCH v2 1/2] jiffies: Define secs_to_jiffies()

2024-11-06 Thread David Laight
From: Thomas Gleixner > Sent: 29 October 2024 17:25 > > On Tue, Oct 29 2024 at 17:22, Geert Uytterhoeven wrote: > > On Tue, Oct 29, 2024 at 5:08 PM Thomas Gleixner wrote: > >> On Mon, Oct 28 2024 at 19:11, Easwar Hariharan wrote: > >> > diff --git a/include/linux/jiffies.h b/include/linux/jiffies

RE: Hyper-V HID driver failure in linux-next-20241101

2024-11-06 Thread Michael Kelley
From: Saurabh Singh Sengar Sent: Tuesday, November 5, 2024 9:15 AM > > On Sun, Nov 03, 2024 at 05:17:19AM +, Michael Kelley wrote: > > I was running the linux-next-20241101 kernel in a Hyper-V guest VM today, > > and the Hyper-V guest HID (mouse) driver is failing to probe during boot. > > I

RE: [PATCH] HID: hyperv: streamline driver probe to avoid devres issues

2024-11-06 Thread Michael Kelley
From: Vitaly Kuznetsov Sent: Tuesday, November 5, 2024 9:45 AM > > Saurabh Singh Sengar writes: > > > On Mon, Nov 04, 2024 at 05:48:24PM +0100, Vitaly Kuznetsov wrote: > >> It was found that unloading 'hid_hyperv' module results in a devres > >> complaint: > >> > >> ... > >> hv_vmbus: unregi

[PATCH v2 2/2] Drivers: hv: util: Avoid accessing a ringbuffer not initialized yet

2024-11-06 Thread mhkelley58
From: Michael Kelley If the KVP (or VSS) daemon starts before the VMBus channel's ringbuffer is fully initialized, we can hit the panic below: hv_utils: Registering HyperV Utility Driver hv_vmbus: registering driver hv_utils ... BUG: kernel NULL pointer dereference, address: CPU

[PATCH v2 1/2] Drivers: hv: util: Don't force error code to ENODEV in util_probe()

2024-11-06 Thread mhkelley58
From: Michael Kelley If the util_init function call in util_probe() returns an error code, util_probe() always return ENODEV, and the error code from the util_init function is lost. The error message output in the caller, vmbus_probe(), doesn't show the real error code. Fix this by just returnin

[PATCH v2 0/2] Drivers: hv: util: Two fixes in util_probe()

2024-11-06 Thread mhkelley58
From: Michael Kelley Patch 1 fixes util_probe() to not force the error return value to ENODEV when the util_init function fails -- just return the error code from util_init so the real error code is displayed in messages. Patch 2 fixes a more serious race condition between initialization of the

Re: [PATCH v2] hv_sock: Initializing vsk->trans to NULL to prevent a dangling pointer

2024-11-06 Thread Michael S. Tsirkin
On Wed, Nov 06, 2024 at 04:36:04AM -0500, Hyunwoo Kim wrote: > When hvs is released, there is a possibility that vsk->trans may not > be initialized to NULL, which could lead to a dangling pointer. > This issue is resolved by initializing vsk->trans to NULL. > > Fixes: ae0078fcf0a5 ("hv_sock: impl

Re: [PATCH v2] hv_sock: Initializing vsk->trans to NULL to prevent a dangling pointer

2024-11-06 Thread Stefano Garzarella
On Wed, Nov 06, 2024 at 04:36:04AM -0500, Hyunwoo Kim wrote: When hvs is released, there is a possibility that vsk->trans may not be initialized to NULL, which could lead to a dangling pointer. This issue is resolved by initializing vsk->trans to NULL. Fixes: ae0078fcf0a5 ("hv_sock: implements H

[PATCH v2] hv_sock: Initializing vsk->trans to NULL to prevent a dangling pointer

2024-11-06 Thread Hyunwoo Kim
When hvs is released, there is a possibility that vsk->trans may not be initialized to NULL, which could lead to a dangling pointer. This issue is resolved by initializing vsk->trans to NULL. Fixes: ae0078fcf0a5 ("hv_sock: implements Hyper-V transport for Virtual Sockets (AF_VSOCK)") Cc: sta...@v