RE: [PATCH] Drivers: hv: kvp/vss: Avoid accessing a ringbuffer not initialized yet

2024-10-29 Thread Michael Kelley
From: Dexuan Cui Sent: Monday, September 9, 2024 9:47 AM > > If the KVP (or VSS) daemon starts before the VMBus channel's ringbuffer is > fully initialized, we can hit the panic below: > > hv_utils: Registering HyperV Utility Driver > hv_vmbus: registering driver hv_utils > ... > BUG: kernel NUL

Re: [PATCH] net: mana: use ethtool string helpers

2024-10-29 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Tue, 22 Oct 2024 13:49:08 -0700 you wrote: > The latter is the preferred way to copy ethtool strings. > > Avoids manually incrementing the data pointer. > > Signed-off-by: Rosen Penev > --- > .../ethernet/micro

Re: [PATCH v2 1/2] jiffies: Define secs_to_jiffies()

2024-10-29 Thread Easwar Hariharan
On 10/29/2024 10:25 AM, Thomas Gleixner wrote: > On Tue, Oct 29 2024 at 17:22, Geert Uytterhoeven wrote: >> On Tue, Oct 29, 2024 at 5:08 PM Thomas Gleixner wrote: >>> On Mon, Oct 28 2024 at 19:11, Easwar Hariharan wrote: diff --git a/include/linux/jiffies.h b/include/linux/jiffies.h inde

Re: [PATCH] x86/mtrr: Rename mtrr_overwrite_state() to guest_force_mtrr_state()

2024-10-29 Thread Kirill A. Shutemov
On Tue, Oct 29, 2024 at 10:37:07AM -0700, Dave Hansen wrote: > On 10/29/24 08:13, Kirill A. Shutemov wrote: > > On Wed, Oct 16, 2024 at 01:50:48PM +0300, Kirill A. Shutemov wrote: > >> Rename the helper to better reflect its function. > >> > >> Signed-off-by: Kirill A. Shutemov > >> Suggested-by:

Re: [PATCH] x86/mtrr: Rename mtrr_overwrite_state() to guest_force_mtrr_state()

2024-10-29 Thread Dave Hansen
On 10/29/24 08:13, Kirill A. Shutemov wrote: > On Wed, Oct 16, 2024 at 01:50:48PM +0300, Kirill A. Shutemov wrote: >> Rename the helper to better reflect its function. >> >> Signed-off-by: Kirill A. Shutemov >> Suggested-by: Dave Hansen > > KVM patch is Linus' tree. > > Dave, can you take this

Re: [PATCH v2 1/2] jiffies: Define secs_to_jiffies()

2024-10-29 Thread Thomas Gleixner
On Tue, Oct 29 2024 at 17:22, Geert Uytterhoeven wrote: > On Tue, Oct 29, 2024 at 5:08 PM Thomas Gleixner wrote: >> On Mon, Oct 28 2024 at 19:11, Easwar Hariharan wrote: >> > diff --git a/include/linux/jiffies.h b/include/linux/jiffies.h >> > index 1220f0fbe5bf..e5256bb5f851 100644 >> > --- a/incl

Re: [PATCH v2 1/2] jiffies: Define secs_to_jiffies()

2024-10-29 Thread Geert Uytterhoeven
Hi Thomas, On Tue, Oct 29, 2024 at 5:08 PM Thomas Gleixner wrote: > On Mon, Oct 28 2024 at 19:11, Easwar Hariharan wrote: > > diff --git a/include/linux/jiffies.h b/include/linux/jiffies.h > > index 1220f0fbe5bf..e5256bb5f851 100644 > > --- a/include/linux/jiffies.h > > +++ b/include/linux/jiffie

Re: [PATCH v2 1/2] jiffies: Define secs_to_jiffies()

2024-10-29 Thread Thomas Gleixner
On Mon, Oct 28 2024 at 19:11, Easwar Hariharan wrote: > diff --git a/include/linux/jiffies.h b/include/linux/jiffies.h > index 1220f0fbe5bf..e5256bb5f851 100644 > --- a/include/linux/jiffies.h > +++ b/include/linux/jiffies.h > @@ -526,6 +526,8 @@ static __always_inline unsigned long > msecs_to_jif

Re: [PATCH] x86/mtrr: Rename mtrr_overwrite_state() to guest_force_mtrr_state()

2024-10-29 Thread Kirill A. Shutemov
On Wed, Oct 16, 2024 at 01:50:48PM +0300, Kirill A. Shutemov wrote: > Rename the helper to better reflect its function. > > Signed-off-by: Kirill A. Shutemov > Suggested-by: Dave Hansen KVM patch is Linus' tree. Dave, can you take this one? -- Kiryl Shutsemau / Kirill A. Shutemov

[PATCH v2 1/2] Drivers: hv: vmbus: Wait for offers during boot

2024-10-29 Thread Naman Jain
Channel offers are requested during VMBus initialization and resume from hibernation. Add support to wait for all channel offers to be delivered and processed before returning from vmbus_request_offers. This is in analogy to a PCI bus not returning from probe until it has scanned all devices on th

[PATCH v2 2/2] Drivers: hv: vmbus: Log on missing offers

2024-10-29 Thread Naman Jain
From: John Starks When resuming from hibernation, log any channels that were present before hibernation but now are gone. In general, the essential virtual devices configured for a VM, remain same, before and after the hibernation and its not very common that some offers are missing. The cleanup

[PATCH v2 0/2] Drivers: hv: vmbus: Wait for offers and log missing offers

2024-10-29 Thread Naman Jain
After VM requests for channel offers during boot or resume from hibernation, host offers the configured channels and then sends a separate message when all the essential channel offers are delivered. Wait for this message to make this offers request and receipt process synchronous. Without this, u

RE: [EXTERNAL] [PATCH] Drivers: hv: kvp/vss: Avoid accessing a ringbuffer not initialized yet

2024-10-29 Thread Saurabh Singh Sengar
> Subject: [EXTERNAL] [PATCH] Drivers: hv: kvp/vss: Avoid accessing a ringbuffer > not initialized yet > > If the KVP (or VSS) daemon starts before the VMBus channel's ringbuffer is > fully initialized, we can hit the panic below: > > hv_utils: Registering HyperV Utility Driver > hv_vmbus: regist