Re: [PATCH net-next v2] net: mana: Implement get_ringparam/set_ringparam for mana

2024-08-01 Thread Shradha Gupta
On Thu, Aug 01, 2024 at 07:16:49AM -0700, Jakub Kicinski wrote: > On Wed, 31 Jul 2024 20:49:05 -0700 Shradha Gupta wrote: > > It is a pretty standard support for network drivers to allow changing > > TX/RX queue sizes. We are working on improving customizations in MANA > > driver based on VM config

Re: [PATCH] clockevents/drivers/i8253: Do not zero timer counter in shutdown

2024-08-01 Thread David Woodhouse
On 1 August 2024 22:22:56 BST, Thomas Gleixner wrote: >On Thu, Aug 01 2024 at 21:49, David Woodhouse wrote: >> On Thu, 2024-08-01 at 22:00 +0200, Thomas Gleixner wrote: >>> > I justify my cowardice on the basis that it doesn't *matter* if a >>> > hardware implementation is still toggling the IRQ p

Re: [PATCH] clockevents/drivers/i8253: Do not zero timer counter in shutdown

2024-08-01 Thread Thomas Gleixner
On Thu, Aug 01 2024 at 21:49, David Woodhouse wrote: > On Thu, 2024-08-01 at 22:00 +0200, Thomas Gleixner wrote: >> > I justify my cowardice on the basis that it doesn't *matter* if a >> > hardware implementation is still toggling the IRQ pin; in that case >> > it's only a few irrelevant transistor

[PATCH] Drivers: hv: vmbus: Fix the misplaced function description

2024-08-01 Thread Roman Kisel
When hv_synic_disable_regs was introduced, it received the description of hv_synic_cleanup. Fix that. Fixes: dba61cda3046 ("Drivers: hv: vmbus: Break out synic enable and disable operations") Signed-off-by: Roman Kisel --- drivers/hv/hv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletion

Re: [PATCH] clockevents/drivers/i8253: Do not zero timer counter in shutdown

2024-08-01 Thread David Woodhouse
On 1 August 2024 22:07:25 BST, Thomas Gleixner wrote: >On Thu, Aug 01 2024 at 16:22, David Woodhouse wrote: >> On Thu, 2024-08-01 at 10:00 +0100, David Woodhouse wrote: >> bool __init pit_timer_init(void) >> { >> -if (!use_pit()) >> +if (!use_pit()) { >> +if (!hypervisor_is_t

Re: [PATCH] clockevents/drivers/i8253: Do not zero timer counter in shutdown

2024-08-01 Thread Thomas Gleixner
On Thu, Aug 01 2024 at 16:22, David Woodhouse wrote: > On Thu, 2024-08-01 at 10:00 +0100, David Woodhouse wrote: > bool __init pit_timer_init(void) > { > - if (!use_pit()) > + if (!use_pit()) { > + if (!hypervisor_is_type(X86_HYPER_NATIVE)) { > + /* > +

Re: [PATCH] clockevents/drivers/i8253: Do not zero timer counter in shutdown

2024-08-01 Thread David Woodhouse
On Thu, 2024-08-01 at 22:00 +0200, Thomas Gleixner wrote: > On Thu, Aug 01 2024 at 20:21, David Woodhouse wrote: > > On Thu, 2024-08-01 at 21:06 +0200, Thomas Gleixner wrote: > > > Yes. So the sequence should stop KVM from trying to inject > > > interrupts. Maybe someone fixes it to actually stop f

Re: [PATCH] clockevents/drivers/i8253: Do not zero timer counter in shutdown

2024-08-01 Thread Thomas Gleixner
On Thu, Aug 01 2024 at 20:21, David Woodhouse wrote: > On Thu, 2024-08-01 at 21:06 +0200, Thomas Gleixner wrote: >> Yes. So the sequence should stop KVM from trying to inject >> interrupts. Maybe someone fixes it to actually stop fiddling with the >> counter too :) > > I don't think we care about t

Re: [PATCH] clockevents/drivers/i8253: Do not zero timer counter in shutdown

2024-08-01 Thread David Woodhouse
On Thu, 2024-08-01 at 21:06 +0200, Thomas Gleixner wrote: > On Thu, Aug 01 2024 at 18:49, David Woodhouse wrote: > > On Thu, 2024-08-01 at 16:21 +0200, Thomas Gleixner wrote: > > > The stop sequence is wrong: > > > > > >     When there is a count in progress, writing a new LSB before the > > >    

Re: [PATCH] clockevents/drivers/i8253: Do not zero timer counter in shutdown

2024-08-01 Thread Thomas Gleixner
On Thu, Aug 01 2024 at 18:49, David Woodhouse wrote: > On Thu, 2024-08-01 at 16:21 +0200, Thomas Gleixner wrote: >> The stop sequence is wrong: >> >>     When there is a count in progress, writing a new LSB before the >>     counter has counted down to 0 and rolled over to h, WILL stop >>    

Re: [PATCH] clockevents/drivers/i8253: Do not zero timer counter in shutdown

2024-08-01 Thread Thomas Gleixner
On Thu, Aug 01 2024 at 19:25, David Woodhouse wrote: > On Thu, 2024-08-01 at 18:49 +0100, David Woodhouse wrote: >> > The stop sequence is wrong: >> > >> >     When there is a count in progress, writing a new LSB before the >> >     counter has counted down to 0 and rolled over to h, WILL stop

RE: [PATCH] clockevents/drivers/i8253: Do not zero timer counter in shutdown

2024-08-01 Thread Thomas Gleixner
On Thu, Aug 01 2024 at 16:14, Michael Kelley wrote: > From: Thomas Gleixner Sent: Thursday, August 1, 2024 > 7:21 AM > FWIW, in Hyper-V guests with the Hyper-V quirk removed, tglx's new > sequence does *not* stop the PIT. But this sequence does: > > outb_p(0x30, PIT_MODE); > outb_p(0xff, PIT_CH0)

Re: [PATCH] x86/hyperv: use helpers to read control registers in hv_snp_boot_ap()

2024-08-01 Thread Yosry Ahmed
On Thu, Aug 1, 2024 at 11:40 AM Yosry Ahmed wrote: > > Use native_read_cr*() helpers to read control registers into vmsa->cr* > instead of open-coded assembly. > > No functional change intended, unless there was a purpose to specifying > rax. > > Signed-off-by: Yosry Ahmed > --- > arch/x86/hyper

[PATCH] x86/hyperv: use helpers to read control registers in hv_snp_boot_ap()

2024-08-01 Thread Yosry Ahmed
Use native_read_cr*() helpers to read control registers into vmsa->cr* instead of open-coded assembly. No functional change intended, unless there was a purpose to specifying rax. Signed-off-by: Yosry Ahmed --- arch/x86/hyperv/ivm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) d

Re: [PATCH] clockevents/drivers/i8253: Do not zero timer counter in shutdown

2024-08-01 Thread David Woodhouse
On Thu, 2024-08-01 at 18:49 +0100, David Woodhouse wrote: > On Thu, 2024-08-01 at 16:21 +0200, Thomas Gleixner wrote: > > On Tue, Feb 07 2023 at 09:14, lirongq...@baidu.com wrote: > > > @@ -117,11 +110,6 @@ static int pit_shutdown(struct clock_event_device > > > *evt) > > >   > > > outb_p(

Re: [PATCH] clockevents/drivers/i8253: Do not zero timer counter in shutdown

2024-08-01 Thread David Woodhouse
On Thu, 2024-08-01 at 16:21 +0200, Thomas Gleixner wrote: > On Tue, Feb 07 2023 at 09:14, lirongq...@baidu.com wrote: > > @@ -117,11 +110,6 @@ static int pit_shutdown(struct clock_event_device *evt) > >   > > outb_p(0x30, PIT_MODE); > >   > > -   if (i8253_clear_counter_on_shutdown) { >

[PATCH] i8253: Disable PIT timer 0 when not in use

2024-08-01 Thread David Woodhouse
From: David Woodhouse Leaving the PIT interrupt running can cause noticeable steal time for virtual guests. The VMM generally has a timer which toggles the IRQ input to the PIC and I/O APIC, which takes CPU time away from the guest. Make sure it's turned off if it isn't going to be used. Except

RE: [PATCH] clockevents/drivers/i8253: Do not zero timer counter in shutdown

2024-08-01 Thread Michael Kelley
From: Thomas Gleixner Sent: Thursday, August 1, 2024 7:21 AM > > On Tue, Feb 07 2023 at 09:14, lirongq...@baidu.com wrote: > > @@ -117,11 +110,6 @@ static int pit_shutdown(struct clock_event_device *evt) > > > > outb_p(0x30, PIT_MODE); > > > > - if (i8253_clear_counter_on_shutdown) { > > -

Re: [PATCH] clockevents/drivers/i8253: Do not zero timer counter in shutdown

2024-08-01 Thread David Woodhouse
On Thu, 2024-08-01 at 10:00 +0100, David Woodhouse wrote: > > > > > > > > On 2023-02-08 at 01:04:19 +, "Michael Kelley (LINUX)" > > said: > > > > From: lirongq...@baidu.com  Sent: Monday, > > > > February 6, 2023 5:15 PM > > > > > > > > > > > > Zeroing the counter register in pit_shutdow

Re: [PATCH] clockevents/drivers/i8253: Do not zero timer counter in shutdown

2024-08-01 Thread Thomas Gleixner
On Tue, Feb 07 2023 at 09:14, lirongq...@baidu.com wrote: > @@ -117,11 +110,6 @@ static int pit_shutdown(struct clock_event_device *evt) > > outb_p(0x30, PIT_MODE); > > - if (i8253_clear_counter_on_shutdown) { > - outb_p(0, PIT_CH0); > - outb_p(0, PIT_CH0); > -

Re: [PATCH net-next v2] net: mana: Implement get_ringparam/set_ringparam for mana

2024-08-01 Thread Jakub Kicinski
On Wed, 31 Jul 2024 20:49:05 -0700 Shradha Gupta wrote: > It is a pretty standard support for network drivers to allow changing > TX/RX queue sizes. We are working on improving customizations in MANA > driver based on VM configurations. This patch is a part of that series. > Hope that makes things

Re: [RFC PATCH net-next v6 12/14] vsock/loopback: implement datagram support

2024-08-01 Thread Luigi Leonardi
> +static bool vsock_loopback_dgram_allow(u32 cid, u32 port) > +{ > + return true; > +} > + > static bool vsock_loopback_seqpacket_allow(u32 remote_cid); > static bool vsock_loopback_msgzerocopy_allow(void) > { > @@ -66,7 +71,7 @@ static struct virtio_transport loopback_transport = { >

RE: [PATCH] clockevents/drivers/i8253: Do not zero timer counter in shutdown

2024-08-01 Thread David Woodhouse
On 2023-02-08 at 01:04:19 +, "Michael Kelley (LINUX)" said: > From: lirongq...@baidu.com Sent: Monday, February 6, > 2023 5:15 PM > > > > Zeroing the counter register in pit_shutdown() isn't actually supposed to > > stop it from counting, will causes the PIT to start running again, > >