RE: [PATCH] tools: hv: lsvmbus: change shebang to use python3

2024-07-01 Thread Michael Kelley
From: Anthony Nandaa Sent: Monday, July 1, 2024 1:36 AM > > This patch updates the shebang in the lsvmbus tool to use python3 > instead of python. The change is necessary because Python 2 has > reached its end of life as of January 1, 2020, and is no longer > maintained[1]. Many modern systems do

Re: [PATCH] tools: hv: lsvmbus: change shebang to use python3

2024-07-01 Thread Wei Liu
On Mon, Jul 01, 2024 at 08:35:55AM +, Anthony Nandaa wrote: > This patch updates the shebang in the lsvmbus tool to use python3 > instead of python. The change is necessary because Python 2 has > reached its end of life as of January 1, 2020, and is no longer > maintained[1]. Many modern system

[PATCH v3] PCI: hv: Return zero, not garbage, when reading PCI_INTERRUPT_PIN

2024-07-01 Thread Wei Liu
The intent of the code snippet is to always return 0 for both PCI_INTERRUPT_LINE and PCI_INTERRUPT_PIN. The check misses PCI_INTERRUPT_PIN. This patch fixes that. This is discovered by this call in VFIO: pci_read_config_byte(vdev->pdev, PCI_INTERRUPT_PIN, &pin); The old code does not set *v

Re: [PATCH v2] PCI: hv: fix reading of PCI_INTERRUPT_PIN

2024-07-01 Thread Wei Liu
On Mon, Jul 01, 2024 at 12:20:53PM -0500, Bjorn Helgaas wrote: > On Mon, Jul 01, 2024 at 06:16:18AM +, Wei Liu wrote: > > On Wed, Jun 26, 2024 at 10:10:39AM -0500, Bjorn Helgaas wrote: > > > 1) Capitalize subject to match history > > > > What do you mean here? I got the "PCI: hv: ..." format f

Re: [PATCH v2] PCI: hv: fix reading of PCI_INTERRUPT_PIN

2024-07-01 Thread Bjorn Helgaas
On Mon, Jul 01, 2024 at 06:16:18AM +, Wei Liu wrote: > On Wed, Jun 26, 2024 at 10:10:39AM -0500, Bjorn Helgaas wrote: > > 1) Capitalize subject to match history > > What do you mean here? I got the "PCI: hv: ..." format from recent > commits. "PCI" is capitalized. You want to to capitalize "fi

Re: [PATCH] Drivers: hv: vmbus: Add missing check for dma_set_mask in vmbus_device_register()

2024-07-01 Thread Markus Elfring
> child_device_obj->device cannot perform DMA properly if dma_set_mask() > returns non-zero. … Another wording suggestion: Direct memory access can not be properly performed any more after a dma_set_mask() call failed. See also: https://elixir.bootlin.com/linux/v6.10-rc6/source/kernel/dma/ma

[PATCH] tools: hv: lsvmbus: change shebang to use python3

2024-07-01 Thread Anthony Nandaa
This patch updates the shebang in the lsvmbus tool to use python3 instead of python. The change is necessary because Python 2 has reached its end of life as of January 1, 2020, and is no longer maintained[1]. Many modern systems do not have python pointing to Python 2, and instead use python3. By