[PATCH v2] PCI: hv: fix reading of PCI_INTERRUPT_PIN

2024-06-21 Thread Wei Liu
The intent of the code snippet is to always return 0 for both PCI_INTERRUPT_LINE and PCI_INTERRUPT_PIN. The check misses PCI_INTERRUPT_PIN. This patch fixes that. This is discovered by this call in VFIO: pci_read_config_byte(vdev->pdev, PCI_INTERRUPT_PIN, &pin); The old code does not set *v

Re: [PATCH] PCI: hv: fix reading of PCI_INTERRUPT_LINE and PCI_INTERRUPT_PIN

2024-06-21 Thread Wei Liu
On Fri, Jun 21, 2024 at 04:03:27AM -0700, Saurabh Singh Sengar wrote: > On Fri, Jun 21, 2024 at 06:19:05AM +, Wei Liu wrote: > > On Fri, Jun 21, 2024 at 03:15:19AM +, Michael Kelley wrote: > > > From: Wei Liu Sent: Thursday, June 20, 2024 6:48 PM > > > > > > > > The intent of the code sni

Re: [PATCH] PCI: hv: fix reading of PCI_INTERRUPT_LINE and PCI_INTERRUPT_PIN

2024-06-21 Thread Wei Liu
On Fri, Jun 21, 2024 at 06:41:04PM +, Dexuan Cui wrote: > From: Jake Oshins > Sent: Friday, June 21, 2024 9:51 AM > > [...] > >On Fri, Jun 21, 2024 at 06:19:05AM +, Wei Liu wrote: > > On Fri, Jun 21, 2024 at 03:15:19AM +, Michael Kelley wrote: > > > From: Wei Liu

RE: [PATCH] PCI: hv: fix reading of PCI_INTERRUPT_LINE and PCI_INTERRUPT_PIN

2024-06-21 Thread Dexuan Cui
From: Jake Oshins Sent: Friday, June 21, 2024 9:51 AM > [...] >On Fri, Jun 21, 2024 at 06:19:05AM +, Wei Liu wrote: > On Fri, Jun 21, 2024 at 03:15:19AM +, Michael Kelley wrote: > > From: Wei Liu Sent: Thursday, June 20, 2024 > > 6:48 PM > > > > > > The intent

RE: [PATCH v2] clocksource: hyper-v: Use lapic timer in a TDX VM without paravisor

2024-06-21 Thread Michael Kelley
From: Dexuan Cui Sent: Thursday, June 20, 2024 11:16 PM > > In a TDX VM without paravisor, currently the default timer is the Hyper-V > timer, which depends on the slow VM Reference Counter MSR: the Hyper-V TSC > page is not enabled in such a VM because the VM uses Invariant TSC as a > better clo

Re: [PATCH] PCI: hv: fix reading of PCI_INTERRUPT_LINE and PCI_INTERRUPT_PIN

2024-06-21 Thread Saurabh Singh Sengar
On Fri, Jun 21, 2024 at 06:19:05AM +, Wei Liu wrote: > On Fri, Jun 21, 2024 at 03:15:19AM +, Michael Kelley wrote: > > From: Wei Liu Sent: Thursday, June 20, 2024 6:48 PM > > > > > > The intent of the code snippet is to always return 0 for both fields. > > > The check is wrong though. Fix

Re: [PATCH] Drivers: hv: Remove deprecated hv_fcopy declarations

2024-06-21 Thread Saurabh Singh Sengar
On Thu, Jun 20, 2024 at 06:50:40PM -0400, Rachel Menge wrote: > There are lingering hv_fcopy declarations which do not have definitions. > The fcopy driver was removed in commit ec314f61e4fc ("Drivers: hv: Remove > fcopy driver"). > > Therefore, remove the hv_fcopy declarations which are no longer