Re: [PATCH net-next] net: mana: Add new device attributes for mana

2024-04-17 Thread Shradha Gupta
On Tue, Apr 16, 2024 at 08:09:35PM +0200, Andrew Lunn wrote: > On Tue, Apr 16, 2024 at 06:27:04AM +0200, Zhu Yanjun wrote: > > ??? 2024/4/15 18:13, Jason Gunthorpe ??: > > > On Mon, Apr 15, 2024 at 02:49:49AM -0700, Shradha Gupta wrote: > > > > Add new device attributes to view multiport, msix,

Re: [PATCH net-next] net: mana: Add new device attributes for mana

2024-04-17 Thread Shradha Gupta
On Tue, Apr 16, 2024 at 06:27:04AM +0200, Zhu Yanjun wrote: > ??? 2024/4/15 18:13, Jason Gunthorpe ??: > >On Mon, Apr 15, 2024 at 02:49:49AM -0700, Shradha Gupta wrote: > >>Add new device attributes to view multiport, msix, and adapter MTU > >>setting for MANA device. > >> > >>Signed-off-by: Sh

RE: Early kernel panic in dmi_decode when running 32-bit kernel on Hyper-V on Windows 11

2024-04-17 Thread Michael Kelley
From: Michael Schierl Sent: Wednesday, April 17, 2024 2:08 PM > > > Don't let the type 10 distract you. It is entirely possible that the > > byte corresponding to type == 10 is already part of the corrupted > > memory area. Can you check if the DMI table generated by Hyper-V is > > supposed to co

Re: [PATCH] firmware: dmi: Stop decoding on broken entry

2024-04-17 Thread Michael Schierl
Hello, Am 17.04.2024 um 17:33 schrieb Jean Delvare: If a DMI table entry is shorter than 4 bytes, it is invalid. Due to how DMI table parsing works, it is impossible to safely recover from such an error, so we have to stop decoding the table. Signed-off-by: Jean Delvare Link: https://lore.ke

Re: Early kernel panic in dmi_decode when running 32-bit kernel on Hyper-V on Windows 11

2024-04-17 Thread Michael Schierl
Hello Jean, Thanks for your reply. Am 17.04.2024 um 11:43 schrieb Jean DELVARE: Don't let the type 10 distract you. It is entirely possible that the byte corresponding to type == 10 is already part of the corrupted memory area. Can you check if the DMI table generated by Hyper-V is supposed

RE: [PATCH] firmware: dmi: Stop decoding on broken entry

2024-04-17 Thread Michael Kelley
From: Jean Delvare Sent: Wednesday, April 17, 2024 10:34 AM > > Hi Michael, > > On Wed, 2024-04-17 at 15:43 +, Michael Kelley wrote: > > From: Jean Delvare Sent: Wednesday, April 17, 2024 8:34 > > AM > > > > > > If a DMI table entry is shorter than 4 bytes, it is invalid. Due to > > > how

Re: [PATCH] firmware: dmi: Stop decoding on broken entry

2024-04-17 Thread Jean Delvare
Hi Michael, On Wed, 2024-04-17 at 15:43 +, Michael Kelley wrote: > From: Jean Delvare Sent: Wednesday, April 17, 2024 8:34 AM > > > > If a DMI table entry is shorter than 4 bytes, it is invalid. Due to > > how DMI table parsing works, it is impossible to safely recover from > > such an error

RE: Early kernel panic in dmi_decode when running 32-bit kernel on Hyper-V on Windows 11

2024-04-17 Thread Michael Kelley
From: Jean DELVARE Sent: Wednesday, April 17, 2024 2:44 AM > > Hi Michael and Michael, > > Thanks to both of you for all the data and early analysis. > > On Tue, 2024-04-16 at 23:20 +, Michael Kelley wrote: > > Thanks for the information.  I now have a repro of "dmidecode" > > in user space

RE: [PATCH] firmware: dmi: Stop decoding on broken entry

2024-04-17 Thread Michael Kelley
From: Jean Delvare Sent: Wednesday, April 17, 2024 8:34 AM > > If a DMI table entry is shorter than 4 bytes, it is invalid. Due to > how DMI table parsing works, it is impossible to safely recover from > such an error, so we have to stop decoding the table. > > Signed-off-by: Jean Delvare > Lin

[PATCH] firmware: dmi: Stop decoding on broken entry

2024-04-17 Thread Jean Delvare
If a DMI table entry is shorter than 4 bytes, it is invalid. Due to how DMI table parsing works, it is impossible to safely recover from such an error, so we have to stop decoding the table. Signed-off-by: Jean Delvare Link: https://lore.kernel.org/linux-kernel/Zh2K3-HLXOesT_vZ@liuwe-devbox-debi

Re: Early kernel panic in dmi_decode when running 32-bit kernel on Hyper-V on Windows 11

2024-04-17 Thread Jean DELVARE
Hi Michael and Michael, Thanks to both of you for all the data and early analysis. On Tue, 2024-04-16 at 23:20 +, Michael Kelley wrote: > Thanks for the information.  I now have a repro of "dmidecode" > in user space complaining about a zero length entry, when running > in a Gen 1 VM with a 6

Re: [PATCH] tools: hv: suppress the invalid warning for packed member alignment

2024-04-17 Thread Saurabh Singh Sengar
On Wed, Apr 17, 2024 at 10:17:21AM +0200, Greg KH wrote: > On Wed, Apr 17, 2024 at 01:00:48AM -0700, Saurabh Sengar wrote: > > Packed struct vmbus_bufring is 4096 byte aligned and the reporting > > warning is for the first member of that struct which shouldn't add > > any offset to create alignment

Re: [PATCH] tools: hv: suppress the invalid warning for packed member alignment

2024-04-17 Thread Greg KH
On Wed, Apr 17, 2024 at 01:00:48AM -0700, Saurabh Sengar wrote: > Packed struct vmbus_bufring is 4096 byte aligned and the reporting > warning is for the first member of that struct which shouldn't add > any offset to create alignment issue. > > Suppress the warning by adding -Wno-address-of-packe

[PATCH] tools: hv: suppress the invalid warning for packed member alignment

2024-04-17 Thread Saurabh Sengar
Packed struct vmbus_bufring is 4096 byte aligned and the reporting warning is for the first member of that struct which shouldn't add any offset to create alignment issue. Suppress the warning by adding -Wno-address-of-packed-member flag to gcc. Reported-by: kernel test robot Closes: https://lor