Re: [EXTERNAL] Re: [PATCH] net :mana : Add per-cpu stats for MANA device

2024-04-02 Thread Shradha Gupta
Hi all, I have a newer version of this patch with netlink implementation ready, to support the usecase of per-cpu stats for RSS handling and imbalance investigations. Please let me know if we can proceed with that. Thanks and regards, Shradha. On Thu, Mar 14, 2024 at 08:01:24PM +, Alireza D

[PATCH net,v2] net: mana: Fix Rx DMA datasize and skb_over_panic

2024-04-02 Thread Haiyang Zhang
mana_get_rxbuf_cfg() aligns the RX buffer's DMA datasize to be multiple of 64. So a packet slightly bigger than mtu+14, say 1536, can be received and cause skb_over_panic. Sample dmesg: [ 5325.237162] skbuff: skb_over_panic: text:c043277a len:1536 put:1536 head:ff1100018b517000 data:ff110

RE: [PATCH net] net: mana: Fix Rx DMA datasize and skb_over_panic

2024-04-02 Thread Haiyang Zhang
> -Original Message- > From: Jakub Kicinski > Sent: Tuesday, April 2, 2024 12:13 AM > To: Dexuan Cui > Cc: Haiyang Zhang ; linux-hyperv@vger.kernel.org; > net...@vger.kernel.org; Wei Hu ; stephen > ; KY Srinivasan ; Paul > Rosswurm ; o...@aepfle.de; vkuzn...@redhat.com; > da...@davemlo

Re: [PATCH v2] Drivers: hv: Cosmetic changes for hv.c and balloon.c

2024-04-02 Thread Anirudh Rayabharam
On Mon, Apr 01, 2024 at 09:06:21PM -0700, Aditya Nagesh wrote: > Fix issues reported by checkpatch.pl script in hv.c and > balloon.c > - Remove unnecessary parentheses > - Remove extra newlines > - Remove extra spaces > - Add spaces between comparison operators > - Remove comparison with NULL

[PATCH v2 1/4] x86/hyperv/vtl: Correct parse_smp_cfg assignment

2024-04-02 Thread Saurabh Sengar
VTL platform uses DeviceTree for fetching SMP configuration, assign the correct parsing function 'x86_dtb_parse_smp_config' for it to parse_smp_cfg. Fixes: c22e19cd2c8a ("x86/hyperv/vtl: Prepare for separate mpparse callbacks") Signed-off-by: Saurabh Sengar --- arch/x86/hyperv/hv_vtl.c | 2 +- 1

[PATCH v2 3/4] x86/of: Map NUMA node to CPUs as per DeviceTree

2024-04-02 Thread Saurabh Sengar
Currently for DeviceTree bootup, x86 code does the default mapping of CPUs to NUMA, which is wrong. This can cause incorrect mapping and WARN on a SMT enabled systems like below: CPU #1's smt-sibling CPU #0 is not on the same node! [node: 1 != 0]. Ignoring dependency. WARNING: CPU: 1 PID: 0 at to

[PATCH v2 2/4] x86/of: Set the parse_smp_cfg for all the DeviceTree platforms by default

2024-04-02 Thread Saurabh Sengar
x86_dtb_parse_smp_config must be set by DeviceTree platform for parsing SMP configuration. Set the parse_smp_cfg pointer to x86_dtb_parse_smp_config by default so that all the dtb platforms need not to assign it explicitly. Today there are only two platforms using DeviceTree in x86, ce4100 and hv_v

[PATCH v2 4/4] x86/of: Change x86_dtb_parse_smp_config to static

2024-04-02 Thread Saurabh Sengar
x86_dtb_parse_smp_config is called locally only, change it to static. Signed-off-by: Saurabh Sengar --- arch/x86/include/asm/prom.h | 2 -- arch/x86/kernel/devicetree.c | 18 +- 2 files changed, 9 insertions(+), 11 deletions(-) diff --git a/arch/x86/include/asm/prom.h b/arch/x

[PATCH v2 0/4] Fixing SMP config for DeviceTree platforms

2024-04-02 Thread Saurabh Sengar
Original motivation for these changes was to fix an SMT warning observed in Hyper-V VTL platform. Check V1 for more details: https://lore.kernel.org/lkml/1710265404-23146-1-git-send-email-ssen...@linux.microsoft.com/ But on further review it was observed that x86 DeviceTree config has modified rec

Re: [PATCH 2/9] dma: Convert from tasklet to BH workqueue

2024-04-02 Thread Vinod Koul
On 02-04-24, 14:25, Linus Walleij wrote: > Hi Allen, > > thanks for your patch! > > On Wed, Mar 27, 2024 at 5:03 PM Allen Pais wrote: > > > The only generic interface to execute asynchronously in the BH context is > > tasklet; however, it's marked deprecated and has some design flaws. To > > re

Re: [PATCH 7/9] s390: Convert from tasklet to BH workqueue

2024-04-02 Thread Alexandra Winter
On 27.03.24 17:03, Allen Pais wrote: > The only generic interface to execute asynchronously in the BH context is > tasklet; however, it's marked deprecated and has some design flaws. To > replace tasklets, BH workqueue support was recently added. A BH workqueue > behaves similarly to regular wor

Re: [PATCH 2/9] dma: Convert from tasklet to BH workqueue

2024-04-02 Thread Linus Walleij
Hi Allen, thanks for your patch! On Wed, Mar 27, 2024 at 5:03 PM Allen Pais wrote: > The only generic interface to execute asynchronously in the BH context is > tasklet; however, it's marked deprecated and has some design flaws. To > replace tasklets, BH workqueue support was recently added. A

Re: [PATCH 9/9] mmc: Convert from tasklet to BH workqueue

2024-04-02 Thread Ulf Hansson
On Thu, 28 Mar 2024 at 17:21, Tejun Heo wrote: > > Hello, > > On Thu, Mar 28, 2024 at 01:53:25PM +0100, Ulf Hansson wrote: > > At this point we have suggested to drivers to switch to use threaded > > irq handlers (and regular work queues if needed too). That said, > > what's the benefit of using t