Re: [PATCH] net :mana : Add per-cpu stats for MANA device

2024-03-07 Thread Shradha Gupta
Thanks for the comments, I am sending out a newer version with these fixes. On Thu, Mar 07, 2024 at 09:01:45AM -0800, Jakub Kicinski wrote: > On Thu, 7 Mar 2024 15:49:15 + Haiyang Zhang wrote: > > > > Extend 'ethtool -S' output for mana devices to include per-CPU packet > > > > stats > > >

[PATCH v2] mshyperv: Introduce hv_get_hypervisor_version function

2024-03-07 Thread Nuno Das Neves
Introduce x86_64 and arm64 functions to get the hypervisor version information and store it in a structure for simpler parsing. Use the new function to get and parse the version at boot time. While at it, move the printing code to hv_common_init() so it is not duplicated. Signed-off-by: Nuno Das

RE: [RFC RFT PATCH 0/4] Handle set_memory_XXcrypted() errors in hyperv

2024-03-07 Thread Michael Kelley
From: Edgecombe, Rick P Sent: Thursday, March 7, 2024 11:12 AM > > On Thu, 2024-03-07 at 17:11 +, Michael Kelley wrote: > > Using your patches plus the changes in my comments, I've > > done most of the testing described above. The normal > > paths work, and when I hack set_memory_encrypted()

RE: [PATCH] mshyperv: Introduce hv_get_hypervisor_version function

2024-03-07 Thread Michael Kelley
From: Nuno Das Neves Sent: Thursday, March 7, 2024 11:49 AM > > On 3/7/2024 11:22 AM, Michael Kelley wrote: > > From: Nuno Das Neves Sent: Wednesday, > > March 6, 2024 4:48 PM > >> > >> Introduce x86_64 and arm64 functions for getting the hypervisor version > >> information and storing it in a

Re: [PATCH] mshyperv: Introduce hv_get_hypervisor_version function

2024-03-07 Thread Nuno Das Neves
On 3/7/2024 11:22 AM, Michael Kelley wrote: > From: Nuno Das Neves Sent: Wednesday, > March 6, 2024 4:48 PM >> >> Introduce x86_64 and arm64 functions for getting the hypervisor version >> information and storing it in a structure for simpler parsing. >> >> Use the new function to get and parse t

RE: [PATCH] mshyperv: Introduce hv_get_hypervisor_version function

2024-03-07 Thread Michael Kelley
From: Nuno Das Neves Sent: Wednesday, March 6, 2024 4:48 PM > > Introduce x86_64 and arm64 functions for getting the hypervisor version > information and storing it in a structure for simpler parsing. > > Use the new function to get and parse the version at boot time. While at > it, print the v

Re: [RFC RFT PATCH 0/4] Handle set_memory_XXcrypted() errors in hyperv

2024-03-07 Thread Edgecombe, Rick P
On Thu, 2024-03-07 at 17:11 +, Michael Kelley wrote: > Using your patches plus the changes in my comments, I've > done most of the testing described above. The normal > paths work, and when I hack set_memory_encrypted() > to fail, the error paths correctly did not free the memory. > I checked b

[PATCH v2 1/1] x86/hyperv: Use Hyper-V entropy to seed guest random number generator

2024-03-07 Thread mhkelley58
From: Michael Kelley A Hyper-V host provides its guest VMs with entropy in a custom ACPI table named "OEM0". The entropy bits are updated each time Hyper-V boots the VM, and are suitable for seeding the Linux guest random number generator (rng). See a brief description of OEM0 in [1]. Generatio

RE: [RFC RFT PATCH 0/4] Handle set_memory_XXcrypted() errors in hyperv

2024-03-07 Thread Michael Kelley
From: Michael Kelley Sent: Friday, March 1, 2024 11:00 AM > > > > IMPORTANT NOTE: > > I don't have a setup to test tdx hyperv changes. These changes are compile > > tested only. Previously Michael Kelley suggested some folks at MS might be > > able to help with this. > > Thanks for doing these ch

Re: [PATCH] net :mana : Add per-cpu stats for MANA device

2024-03-07 Thread Jakub Kicinski
On Thu, 7 Mar 2024 15:49:15 + Haiyang Zhang wrote: > > > Extend 'ethtool -S' output for mana devices to include per-CPU packet > > > stats > > > > But why? You already have per queue stats. > Yes. But the q to cpu binding is dynamic, we also want the per-CPU stat > to analyze the CPU usag

RE: [PATCH] net :mana : Add per-cpu stats for MANA device

2024-03-07 Thread Haiyang Zhang
> -Original Message- > From: Shradha Gupta > Sent: Thursday, March 7, 2024 9:52 AM > To: linux-ker...@vger.kernel.org; linux-hyperv@vger.kernel.org; linux- > r...@vger.kernel.org; net...@vger.kernel.org > Cc: Shradha Gupta ; Eric Dumazet > ; Jakub Kicinski ; Paolo Abeni > ; Ajay Sharma

RE: [PATCH] net :mana : Add per-cpu stats for MANA device

2024-03-07 Thread Haiyang Zhang
> -Original Message- > From: Jakub Kicinski > Sent: Thursday, March 7, 2024 10:29 AM > To: Shradha Gupta > Cc: linux-ker...@vger.kernel.org; linux-hyperv@vger.kernel.org; linux- > r...@vger.kernel.org; net...@vger.kernel.org; Eric Dumazet > ; Paolo Abeni ; Ajay Sharma > ; Leon Romanovs

Re: [PATCH] net :mana : Add per-cpu stats for MANA device

2024-03-07 Thread Jakub Kicinski
On Thu, 7 Mar 2024 06:52:12 -0800 Shradha Gupta wrote: > Extend 'ethtool -S' output for mana devices to include per-CPU packet > stats But why? You already have per queue stats. > Built-on: Ubuntu22 > Tested-on: Ubuntu22 I understand when people mention testing driver changes on particular SKUs

[PATCH] net :mana : Add per-cpu stats for MANA device

2024-03-07 Thread Shradha Gupta
Extend 'ethtool -S' output for mana devices to include per-CPU packet stats Built-on: Ubuntu22 Tested-on: Ubuntu22 Signed-off-by: Shradha Gupta --- drivers/net/ethernet/microsoft/mana/mana_en.c | 22 ++ .../ethernet/microsoft/mana/mana_ethtool.c| 40 ++- include/net/m