RE: [PATCH] Drivers: hv: vmbus: One function call less in create_gpadl_header() after error detection

2024-01-09 Thread Michael Kelley
From: Markus Elfring Sent: Tuesday, December 26, 2023 11:09 AM > > The kfree() function was called in two cases by > the create_gpadl_header() function during error handling > even if the passed variable contained a null pointer. > This issue was detected by using the Coccinelle software. > > T

RE: [PATCH] x86/hyperv: Allow 15-bit APIC IDs for VTL platforms

2024-01-09 Thread Michael Kelley
From: Saurabh Sengar Sent: Friday, January 5, 2024 2:29 AM > > The current method for signaling the compatibility of a Hyper-V host > with MSIs featuring 15-bit APIC IDs relies on a synthetic cpuid leaf. > However, for higher VTLs, this leaf is not reported, due to the absence > of an IO-APIC. >

RE: [PATCH 3/4 net-next] net: mana: add a function to spread IRQs per CPUs

2024-01-09 Thread Michael Kelley
From: Yury Norov Sent: Tuesday, January 9, 2024 3:29 PM > > Hi Michael, > > So, I'm just a guy who helped to formulate the heuristics in an > itemized form, and implement them using the existing kernel API. > I have no access to MANA machines and I ran no performance tests > myself. Agreed. :-)

Re: [PATCH 3/4 net-next] net: mana: add a function to spread IRQs per CPUs

2024-01-09 Thread Yury Norov
Hi Michael, So, I'm just a guy who helped to formulate the heuristics in an itemized form, and implement them using the existing kernel API. I have no access to MANA machines and I ran no performance tests myself. On Tue, Jan 09, 2024 at 07:22:38PM +, Michael Kelley wrote: > From: Souradeep C

RE: [PATCH 3/4 net-next] net: mana: add a function to spread IRQs per CPUs

2024-01-09 Thread Haiyang Zhang
> -Original Message- > From: Michael Kelley > Sent: Tuesday, January 9, 2024 2:23 PM > To: Souradeep Chakrabarti ; KY Srinivasan > ; Haiyang Zhang ; > wei@kernel.org; Dexuan Cui ; > da...@davemloft.net; eduma...@google.com; k...@kernel.org; > pab...@redhat.com; Long Li ; yury.no...@

RE: [PATCH 3/4 net-next] net: mana: add a function to spread IRQs per CPUs

2024-01-09 Thread Michael Kelley
From: Souradeep Chakrabarti Sent: Tuesday, January 9, 2024 2:51 AM > > From: Yury Norov > > Souradeep investigated that the driver performs faster if IRQs are > spread on CPUs with the following heuristics: > > 1. No more than one IRQ per CPU, if possible; > 2. NUMA locality is the second pri

Re: [PATCH 0/4 net-next] net: mana: Assigning IRQ affinity on HT cores

2024-01-09 Thread Paolo Abeni
On Tue, 2024-01-09 at 02:51 -0800, Souradeep Chakrabarti wrote: > This patch set introduces a new helper function irq_setup(), > to optimize IRQ distribution for MANA network devices. > The patch set makes the driver working 15% faster than > with cpumask_local_spread(). > > Souradeep Chakrabarti

[PATCH 4/4 net-next] net: mana: Assigning IRQ affinity on HT cores

2024-01-09 Thread Souradeep Chakrabarti
Existing MANA design assigns IRQ to every CPU, including sibling hyper-threads. This may cause multiple IRQs to be active simultaneously in the same core and may reduce the network performance. Improve the performance by assigning IRQ to non sibling CPUs in local NUMA node. The performance improve

[PATCH 3/4 net-next] net: mana: add a function to spread IRQs per CPUs

2024-01-09 Thread Souradeep Chakrabarti
From: Yury Norov Souradeep investigated that the driver performs faster if IRQs are spread on CPUs with the following heuristics: 1. No more than one IRQ per CPU, if possible; 2. NUMA locality is the second priority; 3. Sibling dislocality is the last priority. Let's consider this topology: No

[PATCH 2/4 net-next] cpumask: define cleanup function for cpumasks

2024-01-09 Thread Souradeep Chakrabarti
From: Yury Norov Now we can simplify code that allocates cpumasks for local needs. Signed-off-by: Yury Norov --- include/linux/cpumask.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/cpumask.h b/include/linux/cpumask.h index 228c23eb36d2..1c29947db848 100644 --- a/includ

[PATCH 1/4 net-next] cpumask: add cpumask_weight_andnot()

2024-01-09 Thread Souradeep Chakrabarti
From: Yury Norov Similarly to cpumask_weight_and(), cpumask_weight_andnot() is a handy helper that may help to avoid creating an intermediate mask just to calculate number of bits that set in a 1st given mask, and clear in 2nd one. Signed-off-by: Yury Norov Reviewed-by: Jacob Keller --- inclu

[PATCH 0/4 net-next] net: mana: Assigning IRQ affinity on HT cores

2024-01-09 Thread Souradeep Chakrabarti
This patch set introduces a new helper function irq_setup(), to optimize IRQ distribution for MANA network devices. The patch set makes the driver working 15% faster than with cpumask_local_spread(). Souradeep Chakrabarti (1): net: mana: Assigning IRQ affinity on HT cores Yury Norov (3): cpum