Re: [PATCH net-next v5 3/3] net: Convert some ethtool_sprintf() to ethtool_puts()

2023-12-07 Thread Louis Peens
On Wed, Dec 06, 2023 at 11:16:12PM +, justinst...@google.com wrote: > This patch converts some basic cases of ethtool_sprintf() to > ethtool_puts(). > > The conversions are used in cases where ethtool_sprintf() was being used > with just two arguments: > | ethtool_sprintf(&data, buffer[i

Re: [PATCH V4 net-next] net: mana: Assigning IRQ affinity on HT cores

2023-12-07 Thread Souradeep Chakrabarti
On Tue, Dec 05, 2023 at 02:52:06PM -0800, Yury Norov wrote: > On Tue, Dec 05, 2023 at 03:01:38AM -0800, Souradeep Chakrabarti wrote: > > > > diff --git a/drivers/net/ethernet/microsoft/mana/gdma_main.c > > > > b/drivers/net/ethernet/microsoft/mana/gdma_main.c > > > > index 6367de0c2c2e..2194a53cce

Re: [PATCH v1 1/3] x86/tdx: Check for TDX partitioning during early TDX init

2023-12-07 Thread Kirill A. Shutemov
On Thu, Dec 07, 2023 at 06:06:38PM +0100, Jeremi Piotrowski wrote: > > > >> This doesn't work in partitioning when TDVMCALLs go to L0: > >> TDVMCALL_MAP_GPA bypasses > >> L1 and TDX_ACCEPT_PAGE is L1 responsibility. > >> > >> If you want to see how this is currently supported take a look at > >>

Re: [PATCH v1 1/3] x86/tdx: Check for TDX partitioning during early TDX init

2023-12-07 Thread Jeremi Piotrowski
On 07/12/2023 18:21, Jeremi Piotrowski wrote: > On 07/12/2023 13:58, Huang, Kai wrote: >>> >>> That's how it currently works - all the enlightenments are in >>> hypervisor/paravisor >>> specific code in arch/x86/hyperv and drivers/hv and the vm is not marked >>> with >>> X86_FEATURE_TDX_GUEST. >>

RE: [PATCH v1 1/3] x86/tdx: Check for TDX partitioning during early TDX init

2023-12-07 Thread Reshetova, Elena
> >> The TDVMCALLs are related to the I/O path (networking/block io) into the L2 > guest, and > >> so they intentionally go straight to L0 and are never injected to L1. L1 > >> is not > >> involved in that path at all. > >> > >> Using something different than TDVMCALLs here would lead to additiona

Re: [PATCH v1 1/3] x86/tdx: Check for TDX partitioning during early TDX init

2023-12-07 Thread Jeremi Piotrowski
On 07/12/2023 13:58, Huang, Kai wrote: >> >> That's how it currently works - all the enlightenments are in >> hypervisor/paravisor >> specific code in arch/x86/hyperv and drivers/hv and the vm is not marked with >> X86_FEATURE_TDX_GUEST. > > And I believe there's a reason that the VM is not marke

Re: [PATCH v1 1/3] x86/tdx: Check for TDX partitioning during early TDX init

2023-12-07 Thread Jeremi Piotrowski
On 06/12/2023 23:54, Kirill A. Shutemov wrote: > On Wed, Dec 06, 2023 at 06:49:11PM +0100, Jeremi Piotrowski wrote: >> On 05/12/2023 11:54, Kirill A. Shutemov wrote: >>> On Mon, Dec 04, 2023 at 08:07:38PM +0100, Jeremi Piotrowski wrote: On 04/12/2023 10:17, Reshetova, Elena wrote: >> Check

Re: [PATCH net-next v5 3/3] net: Convert some ethtool_sprintf() to ethtool_puts()

2023-12-07 Thread Andrew Lunn
On Wed, Dec 06, 2023 at 11:16:12PM +, justinst...@google.com wrote: > This patch converts some basic cases of ethtool_sprintf() to > ethtool_puts(). > > The conversions are used in cases where ethtool_sprintf() was being used > with just two arguments: > | ethtool_sprintf(&data, buffer[i

Re: [PATCH net-next v5 1/3] ethtool: Implement ethtool_puts()

2023-12-07 Thread Andrew Lunn
On Wed, Dec 06, 2023 at 11:16:10PM +, justinst...@google.com wrote: > Use strscpy() to implement ethtool_puts(). > > Functionally the same as ethtool_sprintf() when it's used with two > arguments or with just "%s" format specifier. > > Signed-off-by: Justin Stitt Reviewed-by: Andrew Lunn

Re: [PATCH v1 1/3] x86/tdx: Check for TDX partitioning during early TDX init

2023-12-07 Thread Huang, Kai
> > > I think we are lacking background of this usage model and how it works. For > > instance, typically L2 is created by L1, and L1 is responsible for L2's > > device > > I/O emulation. I don't quite understand how could L0 emulate L2's device > > I/O? > > > > Can you provide more informat

Re: [PATCH V4 net-next] net: mana: Assigning IRQ affinity on HT cores

2023-12-07 Thread Souradeep Chakrabarti
On Tue, Dec 05, 2023 at 02:52:06PM -0800, Yury Norov wrote: > On Tue, Dec 05, 2023 at 03:01:38AM -0800, Souradeep Chakrabarti wrote: > > > > diff --git a/drivers/net/ethernet/microsoft/mana/gdma_main.c > > > > b/drivers/net/ethernet/microsoft/mana/gdma_main.c > > > > index 6367de0c2c2e..2194a53cce