Re: Notes on BAD_APICID, Was: [PATCH 0/3] x86/apic: Misc pruning

2023-11-04 Thread Thomas Gleixner
On Fri, Nov 03 2023 at 19:58, Andrew Cooper wrote: > On 02/11/2023 12:26 pm, Andrew Cooper wrote: > Another dodgy construct spotted while doing this work is > > #ifdef CONFIG_X86_32 >  #define BAD_APICID 0xFFu > #else >  #define BAD_APICID 0xu > #endif > > considering that both of those "bad" v

Re: [PATCH 1/3] x86/apic: Drop apic::delivery_mode

2023-11-04 Thread Thomas Gleixner
On Thu, Nov 02 2023 at 12:26, Andrew Cooper wrote: > This field is set to APIC_DELIVERY_MODE_FIXED in all cases, and is read > exactly once. Fold the constant in uv_program_mmr() and drop the field. > > Searching for the origin of the stale HyperV comment reveals commit > a31e58e129f7 ("x86/apic: