Re: [PATCH][next] net/mlx5e: Avoid a hundred -Wflex-array-member-not-at-end warnings

2025-02-05 Thread Tariq Toukan
alternative for this.  And similarly to the struct_group_tagged() change above, no struct members should be added before or after `struct mlx5e_umr_wqe_hdr hdr;` in `struct mlx5e_umr_wqe`: Thanks for your patch. The change with the struct_group_tagged() uses advanced tag, and keeps code cleaner. I pref

Re: [PATCH] net/mlx4_core: Avoid impossible mlx4_db_alloc() order value

2025-02-11 Thread Tariq Toukan
~~ Switch the argument to unsigned int, which removes the compiler needing to consider negative values. Signed-off-by: Kees Cook --- Cc: Tariq Toukan Cc: Andrew Lunn Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Yishai Hadas Cc: net...@vger.kernel.or

Re: [PATCH][next] net/mlx5e: Avoid a hundred -Wflex-array-member-not-at-end warnings

2025-02-19 Thread Tariq Toukan
On 20/02/2025 3:46, Jakub Kicinski wrote: On Wed, 19 Feb 2025 14:14:35 +0200 Tariq Toukan wrote: On 18/02/2025 23:13, Jakub Kicinski wrote: On Tue, 18 Feb 2025 17:53:14 +0200 Tariq Toukan wrote: Maybe it wasn't clear enough. We prefer the original patch, and provided the Reviewed-b

Re: [PATCH][next] net/mlx5e: Avoid a hundred -Wflex-array-member-not-at-end warnings

2025-02-18 Thread Tariq Toukan
On 18/02/2025 17:37, Andrew Lunn wrote: On Tue, Feb 18, 2025 at 11:49:14AM +0200, Tariq Toukan wrote: On 18/02/2025 10:14, Gustavo A. R. Silva wrote: Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo net-next maintainers, please pick it. I provided the Reviewed-by

Re: [PATCH][next] net/mlx5e: Avoid a hundred -Wflex-array-member-not-at-end warnings

2025-02-18 Thread Tariq Toukan
On 18/02/2025 10:14, Gustavo A. R. Silva wrote: Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo net-next maintainers, please pick it. I provided the Reviewed-by tag. Tariq.

Re: [PATCH][next] net/mlx5e: Avoid a hundred -Wflex-array-member-not-at-end warnings

2025-02-19 Thread Tariq Toukan
On 18/02/2025 23:13, Jakub Kicinski wrote: On Tue, 18 Feb 2025 17:53:14 +0200 Tariq Toukan wrote: Maybe it wasn't clear enough. We prefer the original patch, and provided the Reviewed-by tag for it. Can you explain what do you mean by "cleaner"? I like the alternative much