tialization earlier.
>
> [1]
> https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
>
> Cc: Linus Walleij
> Cc: Bartosz Golaszewski
> Cc: Andy Shevchenko
> Cc: linux-g...@vger.kernel.org
> Signed-off-by: Kees Cook
That's neat!
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
; (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
>
> As found with Coccinelle[1], add __counted_by for struct
> uniphier_pinctrl_reg_region.
>
> [1]
> https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
>
ings
> [1]
> Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html
> [2]
> Link: https://github.com/KSPP/linux/issues/90
> Cc: linux-hardening@vger.kernel.org
> Signed-off-by: Justin Stitt
Well analyzed, well patched, what can I say! Hats off.
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
> Signed-off-by: Duje Mihanović
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
27;d
rather write my own pin controller.
But it exists, so I can't say you can't use it. Not my choice.
I understand it is convenient.
It is possible to switch later, but only if you have a unique
pin controller compatible so please add that.
Yours,
Linus Walleij
On Sat, Sep 30, 2023 at 10:25 AM Duje Mihanović wrote:
> On Saturday, September 30, 2023 12:05:41 AM CEST Linus Walleij wrote:
> > But it exists, so I can't say you can't use it. Not my choice.
> > I understand it is convenient.
> >
> > It is possible to
mib->name, ETH_GSTRING_LEN);
> + ethtool_sprintf(&data, "%s", priv->mib_counters[i].name);
Not only does it harden the kernel, it also makes it way easier to read!
Way to go.
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
om dump_stack+0x18/0x1c
> r7:0042 r6:0008 r5:0008 r4:80fab118
> dump_stack from ubsan_epilogue+0x10/0x3c
> ubsan_epilogue from __ubsan_handle_out_of_bounds+0x80/0x84
> ...
>
> Reported-by: Mark Brown
> Cc: Russell King
> Cc: A
t, n_channels needs to be increased _before_ accessing the newly
> added array index. Increment it first, then use "i" for the prior index.
> Solves this warning in the coming GCC that has __counted_by support:
Makes perfect sense.
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
2
> Signed-off-by: Erick Archer
Patch applied!
Yours,
Linus Walleij
de like this.
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
-airoha.c: In function
> 'airoha_irq_handler':
> ../drivers/pinctrl/mediatek/pinctrl-airoha.c:2387:21: note: object 'status'
> of size 4
> 2387 | u32 status;
> | ^~
>
> Signed-off-by: Kees Cook
Patch applied, thanks Kees!
Yours,
Linus Walleij
On Mon, Feb 3, 2025 at 1:18 PM Andy Shevchenko
wrote:
> Use macros defined in linux/cleanup.h to automate resource lifetime
> control in the driver.
>
> Signed-off-by: Andy Shevchenko
Clearly this is more readable and less prone to accidental bugs.
Reviewed-by: Linus Walleij
On Mon, Feb 3, 2025 at 1:18 PM Andy Shevchenko
wrote:
> Make use of BIT() and GENMASK() where it makes sense.
>
> Signed-off-by: Andy Shevchenko
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
er boot, so the whole set should
be tagged with __init?
Other than that it LGTM.
Yours,
Linus Walleij
On Mon, Feb 3, 2025 at 1:18 PM Andy Shevchenko
wrote:
> Switch to use dev_err_probe() to simplify the error path and
> unify a message template.
>
> Signed-off-by: Andy Shevchenko
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
arent = &pdev->dev;
> + chip->gc.owner = THIS_MODULE;
The core already assigns THIS_MODULE so you can leave it
unassigned.
Yours,
Linus Walleij
GPIO functions using the platform device
> registered by the core MFD driver.
>
> Signed-off-by: André Draszik
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
18 matches
Mail list logo
