On Fri, Sep 15, 2023 at 12:06:21PM -0600, Gustavo A. R. Silva wrote:
>
>
> On 9/14/23 21:29, Kees Cook wrote:
> > On Mon, Sep 11, 2023 at 05:27:59PM -0600, Gustavo A. R. Silva wrote:
> > > Harden calls to struct_size() with size_add() and size_mul().
> >
> > Specifically, make sure that open-cod
s(+), 105 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky
On Sun, Sep 17, 2023 at 01:59:26PM -0600, Gustavo A. R. Silva wrote:
>
>
> On 9/18/23 04:49, Leon Romanovsky wrote:
> > On Fri, Sep 15, 2023 at 12:06:21PM -0600, Gustavo A. R. Silva wrote:
> > >
> > >
> > > On 9/14/23 21:29, Kees Cook wrote:
> &
On Sun, Sep 17, 2023 at 03:21:36PM -0600, Gustavo A. R. Silva wrote:
> If, for any reason, the open-coded arithmetic causes a wraparound,
The thing is that it doesn't.
> the protection that `struct_size()` provides against potential integer
> overflows is defeated. Fix this by hardening calls to
th `size_add()`, `size_sub()` and `size_mul()`.
>
>
Applied, thanks!
[1/1] RDMA/core: Use size_{add,sub,mul}() in calls to struct_size()
https://git.kernel.org/rdma/rdma/c/81760bedc65194
Best regards,
--
Leon Romanovsky
it
> guarantees NUL-termination on the destination buffer.
>
> [...]
Applied, thanks!
[1/1] RDMA/irdma: replace deprecated strncpy
https://git.kernel.org/rdma/rdma/c/f0cc82ca116f5b
Best regards,
--
Leon Romanovsky
__entry->src)
> | );
>
> [...]
Applied, thanks!
[1/1] IB/hfi1: replace deprecated strncpy
https://git.kernel.org/rdma/rdma/c/c2d0c5b28a77d5
Best regards,
--
Leon Romanovsky
lied, thanks!
[1/1] IB/qib: replace deprecated strncpy
https://git.kernel.org/rdma/rdma/c/cb7ab7854bc709
Best regards,
--
Leon Romanovsky
unted_by
https://git.kernel.org/rdma/rdma/c/bd8eec5bfa59b5
[6/7] IB/mthca: Annotate struct mthca_icm_table with __counted_by
https://git.kernel.org/rdma/rdma/c/2aba54a9e0ead5
[7/7] IB/hfi1: Annotate struct tid_rb_node with __counted_by
https://git.kernel.org/rdma/rdma/c/964168970cef5f
Best regards,
--
Leon Romanovsky
> their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for
> > array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> > functions).
> >
> > As found with Coccinelle[1], add __counted_by for struct mlx5_fc_bulk.
> >
> > Cc: Sa
ray indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
>
> As found with Coccinelle[1], add __counted_by for struct mlx5_flow_handle.
>
> Cc: Saeed Mahameed
> Cc: Leon Romanovsky
> Cc: "David S. Miller"
> Cc: Eric Dumazet
>
ain a couple of flexible structures:
>
> struct bundle_priv {
> /* Must be first */
> struct bundle_alloc_head alloc_head;
>
> [...]
Applied, thanks!
[1/1] RDMA/uverbs: Avoid -Wflex-array-member-not-at-end warnings
https://git.kernel.org/rdma/rdma/c/155f0
On Mon, Mar 25, 2024 at 08:57:08PM -0600, Gustavo A. R. Silva wrote:
>
>
> On 3/25/24 16:47, Jason Gunthorpe wrote:
> > On Mon, Mar 25, 2024 at 02:24:07PM -0600, Gustavo A. R. Silva wrote:
> > > -Wflex-array-member-not-at-end is coming in GCC-14, and we are getting
> > > ready to enable it global
On Mon, Apr 01, 2024 at 05:37:03PM +0200, Erick Archer wrote:
> The "struct mana_cfg_rx_steer_req_v2" uses a dynamically sized set of
> trailing elements. Specifically, it uses a "mana_handle_t" array. So,
> use the preferred way in the kernel declaring a flexible array [1].
>
> At the same time,
> @@
>
> msg = "WARNING: verify allocation on line %s" % (p1[0].line)
> coccilib.report.print_report(p1[0],msg)
>
> Link:
> https://www.kernel.org/doc/html/next/process/deprecated.html#zero-length-and-one-element-arrays
> [1]
> Link:
> https://www.kernel.org/doc/h
On Mon, Apr 08, 2024 at 06:36:57PM -0700, Jakub Kicinski wrote:
> On Mon, 8 Apr 2024 14:07:30 +0300 Leon Romanovsky wrote:
> > Jakub, do you want shared branch for this series or should I take
> > everything through RDMA tree as netdev part is small enough?
>
> Shared branch
On Tue, Apr 09, 2024 at 02:44:19PM -0700, Jakub Kicinski wrote:
> On Tue, 9 Apr 2024 18:01:40 +0100 Edward Cree wrote:
> > > Shared branch would be good. Ed has some outstanding patches
> > > to refactor the ethtool RSS API.
> >
> > For the record I am extremely unlikely to have time to get tho
enable some
> additional checks.
>
> This allocation is done in irdma_save_msix_info().
>
> [...]
Applied, thanks!
[1/1] RDMA/irdma: Annotate flexible array with __counted_by() in struct
irdma_qvlist_info
https://git.kernel.org/rdma/rdma/c/38c02d813aa321
Best regards,
--
Leon Romanovsky
On Tue, May 28, 2024 at 10:35:55PM -0700, Shradha Gupta wrote:
> Allow variable size indirection table allocation in MANA instead
> of using a constant value MANA_INDIRECT_TABLE_SIZE.
> The size is now derived from the MANA_QUERY_VPORT_CONFIG and the
> indirection table is allocated dynamically.
>
On Thu, May 30, 2024 at 08:42:55AM -0700, Jakub Kicinski wrote:
> On Thu, 30 May 2024 17:37:02 +0300 Leon Romanovsky wrote:
> > Once you are ok with this patch, let me create shared branch for it.
> > It is -rc1 and Konstantin already submitted some changes to qp.c
> > https:
On Fri, May 31, 2024 at 08:37:41AM -0700, Shradha Gupta wrote:
> Allow variable size indirection table allocation in MANA instead
> of using a constant value MANA_INDIRECT_TABLE_SIZE.
> The size is now derived from the MANA_QUERY_VPORT_CONFIG and the
> indirection table is allocated dynamically.
>
On Mon, Jun 03, 2024 at 10:36:48PM -0700, Shradha Gupta wrote:
> On Mon, Jun 03, 2024 at 11:41:22AM +0300, Leon Romanovsky wrote:
> > On Fri, May 31, 2024 at 08:37:41AM -0700, Shradha Gupta wrote:
> > > Allow variable size indirection table allocation in MANA instead
> &g
dynamically.
>
>
Applied, thanks!
[1/1] net: mana: Allow variable size indirection table
https://git.kernel.org/rdma/rdma/c/7fc45cb68696c7
Best regards,
--
Leon Romanovsky
On Mon, Jun 10, 2024 at 03:28:39AM -0700, Shradha Gupta wrote:
> Allow variable size indirection table allocation in MANA instead
> of using a constant value MANA_INDIRECT_TABLE_SIZE.
> The size is now derived from the MANA_QUERY_VPORT_CONFIG and the
> indirection table is allocated dynamically.
>
On Tue, Dec 03, 2024 at 02:36:25PM -0600, Bjorn Helgaas wrote:
> [+cc Linux hardening folks for any security/reliability concerns]
>
> On Tue, Dec 03, 2024 at 07:40:27PM +0200, Leon Romanovsky wrote:
> > On Tue, Dec 03, 2024 at 09:24:56AM -0800, Stephen Hemminger wrote:
> >
25 matches
Mail list logo
