Re: [ovs-dev] [PATCH net-next] net: Add options as a flexible array to struct ip_tunnel_info

2025-02-09 Thread Ilya Maximets
On 2/9/25 20:37, Gal Pressman wrote: > Hi Ilya, thanks for the review. > > On 09/02/2025 18:21, Ilya Maximets wrote: >> On 2/9/25 11:18, Gal Pressman via dev wrote: >>> Remove the hidden assumption that options are allocated at the end of >>> the struct, and teach the compiler about them using a f

[PATCH] wifi: ath12k: Fix uninitialized variable and remove goto

2025-02-09 Thread Ethan Carter Edwards
return 0; } static int ath12k_core_mlo_setup(struct ath12k_hw_group *ag) --- base-commit: a64dcfb451e254085a7daee5fe51bf22959d52d3 change-id: 20250209-ath12k-uninit-18560fd91c07 Best regards, -- Ethan Carter Edwards

[PATCH] ixgbe: remove self assignment

2025-02-09 Thread Ethan Carter Edwards
EAD_REG(hw, IXGBE_PF_HIDA(i)); - raw_desc[i] = raw_desc[i]; } } --- base-commit: a64dcfb451e254085a7daee5fe51bf22959d52d3 change-id: 20250209-e610-self-85eac1f0e338 Best regards, -- Ethan Carter Edwards

Re: [PATCH] ASoC: q6dsp: q6apm: change kzalloc to kcalloc

2025-02-09 Thread Markus Elfring
> We are replacing any instances of kzalloc(size * count, ...) with > kcalloc(count, size, ...) due to risk of overflow [1]. See also: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13#n94 … > +++ b/sound/soc/qcom/qdsp6/q

[PATCH net-next] net: Add options as a flexible array to struct ip_tunnel_info

2025-02-09 Thread Gal Pressman
Remove the hidden assumption that options are allocated at the end of the struct, and teach the compiler about them using a flexible array. With this, we can revert the unsafe_memcpy() call we have in tun_dst_unclone() [1], and resolve the false field-spanning write warning caused by the memcpy()

Re: [PATCH] ixgbe: remove self assignment

2025-02-09 Thread Michal Swiatkowski
patch. This change is already in progress [1] (I hope, waiting for v3). [1] https://lore.kernel.org/netdev/20250115034117.172999-1-dheeraj.linux...@gmail.com/ Thanks, Michal > > --- > base-commit: a64dcfb451e254085a7daee5fe51bf22959d52d3 > change-id: 20250209-e610-self-85eac1f0e338 > > Best regards, > -- > Ethan Carter Edwards

Re: [PATCH v2] sched/topology: change kzalloc to kcalloc

2025-02-09 Thread Markus Elfring
> We are replacing any instances of kzalloc(size * count, ...) with > kcalloc(count, size, ...) due to risk of overflow [1]. * See also: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13#n94 * How do you think about to

Re: [PATCH v3] thermal/debugfs: change kzalloc to kcalloc

2025-02-09 Thread Markus Elfring
> We are replacing any instances of kzalloc(size * count, ...) with > kcalloc(count, size, ...) due to risk of overflow [1]. * See also: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13#n94 * Would you like to improve

Re: [ovs-dev] [PATCH net-next] net: Add options as a flexible array to struct ip_tunnel_info

2025-02-09 Thread Ilya Maximets
On 2/9/25 11:18, Gal Pressman via dev wrote: > Remove the hidden assumption that options are allocated at the end of > the struct, and teach the compiler about them using a flexible array. > > With this, we can revert the unsafe_memcpy() call we have in > tun_dst_unclone() [1], and resolve the fal

Re: [ovs-dev] [PATCH net-next] net: Add options as a flexible array to struct ip_tunnel_info

2025-02-09 Thread Gal Pressman
Hi Ilya, thanks for the review. On 09/02/2025 18:21, Ilya Maximets wrote: > On 2/9/25 11:18, Gal Pressman via dev wrote: >> Remove the hidden assumption that options are allocated at the end of >> the struct, and teach the compiler about them using a flexible array. >> >> With this, we can revert