Re: [PATCH 1/2] rust: harden index manipulation using ownership

2024-09-29 Thread Trevor Gross
On Fri, Sep 13, 2024 at 5:01 PM Alice Ryhl wrote: > +//! Utilities for working with ranges of indices. > + > +/// A range of indices. > +/// > +/// This utility is useful for ensuring that no index in the range is used > more than once. > +#[derive(Debug)] > +pub struct Range { > +offset: us

Re: [PATCH] MAINTAINERS: Add security/Kconfig.hardening to hardening section

2024-09-29 Thread Nathan Chancellor
On Sun, Sep 29, 2024 at 10:20:59PM +0200, Paul Moore wrote: > On September 28, 2024 8:26:28 PM Nathan Chancellor wrote: > > When running get_maintainer.pl on security/Kconfig.hardening, only the > > security subsystem folks show up, even though they have never taken > > patches to this file: > >

Re: [PATCH] hardening: Adjust dependencies in selection of MODVERSIONS

2024-09-29 Thread Nathan Chancellor
On Sun, Sep 29, 2024 at 08:35:44AM -0700, Linus Torvalds wrote: > On Sat, 28 Sept 2024 at 11:13, Nathan Chancellor wrote: > > > > MODVERSIONS recently grew a dependency on !COMPILE_TEST so that Rust > > could be more easily tested. However, this introduces a Kconfig warning > > when building allmo

Re: [PATCH] MAINTAINERS: Add security/Kconfig.hardening to hardening section

2024-09-29 Thread Paul Moore
On September 28, 2024 8:26:28 PM Nathan Chancellor wrote: When running get_maintainer.pl on security/Kconfig.hardening, only the security subsystem folks show up, even though they have never taken patches to this file: $ scripts/get_maintainer.pl security/Kconfig.hardening Paul Moore <...> (s

Re: [PATCH] hardening: Adjust dependencies in selection of MODVERSIONS

2024-09-29 Thread Linus Torvalds
On Sat, 28 Sept 2024 at 11:13, Nathan Chancellor wrote: > > MODVERSIONS recently grew a dependency on !COMPILE_TEST so that Rust > could be more easily tested. However, this introduces a Kconfig warning > when building allmodconfig with a clang version that supports RANDSTRUCT > natively because R

[PATCH] pstore: Fix uaf when backend is unregistered

2024-09-29 Thread Li XingYang
when unload pstore_blk, we will unlink the pstore file and set pos->dentry to NULL, but simple_unlink(d_inode(root), pos->dentry) may free inode of pos->dentry and free pos by free_pstore_private, this may trigger uaf. kasan report: kernel: =

Re: [PATCH] pstore: Fix uaf when backend is unregistered

2024-09-29 Thread Li XingYang
On Sun, Sep 29, 2024 at 08:43:37PM +0800, Li XingYang wrote: I have another idea to fix this issue, which is to no longer use pstore_put_mackend_records to release dentry, but instead to add the reference count of the pstore backend driver when mounting pstore using try_rodule_get to avoid unin

Re: [PATCH] coredump: Do not lock during 'comm' reporting

2024-09-29 Thread Vegard Nossum
On 28/09/2024 23:51, Kees Cook wrote: On Sat, Sep 28, 2024 at 02:46:36PM -0700, Andrew Morton wrote: On Sat, 28 Sep 2024 14:39:45 -0700 Kees Cook wrote: On Sat, Sep 28, 2024 at 02:35:32PM -0700, Andrew Morton wrote: So why does __get_task_comm() need to take task_lock()? That was to make