Re: [next] wifi: ipw2x00: libipw: Avoid -Wflex-array-member-not-at-end warnings

2024-08-10 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > -Wflex-array-member-not-at-end was introduced in GCC-14, and we are > getting ready to enable it, globally. > > So, in order to avoid ending up with a flexible-array member in the > middle of multiple other structs, we use the `__struct_group()` > helper to create

Re: [PATCH AUTOSEL 6.10 02/16] fs: remove accidental overflow during wraparound check

2024-08-10 Thread Sasha Levin
On Mon, Jul 29, 2024 at 01:54:18PM +0200, Jan Kara wrote: On Sat 27-07-24 20:47:19, Sasha Levin wrote: From: Justin Stitt [ Upstream commit 23cc6ef6fd453b13502caae23130844e7d6ed0fe ] Sasha, this commit is only about silencing false-positive UBSAN warning. Not sure if it is really a stable ma

Re: [PATCH] lib/string_helpers: rework overflow-dependent code

2024-08-10 Thread Andy Shevchenko
On Sat, Aug 10, 2024 at 2:53 AM Justin Stitt wrote: > On Fri, Aug 09, 2024 at 02:07:57PM GMT, Andy Shevchenko wrote: > > On Fri, Aug 9, 2024 at 2:11 AM Kees Cook wrote: ... > > Okay, but the patch has an off-by-one error (which has no impact on > > the behavior as it's close to unrealistic to h

Re: [PATCH][next] wifi: ath11k: Avoid -Wflex-array-member-not-at-end warnings

2024-08-10 Thread Gustavo A. R. Silva
On 09/08/24 20:21, Jeff Johnson wrote: On 8/9/2024 9:20 AM, Gustavo A. R. Silva wrote: -Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Move the conflicting declaration to the end of the structure. Notice that `struct ieee80211_chanctx

Re: [PATCH] lib/string_helpers: rework overflow-dependent code

2024-08-10 Thread Andy Shevchenko
On Sat, Aug 10, 2024 at 6:39 PM Andy Shevchenko wrote: > On Sat, Aug 10, 2024 at 2:53 AM Justin Stitt wrote: > > On Fri, Aug 09, 2024 at 02:07:57PM GMT, Andy Shevchenko wrote: ... > > But, we could do this too: > > - while (*src && --size) { > > - if (src[0] == '\\' && src

Re: [PATCH v2][next] wifi: iwlwifi: mvm: Use __counted_by() and avoid -Wfamnae warnings

2024-08-10 Thread kernel test robot
suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Gustavo-A-R-Silva/wifi-iwlwifi-mvm-Use-__counted_by-and-avoid-Wfamnae-warnings/20240810-103759 base: https://git.kernel.org/pub

Re: [PATCH v2][next] wifi: iwlwifi: mvm: Use __counted_by() and avoid -Wfamnae warnings

2024-08-10 Thread kernel test robot
suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Gustavo-A-R-Silva/wifi-iwlwifi-mvm-Use-__counted_by-and-avoid-Wfamnae-warnings/20240810-103759 base: https://git.kernel.org/pub

Re: [PATCH][next] net/smc: Use static_assert() to check struct sizes

2024-08-10 Thread Jan Karcher
On 09/08/2024 00:07, Gustavo A. R. Silva wrote: Commit 9748dbc9f265 ("net/smc: Avoid -Wflex-array-member-not-at-end warnings") introduced tagged `struct smc_clc_v2_extension_fixed` and `struct smc_clc_smcd_v2_extension_fixed`. We want to ensure that when new members need to be added to the fle