Re: [PATCH v1 1/4] dt-bindings: vendor-prefixes: add LG Electronics, Inc. prefix

2024-02-01 Thread Krzysztof Kozlowski
On 31/01/2024 11:51, Svyatoslav Ryhel wrote: > Add missing LG Electronics, Inc. prefix used by some older devices. > > Signed-off-by: Svyatoslav Ryhel > --- NAK, same reasons as before: https://lore.kernel.org/all/9942f964-442e-e782-3926-6d7d11234...@canonical.com/ Best regards, Krzysztof

Re: [PATCH v1 1/4] dt-bindings: vendor-prefixes: add LG Electronics, Inc. prefix

2024-02-01 Thread Krzysztof Kozlowski
On 31/01/2024 17:06, Svyatoslav wrote: > > > 31 січня 2024 р. 18:02:31 GMT+02:00, Conor Dooley > написав(-ла): >> On Wed, Jan 31, 2024 at 05:30:58PM +0200, Svyatoslav wrote: >>> >>> >>> 31 січня 2024 р. 17:28:49 GMT+02:00, Conor Dooley >>> написав(-ла): On Wed, Jan 31, 2024 at 12:51:50PM

Re: [PATCH v1 2/4] dt-bindings: arm: tegra: Add LG Optimus Vu P895 and Optimus 4X P880

2024-02-01 Thread Krzysztof Kozlowski
On 31/01/2024 11:51, Svyatoslav Ryhel wrote: > From: Maxim Schwalm > > Add a compatible for the LG Optimus Vu P895 and Optimus 4X P880. > > Signed-off-by: Maxim Schwalm > --- > Documentation/devicetree/bindings/arm/tegra.yaml | 8 > 1 file changed, 8 insertions(+) > > diff --git a/Do

Re: [PATCH v1 3/4] ARM: tegra: Add device-tree for LG Optimus Vu (P895)

2024-02-01 Thread Krzysztof Kozlowski
On 31/01/2024 11:51, Svyatoslav Ryhel wrote: > Add device-tree for LG Optimus Vu P895, which is a NVIDIA > Tegra30-based smartphone, orignally running Android. > > Signed-off-by: Svyatoslav Ryhel > --- > arch/arm/boot/dts/nvidia/Makefile|1 + > arch/arm/boot/dts/nvidia/tegra30-lg

Re: [PATCH v2 2/5] overflow: Expand check_add_overflow() for pointer addition

2024-02-01 Thread Przemek Kitszel
On 1/30/24 23:06, Kees Cook wrote: The check_add_overflow() helper is mostly a wrapper around __builtin_add_overflow(), but GCC and Clang refuse to operate on pointer arguments that would normally be allowed if the addition were open-coded. For example, we have many places where pointer overflow

[PATCH v2 0/3] Tegra30: add support for LG tegra based phones

2024-02-01 Thread Svyatoslav Ryhel
Bring up Tegra 3 based LG phones Optimus 4X HD and Optimus Vu based on LG X3 board. --- Changes from v1: - switched from prefix lge to lg --- Maxim Schwalm (1): dt-bindings: arm: tegra: Add LG Optimus Vu P895 and Optimus 4X P880 Svyatoslav Ryhel (2): ARM: tegra: Add device-tree for LG Optimu

[PATCH v2 1/3] dt-bindings: arm: tegra: Add LG Optimus Vu P895 and Optimus 4X P880

2024-02-01 Thread Svyatoslav Ryhel
From: Maxim Schwalm Add a compatible for the LG Optimus Vu P895 and Optimus 4X P880. Signed-off-by: Maxim Schwalm Signed-off-by: Svyatoslav Ryhel --- Documentation/devicetree/bindings/arm/tegra.yaml | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/

[PATCH v2 3/3] ARM: tegra: Add device-tree for LG Optimus 4X HD (P880)

2024-02-01 Thread Svyatoslav Ryhel
Add device-tree for LG Optimus 4X HD P880, which is a NVIDIA Tegra30-based smartphone, orignally running Android. Signed-off-by: Svyatoslav Ryhel --- arch/arm/boot/dts/nvidia/Makefile| 1 + arch/arm/boot/dts/nvidia/tegra30-lg-p880.dts | 489 +++ 2 files changed, 490

[PATCH v2 2/3] ARM: tegra: Add device-tree for LG Optimus Vu (P895)

2024-02-01 Thread Svyatoslav Ryhel
Add device-tree for LG Optimus Vu P895, which is a NVIDIA Tegra30-based smartphone, orignally running Android. Signed-off-by: Svyatoslav Ryhel --- arch/arm/boot/dts/nvidia/Makefile|1 + arch/arm/boot/dts/nvidia/tegra30-lg-p895.dts | 496 + arch/arm/boot/dts/nvidia/tegra30-lg

Re: [PATCH v2 1/3] dt-bindings: arm: tegra: Add LG Optimus Vu P895 and Optimus 4X P880

2024-02-01 Thread Krzysztof Kozlowski
On 01/02/2024 10:20, Svyatoslav Ryhel wrote: > From: Maxim Schwalm > > Add a compatible for the LG Optimus Vu P895 and Optimus 4X P880. > > Signed-off-by: Maxim Schwalm > Signed-off-by: Svyatoslav Ryhel > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 3/3] ARM: tegra: Add device-tree for LG Optimus 4X HD (P880)

2024-02-01 Thread Krzysztof Kozlowski
On 01/02/2024 10:20, Svyatoslav Ryhel wrote: > + pinmux@7868 { > + pinctrl-names = "default"; > + pinctrl-0 = <&state_default>; > + > + state_default: pinmux { > + /* WLAN SDIO pinmux */ > + host_wlan_wake { Not mu

Re: [PATCH v2 3/3] ARM: tegra: Add device-tree for LG Optimus 4X HD (P880)

2024-02-01 Thread Svyatoslav Ryhel
чт, 1 лют. 2024 р. о 11:22 Krzysztof Kozlowski пише: > > On 01/02/2024 10:20, Svyatoslav Ryhel wrote: > > + pinmux@7868 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&state_default>; > > + > > + state_default: pinmux { > > + /

Re: [PATCH] wifi: brcmfmac: Adjust n_channels usage for __counted_by

2024-02-01 Thread Kalle Valo
Kees Cook wrote: > After commit e3eac9f32ec0 ("wifi: cfg80211: Annotate struct > cfg80211_scan_request with __counted_by"), the compiler may enforce > dynamic array indexing of req->channels to stay below n_channels. As a > result, n_channels needs to be increased _before_ accessing the newly > a

Re: [PATCH v2 3/3] ARM: tegra: Add device-tree for LG Optimus 4X HD (P880)

2024-02-01 Thread Krzysztof Kozlowski
On 01/02/2024 10:51, Svyatoslav Ryhel wrote: > чт, 1 лют. 2024 р. о 11:22 Krzysztof Kozlowski > пише: >> >> On 01/02/2024 10:20, Svyatoslav Ryhel wrote: >>> + pinmux@7868 { >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&state_default>; >>> + >>> +

Re: [PATCH v3 1/1] lib/vsprintf: Implement spprintf() to catch truncated strings

2024-02-01 Thread Andy Shevchenko
On Tue, Jan 30, 2024 at 04:09:53PM +, Lee Jones wrote: > There is an ongoing effort to replace the use of {v}snprintf() variants > with safer alternatives - for a more in depth view, see Jon's write-up > on LWN [0] and/or Alex's on the Kernel Self Protection Project [1]. > > Whist executing th

Re: [PATCH v3 1/1] lib/vsprintf: Implement spprintf() to catch truncated strings

2024-02-01 Thread Lee Jones
On Thu, 01 Feb 2024, Andy Shevchenko wrote: > On Tue, Jan 30, 2024 at 04:09:53PM +, Lee Jones wrote: > > There is an ongoing effort to replace the use of {v}snprintf() variants > > with safer alternatives - for a more in depth view, see Jon's write-up > > on LWN [0] and/or Alex's on the Kernel

Re: [PATCH v3 1/1] lib/vsprintf: Implement spprintf() to catch truncated strings

2024-02-01 Thread Andy Shevchenko
On Thu, Feb 01, 2024 at 12:30:04PM +, Lee Jones wrote: > On Thu, 01 Feb 2024, Andy Shevchenko wrote: > > On Tue, Jan 30, 2024 at 04:09:53PM +, Lee Jones wrote: ... > > > [0] https://lwn.net/Articles/69419/ > > > [1] https://github.com/KSPP/linux/issues/105 > > > > Link: ... [0] > > Link:

Re: [PATCH v6 0/2] shrink lib/string.i via IWYU

2024-02-01 Thread Kees Cook
On Tue, 26 Dec 2023 17:59:59 +, Tanzir Hasan wrote: > This patch series changes the include list of string.c to minimize > the preprocessing size. The patch series intends to remove REPEAT_BYE > from kernel.h and move it into its own header file because > word-at-a-time.h has an implicit depend

Re: [PATCH 0/2] Enable PSTORE_RAM as a module in the arm64 defconfig

2024-02-01 Thread Kees Cook
On Wed, 10 Jan 2024 18:05:01 -0300, Nícolas F. R. A. Prado wrote: > This series enables the PSTORE_RAM config, aka the ramoops driver, in > the defconfig. > > > Nícolas F. R. A. Prado (2): > pstore/ram: Register to module device table > arm64: defconfig: Enable PSTORE_RAM > > [...] Applied

Re: [PATCH] cap_syslog: remove CAP_SYS_ADMIN when dmesg_restrict

2024-02-01 Thread Kees Cook
On Fri, 05 Jan 2024 14:20:07 +0800, Jingzi Meng wrote: > CAP_SYSLOG was separated from CAP_SYS_ADMIN and introduced in Linux > 2.6.37 (2010-11). For a long time, certain syslog actions required > CAP_SYS_ADMIN or CAP_SYSLOG. Maybe it’s time to officially remove > CAP_SYS_ADMIN for more fine-grained

Re: [PATCH v2 1/2] VMCI: Use struct_size() in kmalloc()

2024-02-01 Thread Kees Cook
On Fri, 05 Jan 2024 08:39:59 -0800, Harshit Mogalapalli wrote: > Use struct_size() instead of open coding. > > Applied to for-next/hardening, thanks! [1/2] VMCI: Use struct_size() in kmalloc() https://git.kernel.org/kees/c/e03d4910e6e4 [2/2] VMCI: Fix memcpy() run-time warning in dg_dispa

Re: [PATCH] pstore/zone: Add a null pointer check to the psz_kmsg_read

2024-02-01 Thread Kees Cook
On Thu, 18 Jan 2024 18:02:06 +0800, Kunwu Chan wrote: > kasprintf() returns a pointer to dynamically allocated memory > which can be NULL upon failure. Ensure the allocation was successful > by checking the pointer validity. > > Applied to for-next/pstore, thanks! [1/1] pstore/zone: Add a null

Re: [PATCH] pstore/ram_core: Improve exception handling in persistent_ram_new()

2024-02-01 Thread Kees Cook
On Thu, Jan 18, 2024 at 03:06:53PM +0100, Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 18 Jan 2024 14:57:21 +0100 > > * Omit an initialisation (for the variable “ret”) > which became unnecessary with this refactoring > because a memory allocation failure will be directly indicate

[PATCH v5] iio: sx9324: avoid copying property strings

2024-02-01 Thread Justin Stitt
We're doing some needless string copies when trying to assign the proper `prop` string. We can make `prop` a const char* and simply assign to string literals. For the case where a format string is used, let's extract the parsing logic out into sx9324_parse_phase_prop(). We no longer need to create

RE: [RFC] string: Allow 2-argument strscpy()

2024-02-01 Thread David Laight
From: Kees Cook > Sent: 29 January 2024 20:29 > > Using sizeof(dst) is the overwhelmingly common case for strscpy(). > Instead of requiring this everywhere, allow a 2-argument version to be > used that will use the sizeof() internally. You may want to (try to) add a check that the first argument

Re: [PATCH v1 1/4] dt-bindings: vendor-prefixes: add LG Electronics, Inc. prefix

2024-02-01 Thread Rob Herring
On Thu, Feb 01, 2024 at 09:48:28AM +0100, Krzysztof Kozlowski wrote: > On 31/01/2024 17:06, Svyatoslav wrote: > > > > > > 31 січня 2024 р. 18:02:31 GMT+02:00, Conor Dooley > > написав(-ла): > >> On Wed, Jan 31, 2024 at 05:30:58PM +0200, Svyatoslav wrote: > >>> > >>> > >>> 31 січня 2024 р. 17:28

Re: [GIT PULL] Enable -Wstringop-overflow globally

2024-02-01 Thread Arnd Bergmann
On Fri, Jan 26, 2024, at 22:22, Linus Torvalds wrote: > On Mon, 22 Jan 2024 at 07:29, Gustavo A. R. Silva > wrote: >> >> Enable -Wstringop-overflow globally > > I suspect I'll have to revert this. > > On arm64, I get a "writing 16 bytes into a region of size 0" in the Xe driver > >drivers/gpu