Re: [PATCH v1 2/8] dt-bindings: tpm: Add schema for TIS I2C devices

2023-12-13 Thread Rob Herring
On Tue, Dec 12, 2023 at 10:39:58AM -0600, Ninad Palsule wrote: > From: Johannes Holland > > Add a dt schema to support device tree bindings for the generic I2C > physical layer. Refer to the TCG PC Client Platform TPM Profile (PTP) > Specification for TPM 2.0 v1.04 Revision 14. > > This includes

Re: [PATCH v2 0/2] qnx4: Avoid confusing compiler about buffer lengths

2023-12-13 Thread Anders Larsen
Hi Kees, On 2023-12-12 22:19 Kees Cook wrote: > On Thu, 30 Nov 2023 12:51:17 -0800, Kees Cook wrote: > > This attempts to fix the issue Ronald Monthero found[1]. Avoids using a > > too-short struct buffer when reading the string, by using the existing > > struct union. > > > > -Kees > > > > [1]

Re: [PATCH v1 1/8] dt-bindings: arm: aspeed: add IBM system1-bmc

2023-12-13 Thread Jarkko Sakkinen
On Tue Dec 12, 2023 at 6:39 PM EET, Ninad Palsule wrote: > Document the new compatibles used on IBM system1-bmc > > Tested: this not very useful line :-) (nit) > This board is tested using the simics simulator. Just leave this (w/o indentation) > > Signed-off-by: Ninad Palsule > --- > Doc

Re: [PATCH v1 2/8] dt-bindings: tpm: Add schema for TIS I2C devices

2023-12-13 Thread Jarkko Sakkinen
On Tue Dec 12, 2023 at 6:39 PM EET, Ninad Palsule wrote: > From: Johannes Holland > > Add a dt schema to support device tree bindings for the generic I2C > physical layer. Refer to the TCG PC Client Platform TPM Profile (PTP) > Specification for TPM 2.0 v1.04 Revision 14. > > This includes descrip

Re: [PATCH v1 1/8] dt-bindings: arm: aspeed: add IBM system1-bmc

2023-12-13 Thread Ninad Palsule
Hello Jarkko, On 12/13/23 12:18, Jarkko Sakkinen wrote: On Tue Dec 12, 2023 at 6:39 PM EET, Ninad Palsule wrote: Document the new compatibles used on IBM system1-bmc Tested: this not very useful line :-) (nit) This board is tested using the simics simulator. Just leave this (w/o inden

Re: [PATCH v1 2/8] dt-bindings: tpm: Add schema for TIS I2C devices

2023-12-13 Thread Ninad Palsule
Hello Jarkko, On 12/13/23 12:20, Jarkko Sakkinen wrote: On Tue Dec 12, 2023 at 6:39 PM EET, Ninad Palsule wrote: From: Johannes Holland Add a dt schema to support device tree bindings for the generic I2C physical layer. Refer to the TCG PC Client Platform TPM Profile (PTP) Specification for T

Re: [PATCH v1 8/8] ARM: dts: aspeed: System1: PS, sensor and more

2023-12-13 Thread Ninad Palsule
Hello Krzysztof, On 12/12/23 14:26, Krzysztof Kozlowski wrote: On 12/12/2023 17:40, Ninad Palsule wrote: This drop adds following devices in the device tree. - EEPROM/VPD - Power supplies - Humidity, pressure and temperature sensors. - Trusted platform module(TPM) chip Tested: This board

Re: [PATCH v2 0/2] qnx4: Avoid confusing compiler about buffer lengths

2023-12-13 Thread Kees Cook
On Wed, Dec 13, 2023 at 05:43:08PM +0100, Anders Larsen wrote: > Hi Kees, > > On 2023-12-12 22:19 Kees Cook wrote: > > On Thu, 30 Nov 2023 12:51:17 -0800, Kees Cook wrote: > > > This attempts to fix the issue Ronald Monthero found[1]. Avoids using a > > > too-short struct buffer when reading the s

Re: [PATCH v2 00/18] sysctl: constify sysctl ctl_tables

2023-12-13 Thread Eric W. Biederman
Luis Chamberlain writes: > On Mon, Dec 11, 2023 at 12:25:10PM +0100, Thomas Weißschuh wrote: >> Before sending it I'd like to get feedback on the internal rework of the >> is_empty detection from you and/or Luis. >> >> https://git.sr.ht/~t-8ch/linux/commit/ea27507070f3c47be6febebe451bbb88f6ea707

Re: [PATCH v1 8/8] ARM: dts: aspeed: System1: PS, sensor and more

2023-12-13 Thread Krzysztof Kozlowski
On 13/12/2023 20:02, Ninad Palsule wrote: > Hello Krzysztof, > > On 12/12/23 14:26, Krzysztof Kozlowski wrote: >> On 12/12/2023 17:40, Ninad Palsule wrote: >>> This drop adds following devices in the device tree. >>> - EEPROM/VPD >>> - Power supplies >>> - Humidity, pressure and temperature sensor

Re: [PATCH v1 8/8] ARM: dts: aspeed: System1: PS, sensor and more

2023-12-13 Thread Ninad Palsule
Hello Krzysztof, On 12/13/23 13:37, Krzysztof Kozlowski wrote: On 13/12/2023 20:02, Ninad Palsule wrote: Hello Krzysztof, On 12/12/23 14:26, Krzysztof Kozlowski wrote: On 12/12/2023 17:40, Ninad Palsule wrote: This drop adds following devices in the device tree. - EEPROM/VPD - Power supplies

Re: [PATCH v3] iio: sx9324: avoid copying property strings

2023-12-13 Thread Stephen Boyd
Quoting Justin Stitt (2023-12-11 16:42:52) > diff --git a/drivers/iio/proximity/sx9324.c b/drivers/iio/proximity/sx9324.c > index 438f9c9aba6e..e3bc30b57b19 100644 > --- a/drivers/iio/proximity/sx9324.c > +++ b/drivers/iio/proximity/sx9324.c > @@ -873,6 +873,32 @@ static int sx9324_init_compensatio

Re: [PATCH] cxgb3: Avoid potential string truncation in desc

2023-12-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Tue, 12 Dec 2023 14:09:57 -0800 you wrote: > Builds with W=1 were warning about potential string truncations: > > drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c: In function 'cxgb_up': > drivers/net/ethernet/chel

Re: [PATCH] amd-xgbe: Avoid potential string truncation in name

2023-12-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Tue, 12 Dec 2023 14:13:12 -0800 you wrote: > Build with W=1 were warning about a potential string truncation: > > drivers/net/ethernet/amd/xgbe/xgbe-drv.c: In function 'xgbe_alloc_channels': > drivers/net/ethernet

Re: [PATCH v2] scsi: fcoe: use sysfs_match_string over fcoe_parse_mode

2023-12-13 Thread Martin K. Petersen
Justin, > Instead of copying @buf into a new buffer and carefully managing its > newline/null-terminating status, we can just use sysfs_match_string() > as it uses sysfs_streq() internally which handles newline/null-term: Applied to 6.8/scsi-staging, thanks! -- Martin K. Petersen Oracle

Re: [PATCH] scsi: ibmvscsi: replace deprecated strncpy with strscpy

2023-12-13 Thread Martin K. Petersen
On Mon, 30 Oct 2023 20:40:48 +, Justin Stitt wrote: > strncpy() is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous string > interfaces. > > We expect partition_name to be NUL-terminated based on its usage with > format

Re: [PATCH] scsi: ibmvfc: replace deprecated strncpy with strscpy

2023-12-13 Thread Martin K. Petersen
On Mon, 30 Oct 2023 19:04:33 +, Justin Stitt wrote: > strncpy() is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous string > interfaces. > > We expect these fields to be NUL-terminated as the property names from > which

Re: [PATCH v2] scsi: zfcp: Replace strlcpy() with strscpy()

2023-12-13 Thread Martin K. Petersen
On Thu, 30 Nov 2023 12:41:00 -0800, Kees Cook wrote: > strlcpy() reads the entire source buffer first. This read may exceed > the destination size limit. This is both inefficient and can lead > to linear read overflows if a source string is not NUL-terminated[1]. > Additionally, it returns the siz

Re: [PATCH v1 8/8] ARM: dts: aspeed: System1: PS, sensor and more

2023-12-13 Thread Krzysztof Kozlowski
On 13/12/2023 20:49, Ninad Palsule wrote: > Hello Krzysztof, > > On 12/13/23 13:37, Krzysztof Kozlowski wrote: >> On 13/12/2023 20:02, Ninad Palsule wrote: >>> Hello Krzysztof, >>> >>> On 12/12/23 14:26, Krzysztof Kozlowski wrote: On 12/12/2023 17:40, Ninad Palsule wrote: > This drop adds