On 23/10/2023 08:50, Luka Panio wrote:
>> Did you base your work on these files? This would explain the license,
>> but then please include original copyrights.
> No, but the sm8250.dtsi that I do include has that license. Same as
> all other sm8250 device's dts's so i thought mine should not be
>
Initial support for Xiaomi Pad 6 tablet, that have sm8250 soc.
Signed-off-by: Luka Panio
---
v2:
Update commit message. Drop reserved gpio's as this device in reality do not
have gpio, and pins are not protected.
v3:
Update commit message.
v4:
Update commit message.
v5:
Update commit message.
Initial support for Xiaomi Pad 6 tablet, that have sm8250 soc.
Signed-off-by: Luka Panio
---
v2:
Update commit message. Drop reserved gpio's as this device in reality do not
have gpio, and pins are not protected.
v3:
Update commit message.
v4:
Update commit message.
v5:
Update commit message.
Add a compatible for Xiaomi Pad 6.
Acked-by: Conor Dooley
Signed-off-by: Luka Panio
---
v2:
Update commit message
v3:
Update commit message
v4:
Update commit message
v5:
Update commit message
v6:
Update commit message
---
Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
1 file change
The v7 patch was sent outside of the patchset and to be ignored, sorry for that.
Thanks,
Luka Panio
Hi!
> > Initial support for Xiaomi Pad 6 tablet, that have sm8250 soc.
> >
> > Signed-off-by: Luka Panio
> > +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-pipa.dts
> > @@ -0,0 +1,625 @@
> > +// SPDX-License-Identifier: BSD-3-Clause
>
> If there are no other copyrights here, why did you use BSD-
Add a compatible for Xiaomi Pad 6.
Acked-by: Conor Dooley
Signed-off-by: Luka Panio
---
v2:
Update commit message
v3:
Update commit message
v4:
Update commit message
v5:
Update commit message
v6:
Update commit message
---
Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
1 file change
Initial support for Xiaomi Pad 6 tablet, that have sm8250 soc.
Signed-off-by: Luka Panio
---
v2:
Update commit message. Drop reserved gpio's as this device in reality do not
have gpio, and pins are not protected.
v3:
Update commit message.
v4:
Update commit message.
v5:
Update commit message.
On 23/10/2023 11:02, Luka Panio wrote:
> Initial support for Xiaomi Pad 6 tablet, that have sm8250 soc.
>
> Signed-off-by: Luka Panio
> ---
> v2:
> Update commit message. Drop reserved gpio's as this device in reality do not
> have gpio, and pins are not protected.
>
> v3:
> Update commit messa
When connecting USB to PC, there is a very low probability of kernel
crash. The reason is that in ep0_txstate(), the buf member of struct
usb_request used may be a null pointer. Therefore, it needs to
determine whether it is null before using it.
[ 4888.071462][T597@C0] Call trace:
[ 4888.071467][
>Slow down with these resends. You are spamming us way too much. One
>version of your patchset per day. Max.
Ok, sorry.
>I don't understand why decided to ignore my advice.
I thought it was your suggestion to switch to GPL-2.0-only?
or you wanted to say that it should be "GPL-2.0-only OR BSD-2-Cla
Ok sorry just didn't got it right. will send a new patchset tomorrow.
Thanks,
Luka Panio
Can we get this merged please, or at least instructions for what needs to
happen to get it merged?
Thanks.
-Original Message-
From: Jeshua Smith
Sent: Monday, October 2, 2023 10:10 AM
To: Luck, Tony ; keesc...@chromium.org;
gpicc...@igalia.com; raf...@kernel.org; l...@kernel.org; james
Justin Stitt wrote:
> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
>
> `extra` is intended to be NUL-terminated which is evident by the manual
> assignment of a NUL-byte as well as its
Justin Stitt wrote:
> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
>
> Based on other assignments of similar fw_version fields we can see that
> NUL-termination is required but not NUL
Justin Stitt wrote:
> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
>
> wl->chip.phy_fw_ver_str is obviously intended to be NUL-terminated by
> the deliberate comment telling us as much
Justin Stitt wrote:
> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
>
> We expect wl->chip.fw_ver_str to be NUL-terminated based on its usage
> with DRIVER_STATE_PRINT_STR() in debugfs.
Justin Stitt wrote:
> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
>
> We expect fw_version strings to be NUL-terminated based on other similar
> assignments:
>
> wireless/broadcom/br
Justin Stitt wrote:
> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
>
> We expect priv->firmware_id to be NUL-terminated based on its usage
> with seq_printf() and strlen() in atmel.c:
Hi Justin,
On Sat, Oct 21, 2023 at 12:09:16AM +, Justin Stitt wrote:
> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
>
> This patch replaces 3 callsites of strncpy().
>
> The first
strncpy() is deprecated for use on NUL-terminated destination strings
[1] and as such we should prefer more robust and less ambiguous string
interfaces.
This patch replaces 3 callsites of strncpy().
The first two populate the destination buffer `nsm.name` -- which we
expect to be NUL-terminated b
65d9ab7d223b5402d1f02c
change-id: 20231023-strncpy-drivers-s390-char-sclp-c-bb66226a7eaa
Best regards,
--
Justin Stitt
y != ND_VALIDITY_VALID) {
- strncpy(params, "n/a", PARAMS_LEN - 1);
- strncpy(id, "n/a", NODEID_LEN - 1);
+ strscpy(params, "n/a", PARAMS_LEN);
+ strscpy(id, "n/a", NODEID_LEN);
return;
ID_SIZE];
int ok = 0;
if (ch == NULL)
return;
else
- strncpy(chid, ch->id, CTCM_ID_SIZE);
+ strscpy(chid, ch->id, sizeof(chid));
channel_free(ch);
while (*c) {
---
base-commit: 9c5d00cb7b6bbc5a7965d9ab7
= card->debug;
mutex_lock(&qeth_dbf_list_mutex);
list_add(&new_entry->dbf_list, &qeth_dbf_list);
---
base-commit: 9c5d00cb7b6bbc5a7965d9ab7d223b5402d1f02c
change-id: 20231023-strncpy-drivers-s390-net-qeth_core_main-c-0b0ee08672ec
Best regards,
--
Justin Stitt
On Mon, Oct 23, 2023 at 06:12:28PM +, Justin Stitt wrote:
> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
>
> This patch replaces 3 callsites of strncpy().
>
> The first two populate
CURRENT_DRIVER_BRANCH;
tw_dev->tw_compat_info.driver_build_high =
TW_CURRENT_DRIVER_BUILD;
---
base-commit: 9c5d00cb7b6bbc5a7965d9ab7d223b5402d1f02c
change-id: 20231023-strncpy-drivers-scsi-3w-sas-c-c7cc037d4bc9
Best regards,
--
Justin Stitt
On Mon, Oct 23, 2023 at 12:40 PM Mathieu Poirier
wrote:
>
> On Mon, Oct 23, 2023 at 06:12:28PM +, Justin Stitt wrote:
> > strncpy() is deprecated for use on NUL-terminated destination strings
> > [1] and as such we should prefer more robust and less ambiguous string
> > interfaces.
> >
> > Thi
VAL;
- strncpy(stats_addr->version, BNX2FC_VERSION,
+ strscpy(stats_addr->version, BNX2FC_VERSION,
sizeof(stats_addr->version));
stats_addr->txq_size = BNX2FC_SQ_WQES_MAX;
stats_addr->rxq_size = BNX2FC_CQ_WQES_MAX;
---
base-commit: 9c5d00cb7b6bbc5a7965d9ab7d223b5402d1f02c
change-id: 20231023-strncpy-drivers-scsi-bnx2fc-bnx2fc_fcoe-c-f24335846e35
Best regards,
--
Justin Stitt
sizeof(vparams.cvp_label4));
}
if (copy_to_user(argp, &vparams, sizeof(vparams)))
return -EFAULT;
---
base-commit: 9c5d00cb7b6bbc5a7965d9ab7d223b5402d1f02c
change-id: 20231023-strncpy-drivers-scsi-ch-c-23b1cdac43cc
Best regards,
--
Justin Stitt
));
/* memory pool/DMA pool allocation */
if (csio_resource_alloc(hw))
---
base-commit: 9c5d00cb7b6bbc5a7965d9ab7d223b5402d1f02c
change-id: 20231023-strncpy-drivers-scsi-csiostor-csio_init-c-9c96b2f77e22
Best regards,
--
Justin Stitt
On Mon, 23 Oct 2023 at 08:06, Sophon Wu wrote:
>
> Dmitry Baryshkov 于2023年10月22日周日 18:51写道：
> >
> > On Sat, 21 Oct 2023 at 13:20, Xilin Wu via B4 Relay
> > wrote:
> > >
> > > From: Xilin Wu
> > >
> > > UCSI is supported on SM8350. Allow it to enable USB role switch and
> > > altmode notificatio
On Sun, 22 Oct 2023 at 13:51, Dmitry Baryshkov
wrote:
>
> On Sat, 21 Oct 2023 at 13:20, Xilin Wu via B4 Relay
> wrote:
> >
> > From: Xilin Wu
> >
> > UCSI is supported on SM8350. Allow it to enable USB role switch and
> > altmode notifications on SM8350.
>
> We have had troubles with UCSI on sm8
tate_name));
}
node->prev_evt = node->current_evt;
---
base-commit: 9c5d00cb7b6bbc5a7965d9ab7d223b5402d1f02c
change-id: 20231023-strncpy-drivers-scsi-elx-libefc-efc_node-h-cbbf753197b7
Best regards,
--
Justin Stitt
Quoting Gustavo A. R. Silva (2023-10-16 15:05:27)
> `struct clk_hw_onecell_data` is a flexible structure, which means that
> it contains flexible-array member at the bottom, in this case array
> `hws`:
>
> include/linux/clk-provider.h:
> 1380 struct clk_hw_onecell_data {
> 1381 unsigned in
Quoting Gustavo A. R. Silva (2023-10-16 15:06:16)
> In order to gain the bounds-checking coverage that __counted_by provides
> to flexible-array members at run-time via CONFIG_UBSAN_BOUNDS (for array
> indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions),
> we must make sure tha
Fixes: b4cbe606dc36 ("clk: visconti: Add support common clock driver and reset
driver")
Cc: sta...@vger.kernel.org
Reviewed-by: Kees Cook
Acked-by: Nobuhiro Iwamatsu
Signed-off-by: Gustavo A. R. Silva
---
Applied to clk-next
Hi!
Here is another similar small series, in case you missed
Quoting Gustavo A. R. Silva (2023-10-23 19:48:00)
>
> >> Fixes: b4cbe606dc36 ("clk: visconti: Add support common clock driver and
> >> reset driver")
> >> Cc: sta...@vger.kernel.org
> >> Reviewed-by: Kees Cook
> >> Acked-by: Nobuhiro Iwamatsu
> >> Signed-off-by: Gustavo A. R. Silva
> >> ---
>
This series aims to fix an undefined behavior bug in
`struct stratix10_clock_data` and add bounds-checking
coverage at run-time for flexible-array member `hws`
in `struct clk_hw_onecell_data` when accessed throught
`struct stratix10_clock_data`.
Changes in v3:
- None, really. Just Cc linux-...@vg
`struct clk_hw_onecell_data` is a flexible structure, which means that
it contains flexible-array member at the bottom, in this case array
`hws`:
include/linux/clk-provider.h:
1380 struct clk_hw_onecell_data {
1381 unsigned int num;
1382 struct clk_hw *hws[] __counted_by(num);
1383
In order to gain the bounds-checking coverage that __counted_by provides
to flexible-array members at run-time via CONFIG_UBSAN_BOUNDS (for array
indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions),
we must make sure that the counter member, in this case `num`, is updated
befor
Quoting Gustavo A. R. Silva (2023-10-23 20:30:52)
> `struct clk_hw_onecell_data` is a flexible structure, which means that
> it contains flexible-array member at the bottom, in this case array
> `hws`:
>
> include/linux/clk-provider.h:
> 1380 struct clk_hw_onecell_data {
> 1381 unsigned in
Quoting Gustavo A. R. Silva (2023-10-23 20:31:42)
> In order to gain the bounds-checking coverage that __counted_by provides
> to flexible-array members at run-time via CONFIG_UBSAN_BOUNDS (for array
> indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions),
> we must make sure tha
On Sat, Oct 21, 2023 at 07:13:51PM +0200, Christophe JAILLET wrote:
> @@ -1127,27 +1128,26 @@ static irqreturn_t thunderx_ocx_com_threaded_isr(int
> irq, void *irq_id)
> ARRAY_SIZE(ocx->com_err_ctx));
> ctx = &ocx->com_err_ctx[tail];
>
> -
On Tue, Oct 24, 2023 at 08:35:33AM +0300, Dan Carpenter wrote:
> On Sat, Oct 21, 2023 at 07:13:51PM +0200, Christophe JAILLET wrote:
> > @@ -1127,27 +1128,26 @@ static irqreturn_t
> > thunderx_ocx_com_threaded_isr(int irq, void *irq_id)
> > ARRAY_SIZE(ocx->com_err_ctx))
Initial support for Xiaomi Pad 6 tablet, that have sm8250 soc.
Signed-off-by: Luka Panio
---
v2:
Update commit message. Drop reserved gpio's as this device in reality do not
have gpio, and pins are not protected.
v3:
Update commit message.
v4:
Update commit message.
v5:
Update commit message.
Add a compatible for Xiaomi Pad 6.
Acked-by: Conor Dooley
Signed-off-by: Luka Panio
---
v2:
Update commit message
v3:
Update commit message
v4:
Update commit message
v5:
Update commit message
v6:
Update commit message
---
Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
1 file change
47 matches
Mail list logo
