Re: [PATCH v5][next] integrity: Avoid -Wflex-array-member-not-at-end warnings

2024-04-05 Thread Mimi Zohar
On Thu, 2024-04-04 at 18:56 -0600, Gustavo A. R. Silva wrote: > > "checkpatch.pl --strict" complains "CHECK: Alignment should match open > > parenthesis". I'll queue the patch, but how about teaching checkpatch.pl to > > ignore __struct_group()? > > I think this would do it: > > diff --git a/scr

Re: [PATCH v5][next] integrity: Avoid -Wflex-array-member-not-at-end warnings

2024-04-04 Thread Gustavo A. R. Silva
"checkpatch.pl --strict" complains "CHECK: Alignment should match open parenthesis". I'll queue the patch, but how about teaching checkpatch.pl to ignore __struct_group()? I think this would do it: diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 9c4c4a61bc83..e229b97f17f6 1

Re: [PATCH v5][next] integrity: Avoid -Wflex-array-member-not-at-end warnings

2024-04-04 Thread Mimi Zohar
On Thu, 2024-04-04 at 12:49 -0400, Mimi Zohar wrote: > Hi Gustavo, > > On Thu, 2024-04-04 at 09:00 -0600, Gustavo A. R. Silva wrote: > > -Wflex-array-member-not-at-end is coming in GCC-14, and we are getting > > ready to enable it globally. > > > > There is currently an object (`hdr)` in `struct

Re: [PATCH v5][next] integrity: Avoid -Wflex-array-member-not-at-end warnings

2024-04-04 Thread Mimi Zohar
Hi Gustavo, On Thu, 2024-04-04 at 09:00 -0600, Gustavo A. R. Silva wrote: > -Wflex-array-member-not-at-end is coming in GCC-14, and we are getting > ready to enable it globally. > > There is currently an object (`hdr)` in `struct ima_max_digest_data` > that contains a flexible structure (`struct