Re: [PATCH v3 3/4] binfmt_elf: Provide prot bits as context for padzero() errors

2023-09-28 Thread Kees Cook
On Wed, Sep 27, 2023 at 03:18:34PM -0500, Eric W. Biederman wrote: > Kees Cook writes: > > > Errors with padzero() should be caught unless we're expecting a > > pathological (non-writable) segment. Report -EFAULT only when PROT_WRITE > > is present. > > > > Additionally add some more documentatio

Re: [PATCH v3 3/4] binfmt_elf: Provide prot bits as context for padzero() errors

2023-09-27 Thread Eric W. Biederman
Kees Cook writes: > Errors with padzero() should be caught unless we're expecting a > pathological (non-writable) segment. Report -EFAULT only when PROT_WRITE > is present. > > Additionally add some more documentation to padzero(), elf_map(), and > elf_load(). I wonder if this might be easier to