Re: [PATCH v3] driver core: Cancel scheduled pm_runtime_idle() on device removal

On Tue, Mar 5, 2024 at 10:20 AM Ricky WU wrote: > > > On Mon, Mar 4, 2024 at 7:10 PM Rafael J. Wysocki > > wrote: > > > > > > On Mon, Mar 4, 2024 at 6:00 PM Rafael J. Wysocki > > wrote: > > > > > > > > On Mon, Mar 4, 2024 at 5:41 PM Rafael J. Wysocki > > wrote: > > > > > > > > > > On Mon, Mar 4

Re: [PATCH v3] driver core: Cancel scheduled pm_runtime_idle() on device removal

On Tue, Mar 5, 2024 at 8:20 AM Kai-Heng Feng wrote: > > On Tue, Mar 5, 2024 at 2:10 AM Rafael J. Wysocki wrote: > > > > On Mon, Mar 4, 2024 at 6:00 PM Rafael J. Wysocki wrote: > > > > > > On Mon, Mar 4, 2024 at 5:41 PM Rafael J. Wysocki > > > wrote: > > > > > > > > On Mon, Mar 4, 2024 at 4:51 

RE: [PATCH v3] driver core: Cancel scheduled pm_runtime_idle() on device removal

> On Mon, Mar 4, 2024 at 7:10 PM Rafael J. Wysocki > wrote: > > > > On Mon, Mar 4, 2024 at 6:00 PM Rafael J. Wysocki > wrote: > > > > > > On Mon, Mar 4, 2024 at 5:41 PM Rafael J. Wysocki > wrote: > > > > > > > > On Mon, Mar 4, 2024 at 4:51 PM Bjorn Helgaas > wrote: > > > > > > > > > > On Mon, M

Re: [PATCH v3] driver core: Cancel scheduled pm_runtime_idle() on device removal

On Tue, Mar 5, 2024 at 2:10 AM Rafael J. Wysocki wrote: > > On Mon, Mar 4, 2024 at 6:00 PM Rafael J. Wysocki wrote: > > > > On Mon, Mar 4, 2024 at 5:41 PM Rafael J. Wysocki wrote: > > > > > > On Mon, Mar 4, 2024 at 4:51 PM Bjorn Helgaas wrote: > > > > > > > > On Mon, Mar 04, 2024 at 03:38:38PM

Re: [PATCH v3] driver core: Cancel scheduled pm_runtime_idle() on device removal

On Mon, Mar 4, 2024 at 7:10 PM Rafael J. Wysocki wrote: > > On Mon, Mar 4, 2024 at 6:00 PM Rafael J. Wysocki wrote: > > > > On Mon, Mar 4, 2024 at 5:41 PM Rafael J. Wysocki wrote: > > > > > > On Mon, Mar 4, 2024 at 4:51 PM Bjorn Helgaas wrote: > > > > > > > > On Mon, Mar 04, 2024 at 03:38:38PM

Re: [PATCH v3] driver core: Cancel scheduled pm_runtime_idle() on device removal

On Mon, Mar 4, 2024 at 6:00 PM Rafael J. Wysocki wrote: > > On Mon, Mar 4, 2024 at 5:41 PM Rafael J. Wysocki wrote: > > > > On Mon, Mar 4, 2024 at 4:51 PM Bjorn Helgaas wrote: > > > > > > On Mon, Mar 04, 2024 at 03:38:38PM +0100, Rafael J. Wysocki wrote: > > > > On Thu, Feb 29, 2024 at 7:23 AM K

Re: [PATCH v3] driver core: Cancel scheduled pm_runtime_idle() on device removal

On Mon, Mar 4, 2024 at 5:41 PM Rafael J. Wysocki wrote: > > On Mon, Mar 4, 2024 at 4:51 PM Bjorn Helgaas wrote: > > > > On Mon, Mar 04, 2024 at 03:38:38PM +0100, Rafael J. Wysocki wrote: > > > On Thu, Feb 29, 2024 at 7:23 AM Kai-Heng Feng > > > wrote: > > > > > > > > When inserting an SD7.0 card

Re: [PATCH v3] driver core: Cancel scheduled pm_runtime_idle() on device removal

On Mon, Mar 4, 2024 at 4:51 PM Bjorn Helgaas wrote: > > On Mon, Mar 04, 2024 at 03:38:38PM +0100, Rafael J. Wysocki wrote: > > On Thu, Feb 29, 2024 at 7:23 AM Kai-Heng Feng > > wrote: > > > > > > When inserting an SD7.0 card to Realtek card reader, the card reader > > > unplugs itself and morph i

Re: [PATCH v3] driver core: Cancel scheduled pm_runtime_idle() on device removal

On Mon, Mar 04, 2024 at 03:38:38PM +0100, Rafael J. Wysocki wrote: > On Thu, Feb 29, 2024 at 7:23 AM Kai-Heng Feng > wrote: > > > > When inserting an SD7.0 card to Realtek card reader, the card reader > > unplugs itself and morph into a NVMe device. The slot Link down on hot > > unplugged can caus

Re: [PATCH v3] driver core: Cancel scheduled pm_runtime_idle() on device removal

On Thu, Feb 29, 2024 at 7:23 AM Kai-Heng Feng wrote: > > When inserting an SD7.0 card to Realtek card reader, the card reader > unplugs itself and morph into a NVMe device. The slot Link down on hot > unplugged can cause the following error: > > pcieport :00:1c.0: pciehp: Slot(8): Link Down >

Re: [PATCH v3] driver core: Cancel scheduled pm_runtime_idle() on device removal

On Thu, Feb 29, 2024 at 8:21 PM Bjorn Helgaas wrote: > > [+to Rafael, can you comment on whether this is the right fix for the > .remove() vs .runtime_idle() race?] It doesn't seem so. pm_runtime_get_sync() is expected to cancel pending pm_runtime_idle() in all cases, so this looks like PM-runti

Re: [PATCH v3] driver core: Cancel scheduled pm_runtime_idle() on device removal

[+to Rafael, can you comment on whether this is the right fix for the .remove() vs .runtime_idle() race?] On Thu, Feb 29, 2024 at 02:22:00PM +0800, Kai-Heng Feng wrote: > When inserting an SD7.0 card to Realtek card reader, the card reader > unplugs itself and morph into a NVMe device. The slot Li

RE: [PATCH v3] driver core: Cancel scheduled pm_runtime_idle() on device removal

> When inserting an SD7.0 card to Realtek card reader, the card reader > unplugs itself and morph into a NVMe device. The slot Link down on hot > unplugged can cause the following error: > > pcieport :00:1c.0: pciehp: Slot(8): Link Down > BUG: unable to handle page fault for address: b24d4

Re: [PATCH v3] driver core: Cancel scheduled pm_runtime_idle() on device removal

On Thu, Feb 29, 2024 at 02:22:00PM +0800, Kai-Heng Feng wrote: > When inserting an SD7.0 card to Realtek card reader, the card reader > unplugs itself and morph into a NVMe device. The slot Link down on hot > unplugged can cause the following error: > > pcieport :00:1c.0: pciehp: Slot(8): Link