Re: [PATCH -next v3 3/3] nfs make use of str_false_true helper

2024-08-26 Thread Hongbo Li
On 2024/8/27 11:33, Matthew Wilcox wrote: On Tue, Aug 27, 2024 at 10:45:17AM +0800, Hongbo Li wrote: The helper str_false_true is introduced to reback "false/true" string literal. We can simplify this format by str_false_true. This seems unnecessarily verbose & complex. How about:

Re: [PATCH -next v3 3/3] nfs make use of str_false_true helper

2024-08-26 Thread Matthew Wilcox
On Tue, Aug 27, 2024 at 10:45:17AM +0800, Hongbo Li wrote: > The helper str_false_true is introduced to reback "false/true" > string literal. We can simplify this format by str_false_true. This seems unnecessarily verbose & complex. How about: dprintk("%s: link support=%s\n", __func__, s