On Wed, 4 Sep 2024 10:27:18 +0800 Hongbo Li wrote:
> However, with these modifications, I'm not sure whether Willem and Jakub
> agree with the changes. If they don't agree, then I'll have to remove
> this example in the next version.
This and, to be clear, patch 4 as well.
> In the future, we c
On 2024/9/3 23:09, Andy Shevchenko wrote:
On Tue, Sep 03, 2024 at 02:25:53PM +0800, Hongbo Li wrote:
On 2024/9/2 22:30, Willem de Bruijn wrote:
Andy Shevchenko wrote:
On Sat, Aug 31, 2024 at 01:07:41PM -0700, Jakub Kicinski wrote:
On Sat, 31 Aug 2024 17:58:38 +0800 Hongbo Li wrote:
...
On Tue, Sep 03, 2024 at 02:25:53PM +0800, Hongbo Li wrote:
> On 2024/9/2 22:30, Willem de Bruijn wrote:
> > Andy Shevchenko wrote:
> > > On Sat, Aug 31, 2024 at 01:07:41PM -0700, Jakub Kicinski wrote:
> > > > On Sat, 31 Aug 2024 17:58:38 +0800 Hongbo Li wrote:
...
> > > > > netif_in
On 2024/9/2 22:30, Willem de Bruijn wrote:
Andy Shevchenko wrote:
On Sat, Aug 31, 2024 at 01:07:41PM -0700, Jakub Kicinski wrote:
On Sat, 31 Aug 2024 17:58:38 +0800 Hongbo Li wrote:
Use str_disabled_enabled() helper instead of open
coding the same.
...
netif_info(tun, dr
On Mon, 2 Sep 2024 09:10:33 +0300 Gal Pressman wrote:
> > You don't explain the 'why'. How is this an improvement?
> > nack on this and 2 similar networking changes you sent
>
> Are you against the concept of string_choices in general, or this
> specific change?
Willem verbalized my opinion bette
Andy Shevchenko wrote:
> On Sat, Aug 31, 2024 at 01:07:41PM -0700, Jakub Kicinski wrote:
> > On Sat, 31 Aug 2024 17:58:38 +0800 Hongbo Li wrote:
> > > Use str_disabled_enabled() helper instead of open
> > > coding the same.
>
> ...
>
> > > netif_info(tun, drv, tun->dev, "ignored: set ch
On Sat, Aug 31, 2024 at 01:07:41PM -0700, Jakub Kicinski wrote:
> On Sat, 31 Aug 2024 17:58:38 +0800 Hongbo Li wrote:
> > Use str_disabled_enabled() helper instead of open
> > coding the same.
...
> > netif_info(tun, drv, tun->dev, "ignored: set checksum %s\n",
> > -
On 31/08/2024 23:07, Jakub Kicinski wrote:
> On Sat, 31 Aug 2024 17:58:38 +0800 Hongbo Li wrote:
>> Use str_disabled_enabled() helper instead of open
>> coding the same.
>
>> diff --git a/drivers/net/tun.c b/drivers/net/tun.c
>> index 6fe5e8f7017c..29647704bda8 100644
>> --- a/drivers/net/tun.c
>>
On 2024/9/1 4:07, Jakub Kicinski wrote:
On Sat, 31 Aug 2024 17:58:38 +0800 Hongbo Li wrote:
Use str_disabled_enabled() helper instead of open
coding the same.
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 6fe5e8f7017c..29647704bda8 100644
--- a/drivers/net/tun.c
+++ b/drivers/ne
On Sat, 31 Aug 2024 17:58:38 +0800 Hongbo Li wrote:
> Use str_disabled_enabled() helper instead of open
> coding the same.
> diff --git a/drivers/net/tun.c b/drivers/net/tun.c
> index 6fe5e8f7017c..29647704bda8 100644
> --- a/drivers/net/tun.c
> +++ b/drivers/net/tun.c
> @@ -3178,7 +3178,7 @@ stat
10 matches
Mail list logo
