Re: [PATCH] printf: Remove unused 'bprintf'

2024-10-02 Thread Dr. David Alan Gilbert
* Steven Rostedt (rost...@goodmis.org) wrote: > On Wed, 2 Oct 2024 14:31:19 + > "Dr. David Alan Gilbert" wrote: > > > > I am not familiar with tricks in BPF or ftrace code where this actually > > > might > > > be implicitly called via a macro, but brief grep gives nothing that might > > > p

Re: [PATCH] printf: Remove unused 'bprintf'

2024-10-02 Thread Dr. David Alan Gilbert
* Andy Shevchenko (a...@kernel.org) wrote: > On Wed, Oct 02, 2024 at 02:31:19PM +, Dr. David Alan Gilbert wrote: > > * Andy Shevchenko (a...@kernel.org) wrote: > > > On Wed, Oct 02, 2024 at 02:21:25AM +0100, li...@treblig.org wrote: > > > > From: "Dr. David Alan Gilbert" > > > > > > > > bprin

Re: [PATCH] printf: Remove unused 'bprintf'

2024-10-02 Thread Steven Rostedt
On Wed, 2 Oct 2024 14:31:19 + "Dr. David Alan Gilbert" wrote: > > I am not familiar with tricks in BPF or ftrace code where this actually > > might > > be implicitly called via a macro, but brief grep gives nothing that might > > point > > to that. > > I've got an all-yes build (well, mo

Re: [PATCH] printf: Remove unused 'bprintf'

2024-10-02 Thread Andy Shevchenko
On Wed, Oct 02, 2024 at 02:31:19PM +, Dr. David Alan Gilbert wrote: > * Andy Shevchenko (a...@kernel.org) wrote: > > On Wed, Oct 02, 2024 at 02:21:25AM +0100, li...@treblig.org wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > bprintf is unused. Remove it. > > > > bprintf() > > OK. >

Re: [PATCH] printf: Remove unused 'bprintf'

2024-10-02 Thread Dr. David Alan Gilbert
* Andy Shevchenko (a...@kernel.org) wrote: > On Wed, Oct 02, 2024 at 02:21:25AM +0100, li...@treblig.org wrote: > > From: "Dr. David Alan Gilbert" > > > > bprintf is unused. Remove it. > > bprintf() OK. > > It was added in > > commit 4370aa4aa753 ("vsprintf: add binary printf") > > > > but a

Re: [PATCH] printf: Remove unused 'bprintf'

2024-10-02 Thread Andy Shevchenko
On Wed, Oct 02, 2024 at 02:21:25AM +0100, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > bprintf is unused. Remove it. bprintf() > It was added in > commit 4370aa4aa753 ("vsprintf: add binary printf") > > but as far as I can see was never used, unlike the other > two functions