Re: [PATCH][next] cxgb4: Avoid -Wflex-array-member-not-at-end warning

2024-08-08 Thread Jakub Kicinski
On Thu, 8 Aug 2024 12:41:32 -0600 Gustavo A. R. Silva wrote: > >> .../chelsio/cxgb4/cxgb4_tc_u32_parse.h| 2 +- > >> include/uapi/linux/pkt_cls.h | 23 +++ > > > > Took me a minute to realize you're changing uAPI. > > Please fix the subject. > > Wha

Re: [PATCH][next] cxgb4: Avoid -Wflex-array-member-not-at-end warning

2024-08-08 Thread Gustavo A. R. Silva
.../chelsio/cxgb4/cxgb4_tc_u32_parse.h| 2 +- include/uapi/linux/pkt_cls.h | 23 +++ Took me a minute to realize you're changing uAPI. Please fix the subject. What would be a preferred subject? -- Gustavo

Re: [PATCH][next] cxgb4: Avoid -Wflex-array-member-not-at-end warning

2024-08-07 Thread Jakub Kicinski
On Mon, 5 Aug 2024 10:24:30 -0600 Gustavo A. R. Silva wrote: > Subject: [PATCH][next] cxgb4: Avoid -Wflex-array-member-not-at-end warning > Date: Mon, 5 Aug 2024 10:24:30 -0600 > .../chelsio/cxgb4/cxgb4_tc_u32_parse.h| 2 +- > include/uapi/linux/pkt_cls.h | 23 ++

Re: [PATCH][next] cxgb4: Avoid -Wflex-array-member-not-at-end warning

2024-08-07 Thread Simon Horman
On Mon, Aug 05, 2024 at 10:24:30AM -0600, Gustavo A. R. Silva wrote: > -Wflex-array-member-not-at-end was introduced in GCC-14, and we are > getting ready to enable it, globally. > > So, in order to avoid ending up with a flexible-array member in the > middle of multiple other structs, we use the