Re: [PATCH v8 3/7] mseal sysmap: enable x86-64

2025-03-03 Thread Jeff Xu
On Mon, Mar 3, 2025 at 4:01 AM Lorenzo Stoakes wrote: > > I tried b4 shazam'ing this and there's a problem applying the patch, seems > maybe a conflict? > > Not sure if Andrew can resolve or if something needs to be done here? > > Seems to be commit d77a800944d8 ("mm: make DEBUG_@WX dependent on >

Re: [PATCH v8 3/7] mseal sysmap: enable x86-64

2025-03-03 Thread Kees Cook
On Mon, Mar 03, 2025 at 05:09:17AM +, jef...@chromium.org wrote: > From: Jeff Xu > > Provide support for CONFIG_MSEAL_SYSTEM_MAPPINGS on x86-64, > covering the vdso, vvar, vvar_vclock. > > Production release testing passes on Android and Chrome OS. > > Signed-off-by: Jeff Xu Short and to

Re: [PATCH v8 3/7] mseal sysmap: enable x86-64

2025-03-03 Thread Liam R. Howlett
* jef...@chromium.org [250303 00:09]: > From: Jeff Xu > > Provide support for CONFIG_MSEAL_SYSTEM_MAPPINGS on x86-64, > covering the vdso, vvar, vvar_vclock. > > Production release testing passes on Android and Chrome OS. > > Signed-off-by: Jeff Xu Thanks, this is much cleaner. Reviewed-by:

Re: [PATCH v8 3/7] mseal sysmap: enable x86-64

2025-03-03 Thread Lorenzo Stoakes
I tried b4 shazam'ing this and there's a problem applying the patch, seems maybe a conflict? Not sure if Andrew can resolve or if something needs to be done here? Seems to be commit d77a800944d8 ("mm: make DEBUG_@WX dependent on GENERIC_PTDUMP")? Should be a trivial resolve though. On Mon, Mar

Re: [PATCH v8 3/7] mseal sysmap: enable x86-64

2025-03-03 Thread Lorenzo Stoakes
On Mon, Mar 03, 2025 at 05:09:17AM +, jef...@chromium.org wrote: > From: Jeff Xu > > Provide support for CONFIG_MSEAL_SYSTEM_MAPPINGS on x86-64, > covering the vdso, vvar, vvar_vclock. > > Production release testing passes on Android and Chrome OS. > > Signed-off-by: Jeff Xu LGTM, so: Revie

[PATCH v8 3/7] mseal sysmap: enable x86-64

2025-03-02 Thread jeffxu
From: Jeff Xu Provide support for CONFIG_MSEAL_SYSTEM_MAPPINGS on x86-64, covering the vdso, vvar, vvar_vclock. Production release testing passes on Android and Chrome OS. Signed-off-by: Jeff Xu --- arch/x86/Kconfig | 1 + arch/x86/entry/vdso/vma.c | 7 --- 2 files changed, 5 ins