Re: [PATCH v7 5/7] mseal, system mappings: enable uml architecture

2025-02-25 Thread Jeff Xu
On Tue, Feb 25, 2025 at 10:38 AM Kees Cook wrote: > > On Tue, Feb 25, 2025 at 03:31:06PM +, Lorenzo Stoakes wrote: > > On Tue, Feb 25, 2025 at 07:06:13AM -0800, Kees Cook wrote: > > > > > > > > > On February 25, 2025 2:37:11 AM PST, Lorenzo Stoakes > > > wrote: > > > >On Tue, Feb 25, 2025 at

Re: [PATCH v7 5/7] mseal, system mappings: enable uml architecture

2025-02-25 Thread Kees Cook
On Tue, Feb 25, 2025 at 03:31:06PM +, Lorenzo Stoakes wrote: > On Tue, Feb 25, 2025 at 07:06:13AM -0800, Kees Cook wrote: > > > > > > On February 25, 2025 2:37:11 AM PST, Lorenzo Stoakes > > wrote: > > >On Tue, Feb 25, 2025 at 08:45:21AM +, Berg, Benjamin wrote: > > >> Hi, > > >> > > >> O

Re: [PATCH v7 5/7] mseal, system mappings: enable uml architecture

2025-02-25 Thread Lorenzo Stoakes
On Tue, Feb 25, 2025 at 07:06:13AM -0800, Kees Cook wrote: > > > On February 25, 2025 2:37:11 AM PST, Lorenzo Stoakes > wrote: > >On Tue, Feb 25, 2025 at 08:45:21AM +, Berg, Benjamin wrote: > >> Hi, > >> > >> On Tue, 2025-02-25 at 06:22 +, Lorenzo Stoakes wrote: > >> > On Mon, Feb 24, 202

Re: [PATCH v7 5/7] mseal, system mappings: enable uml architecture

2025-02-25 Thread Kees Cook
On February 25, 2025 2:37:11 AM PST, Lorenzo Stoakes wrote: >On Tue, Feb 25, 2025 at 08:45:21AM +, Berg, Benjamin wrote: >> Hi, >> >> On Tue, 2025-02-25 at 06:22 +, Lorenzo Stoakes wrote: >> > On Mon, Feb 24, 2025 at 10:52:44PM +, jef...@chromium.org wrote: >> > > From: Jeff Xu >>

Re: [PATCH v7 5/7] mseal, system mappings: enable uml architecture

2025-02-25 Thread Johannes Berg
On Tue, 2025-02-25 at 13:41 +, Lorenzo Stoakes wrote: > > I figured it is not a lot of churn and there isn't really any cost to > > enabling the feature. > > > > That said, the only possible real-life use case I can see is doing MM > > subsystem testing using UML. We certainly do not need the

Re: [PATCH v7 5/7] mseal, system mappings: enable uml architecture

2025-02-25 Thread Lorenzo Stoakes
On Tue, Feb 25, 2025 at 01:24:49PM +0100, Benjamin Berg wrote: > Hi, > > On Tue, 2025-02-25 at 10:37 +, Lorenzo Stoakes wrote: > > On Tue, Feb 25, 2025 at 08:45:21AM +, Berg, Benjamin wrote: > > > Hi, > > > > > > On Tue, 2025-02-25 at 06:22 +, Lorenzo Stoakes wrote: > > > > On Mon, Feb

Re: [PATCH v7 5/7] mseal, system mappings: enable uml architecture

2025-02-25 Thread Benjamin Berg
Hi, On Tue, 2025-02-25 at 10:37 +, Lorenzo Stoakes wrote: > On Tue, Feb 25, 2025 at 08:45:21AM +, Berg, Benjamin wrote: > > Hi, > > > > On Tue, 2025-02-25 at 06:22 +, Lorenzo Stoakes wrote: > > > On Mon, Feb 24, 2025 at 10:52:44PM +, jef...@chromium.org wrote: > > > > From: Jeff X

Re: [PATCH v7 5/7] mseal, system mappings: enable uml architecture

2025-02-25 Thread Lorenzo Stoakes
On Tue, Feb 25, 2025 at 08:45:21AM +, Berg, Benjamin wrote: > Hi, > > On Tue, 2025-02-25 at 06:22 +, Lorenzo Stoakes wrote: > > On Mon, Feb 24, 2025 at 10:52:44PM +, jef...@chromium.org wrote: > > > From: Jeff Xu > > > > > > Provide support for CONFIG_MSEAL_SYSTEM_MAPPINGS on UML, cove

Re: [PATCH v7 5/7] mseal, system mappings: enable uml architecture

2025-02-25 Thread Berg, Benjamin
Hi, On Tue, 2025-02-25 at 06:22 +, Lorenzo Stoakes wrote: > On Mon, Feb 24, 2025 at 10:52:44PM +, jef...@chromium.org wrote: > > From: Jeff Xu > > > > Provide support for CONFIG_MSEAL_SYSTEM_MAPPINGS on UML, covering > > the vdso. > > > > Testing passes on UML. > > Maybe expand on this

Re: [PATCH v7 5/7] mseal, system mappings: enable uml architecture

2025-02-24 Thread Lorenzo Stoakes
On Mon, Feb 24, 2025 at 10:52:44PM +, jef...@chromium.org wrote: > From: Jeff Xu > > Provide support for CONFIG_MSEAL_SYSTEM_MAPPINGS on UML, covering > the vdso. > > Testing passes on UML. Maybe expand on this by stating that it has been confirmed by Benjamin (I _believe_) that UML has no ne

[PATCH v7 5/7] mseal, system mappings: enable uml architecture

2025-02-24 Thread jeffxu
From: Jeff Xu Provide support for CONFIG_MSEAL_SYSTEM_MAPPINGS on UML, covering the vdso. Testing passes on UML. Signed-off-by: Jeff Xu Tested-by: Benjamin Berg --- arch/um/Kconfig| 1 + arch/x86/um/vdso/vma.c | 6 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a