Re: [PATCH v7 06/10] ASoC: pxa: Suppress SSPA on ARM64

2023-11-11 Thread Duje Mihanović
On Saturday, November 11, 2023 12:39:17 PM CET Mark Brown wrote: > On Fri, Nov 10, 2023 at 08:28:56PM +0100, Duje Mihanović wrote: > > Can you elaborate? As far as I can tell there are 2 drivers named > > pxa2xx-ac97 > > in sound/{arm,soc/pxa} and neither one has any dependency on AACI. > > They d

Re: [PATCH v7 06/10] ASoC: pxa: Suppress SSPA on ARM64

2023-11-11 Thread Mark Brown
On Fri, Nov 10, 2023 at 08:28:56PM +0100, Duje Mihanović wrote: > On Monday, November 6, 2023 11:58:46 AM CET Mark Brown wrote: > > On Fri, Nov 03, 2023 at 05:58:05PM +0100, Duje Mihanović wrote: > > > this correctly, I would have to remove "select SND_ARM" from sound/soc/ > pxa/ > > > Kconfig and

Re: [PATCH v7 06/10] ASoC: pxa: Suppress SSPA on ARM64

2023-11-10 Thread Duje Mihanović
On Monday, November 6, 2023 11:58:46 AM CET Mark Brown wrote: > On Fri, Nov 03, 2023 at 05:58:05PM +0100, Duje Mihanović wrote: > > I just looked at it again and it looks like no code in sound/soc/pxa/* or > > sound/arm/pxa* depends on AACI in any way. Therefore, I believe that to fix > > this cor

Re: [PATCH v7 06/10] ASoC: pxa: Suppress SSPA on ARM64

2023-11-06 Thread Mark Brown
On Fri, Nov 03, 2023 at 05:58:05PM +0100, Duje Mihanović wrote: > I just looked at it again and it looks like no code in sound/soc/pxa/* or > sound/arm/pxa* depends on AACI in any way. Therefore, I believe that to fix > this correctly, I would have to remove "select SND_ARM" from sound/soc/pxa/

Re: [PATCH v7 06/10] ASoC: pxa: Suppress SSPA on ARM64

2023-11-03 Thread Duje Mihanović
On Friday, November 3, 2023 4:23:28 PM CET Robin Murphy wrote: > On 2023-11-02 3:26 pm, Mark Brown wrote: > > This isn't a fix for the existing code, AFAICT the issue here is that > > ARCH_MMP is currently only available for arm and presumably something in > > the rest of your series makes it avail

Re: [PATCH v7 06/10] ASoC: pxa: Suppress SSPA on ARM64

2023-11-03 Thread Robin Murphy
On 2023-11-02 3:26 pm, Mark Brown wrote: On Thu, Nov 02, 2023 at 04:20:29PM +0100, Duje Mihanović wrote: The SSPA driver currently seems to generate ARM32 assembly, which causes build errors when building a kernel for an ARM64 ARCH_MMP platform. Fixes: fa375d42f0e5 ("ASoC: mmp: add sspa support

Re: [PATCH v7 06/10] ASoC: pxa: Suppress SSPA on ARM64

2023-11-02 Thread Mark Brown
On Thu, Nov 02, 2023 at 04:20:29PM +0100, Duje Mihanović wrote: > The SSPA driver currently seems to generate ARM32 assembly, which causes > build errors when building a kernel for an ARM64 ARCH_MMP platform. > > Fixes: fa375d42f0e5 ("ASoC: mmp: add sspa support") > Reported-by: kernel test robot

[PATCH v7 06/10] ASoC: pxa: Suppress SSPA on ARM64

2023-11-02 Thread Duje Mihanović
The SSPA driver currently seems to generate ARM32 assembly, which causes build errors when building a kernel for an ARM64 ARCH_MMP platform. Fixes: fa375d42f0e5 ("ASoC: mmp: add sspa support") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202310230518.zs9qpg3j-...@