Re: [PATCH v6 2/7] selftests: x86: test_mremap_vdso: skip if vdso is msealed

2025-02-24 Thread Jeff Xu
On Mon, Feb 24, 2025 at 1:05 PM Liam R. Howlett wrote: > > * jef...@chromium.org [250224 12:45]: > > From: Jeff Xu > > > > Add code to detect if the vdso is memory sealed, skip the test > > if it is. > > It also skips the test if fopen fails on smaps, but maybe that's super > rare? > If we can't

Re: [PATCH v6 2/7] selftests: x86: test_mremap_vdso: skip if vdso is msealed

2025-02-24 Thread Liam R. Howlett
* jef...@chromium.org [250224 12:45]: > From: Jeff Xu > > Add code to detect if the vdso is memory sealed, skip the test > if it is. It also skips the test if fopen fails on smaps, but maybe that's super rare? > > Signed-off-by: Jeff Xu > --- > .../testing/selftests/x86/test_mremap_vdso.c

Re: [PATCH v6 2/7] selftests: x86: test_mremap_vdso: skip if vdso is msealed

2025-02-24 Thread Kees Cook
On Mon, Feb 24, 2025 at 05:45:08PM +, jef...@chromium.org wrote: > From: Jeff Xu > > Add code to detect if the vdso is memory sealed, skip the test > if it is. > > Signed-off-by: Jeff Xu Thanks, after my full 360 on reading this code, I'm back to where I was originally: it looks good to me

[PATCH v6 2/7] selftests: x86: test_mremap_vdso: skip if vdso is msealed

2025-02-24 Thread jeffxu
From: Jeff Xu Add code to detect if the vdso is memory sealed, skip the test if it is. Signed-off-by: Jeff Xu --- .../testing/selftests/x86/test_mremap_vdso.c | 38 +++ 1 file changed, 38 insertions(+) diff --git a/tools/testing/selftests/x86/test_mremap_vdso.c b/tools/testi