Re: [PATCH v4 4/6] binfmt_elf: Use elf_load() for library

2023-09-29 Thread Kees Cook
On Fri, Sep 29, 2023 at 01:12:13PM +0100, Pedro Falcato wrote: > On Fri, Sep 29, 2023 at 4:24 AM Kees Cook wrote: > > > > While load_elf_library() is a libc5-ism, we can still replace most of > > its contents with elf_load() as well, further simplifying the code. > > While I understand you want t

Re: [PATCH v4 4/6] binfmt_elf: Use elf_load() for library

2023-09-29 Thread Eric W. Biederman
Pedro Falcato writes: > On Fri, Sep 29, 2023 at 4:24 AM Kees Cook wrote: >> >> While load_elf_library() is a libc5-ism, we can still replace most of >> its contents with elf_load() as well, further simplifying the code. > > While I understand you want to break as little as possible (as the ELF >

Re: [PATCH v4 4/6] binfmt_elf: Use elf_load() for library

2023-09-29 Thread Pedro Falcato
On Fri, Sep 29, 2023 at 4:24 AM Kees Cook wrote: > > While load_elf_library() is a libc5-ism, we can still replace most of > its contents with elf_load() as well, further simplifying the code. While I understand you want to break as little as possible (as the ELF loader maintainer), I'm wondering

[PATCH v4 4/6] binfmt_elf: Use elf_load() for library

2023-09-28 Thread Kees Cook
While load_elf_library() is a libc5-ism, we can still replace most of its contents with elf_load() as well, further simplifying the code. Cc: Alexander Viro Cc: Christian Brauner Cc: linux-fsde...@vger.kernel.org Cc: linux...@kvack.org Suggested-by: Eric Biederman Signed-off-by: Kees Cook ---